From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-x42e.google.com (mail-pf1-x42e.google.com [IPv6:2607:f8b0:4864:20::42e]) by sourceware.org (Postfix) with ESMTPS id D3BAB3858D20 for ; Thu, 16 Nov 2023 05:21:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D3BAB3858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org D3BAB3858D20 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::42e ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700112074; cv=none; b=RWKa6hxHXLaZOKP28pK/FmRDCA+MFNUvN95l9vmSubvYNZb5azzjDf5iHJ3PbJWSmQyym55FFEsTk5q57BzvQ1RRBeGZL9+A3kxoMdzInMklZNB+XivRIlbNYAVBR3/kUvdMJQYheHR0IbVKacS15bxhG4ITx4mXqQD5HZXurqQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700112074; c=relaxed/simple; bh=kodCd3MHK0LH4jq4aFgzF0RKuxBnqaoV42yyDvho+k0=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=dZ2U1lobQv8eX6UeiSzMmBK6dDNvz3YgLRJl+3OQzJSFA53U7Fcohd5Vkmq6Jvw+PTIcWAlPw+3dbPcun/sVGbTS+PRiB1b9kRzBGwBj2BAvg1AMcq7AfyxPPAG/iwsXK+5kAUasFcPbMfAH0sjT0gJb9VRiHzSpGZ0oe4aIazc= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pf1-x42e.google.com with SMTP id d2e1a72fcca58-6be0277c05bso374560b3a.0 for ; Wed, 15 Nov 2023 21:21:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700112072; x=1700716872; darn=gcc.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=RwrXU7SOfoDtXYzwEnoYIFm0nKb/ohyP5Bh/HUtWCsU=; b=TLVZPHEswtw9ZIZICeKpnTCZLgbjN/Ur1E1ihwD/e5jbhe9Eg0D4pcKkZNjI+Cx+J/ 6IBElQfTqRX/9Nx9ASMXDClkY2M6EiSIeN7Hvuq5IEEe6zc1hUaMu2DfQTaAAo5FG68I obhT1uGpDBSus+INGU5jCJvE5jVt7HkDqmMff1twhq1dLZo+qP9QXP8LGGZbGp2FWWzt UuHLVq9gJ+bgYE++qvTSu+W32NMhmumO+fiGdy6V65/VN56nmNrCoLopmbMk/iANrWU1 fdc9gWblyRrM2QVTYcMNPLScrgWtEMowz56ToibNlQmZkx4DGmSy7zsP7f3je3Q9xdQb pLDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700112072; x=1700716872; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=RwrXU7SOfoDtXYzwEnoYIFm0nKb/ohyP5Bh/HUtWCsU=; b=ug9Lfmyu0gdR2sCoaFQT/Fya8/4frdEgr87+Mh7l55e7CXxvuWR+lmSN1i0cXyfz+K /kKQ1NqxxeIsn6ujQ/fRd4Xojl0n4YTgC0D0FTlBZAsKBUCeqKetNr6Duc49cvXQpMQv Kk+8m1VHV/Z4DDITBggTfDyNqYpGND8OTsPPabl6PlD9FcFo4pWhHvjiPK53NBDTaJMx l9Kwx9zHpVbuMX0C4AYKOr83XQp61XtGjMiRaRcn+OgqToDiitwOFpUCKbl8dVnII7i2 1oHK/z4aYwYOUMS/pofnXTlIzvx/AJyQCD5AKE+9oSSuWJ4ZesQTdeiG5UkIsZT4tF0c k/CA== X-Gm-Message-State: AOJu0Yzcjnkt0JR5GgB/7uyisltloh6OlkzmCMj1ySmdG1W/FE4+VlzQ VuoSFJ64bedVWGJ46FeJ39o= X-Google-Smtp-Source: AGHT+IGXdQgdAhiAPjSt8vMCDtDgb/R+7UqZvcLsCwaHtHnl+Ru8Gzr30+Gg+VvZxQiw2MUitgE0XA== X-Received: by 2002:a05:6a00:3005:b0:666:e1f4:5153 with SMTP id ay5-20020a056a00300500b00666e1f45153mr15187013pfb.0.1700112071685; Wed, 15 Nov 2023 21:21:11 -0800 (PST) Received: from [172.31.0.109] ([136.36.130.248]) by smtp.gmail.com with ESMTPSA id j23-20020aa78d17000000b0068bbd43a6e2sm3770952pfe.10.2023.11.15.21.21.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 15 Nov 2023 21:21:11 -0800 (PST) Message-ID: Date: Wed, 15 Nov 2023 22:21:09 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] RISC-V: Implement TLS Descriptors. Content-Language: en-US To: Tatsuyuki Ishi , Fangrui Song Cc: Kito Cheng , gcc-patches@gcc.gnu.org, Rui Ueyama , ruiu@bluewhale.systems References: <20230817181308.122802-2-ishitatsuyuki@gmail.com> <20230908104923.31154-1-ishitatsuyuki@gmail.com> From: Jeff Law In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 11/15/23 18:39, Tatsuyuki Ishi wrote: > > As mentioned in the commit message, the use of relaxation-only labels > does not seem well supported in current GCC. Creating a label seems to > force a basic block and I’m not sure how we can avoid it. > > If there’s a better way to implement this I’m happy to adopt. In general, yes creating a label in the IL is going to create a new block. But you could emit the label as part of the auipc so that it doesn't really show up in the IL. Then you have to make sure the other insns reference the right label, which is certainly do-able. THere's also linker relaxing to worry about.... jeff