From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 0E7503858414 for ; Tue, 30 Apr 2024 15:47:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0E7503858414 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=polymtl.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=polymtl.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 0E7503858414 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=132.207.4.11 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1714492056; cv=none; b=vU4jnGWUNF2FPtqe6Pn0rZJq3Gdyjx3Gl/xWd6LjaiJS+ODn4CZbHvn1B86jk0KwccDVNvcYDQfqf4NC3pLM99wCPT11i7NvH//Lkpfy0NyHXfMd8MaLq/KoIs3W6n8pfMZ+daK78KDxjbLnZDVWBV5mLWmJ4zEzHgGcBK9TV9I= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1714492056; c=relaxed/simple; bh=FJaYe5yW2a0bH2xiMd8ENGwxBXSYDhV+LZyIn/KqrX4=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=fhh2JFlY+iaCK2t7XlfwAXaaqwrXOEO7NacP+BiU6gWcPHNDn+sHR0OVBVIxBW4mtmXpphgIGPD+vAStVeR0ZhwU/Gs83LszpVjfY3kUEXVD9PCXuKAFRdzNtgxH8Sl6NWH7lRiVTjiaN7IZyjUYmzjjrVD4ORuTRjWeTXuVGrY= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 43UFlSNc007044 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 30 Apr 2024 11:47:33 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 43UFlSNc007044 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=polymtl.ca; s=default; t=1714492054; bh=Tnp/pr0bjC0ueiXbLUDw3eTJO/JuM47vSCKSMTK/YXU=; h=Date:Subject:To:Cc:From:In-Reply-To:From; b=cbYAkfki3sSetCcxgjobWiTys9yJWES4I9KSXoyYsskU467WoSCmGpYnvdCHftKib XsQIkoan2JnAA3PDrtOxK77AMBFqoYagFdgO8CO6oxmHGgQY3bhw+N30Vqoimgjyl3 GYbU/gkguqbDQ4wo+0X6wSJ15sGGb8+ToTfkymBw= Received: from [10.0.0.170] (modemcable238.237-201-24.mc.videotron.ca [24.201.237.238]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 54ECE1E092; Tue, 30 Apr 2024 11:47:28 -0400 (EDT) Message-ID: Date: Tue, 30 Apr 2024 11:47:27 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] fixincludes: add AC_CONFIG_MACRO_DIRS to configure.ac To: Christophe Lyon Cc: gcc-patches@gcc.gnu.org References: <20240430022420.114397-1-simon.marchi@polymtl.ca> Content-Language: fr From: Simon Marchi In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Tue, 30 Apr 2024 15:47:28 +0000 X-Spam-Status: No, score=-3031.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 4/30/24 4:54 AM, Christophe Lyon wrote: > On Tue, 30 Apr 2024 at 04:25, Simon Marchi wrote: >> >> Add an "AC_CONFIG_MACRO_DIRS" call in configure.ac, with the same >> directories as specified in "ACLOCAL_AMFLAGS", in Makefile.in. >> >> This makes it possible to re-generate aclocal.m4 using "autoreconf". > > Thanks, this LGTM, although like in your other patch, we need a > ChangeLog entry in the commit message. > > Christophe Here is the ChangeLog entry: fixincludes/ChangeLog: * configure.ac: Add AC_CONFIG_MACRO_DIRS. * configure: Re-generate. I don't have access to the gcc repo, so if/when this patch gets approved, can you push it on my behalf? Thanks, Simon