From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io1-xd2d.google.com (mail-io1-xd2d.google.com [IPv6:2607:f8b0:4864:20::d2d]) by sourceware.org (Postfix) with ESMTPS id C95C63858D38 for ; Wed, 17 Jan 2024 14:42:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C95C63858D38 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org C95C63858D38 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::d2d ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705502540; cv=none; b=jT+Y4i0kIIH4+BA088K7tcR26pvMf2pk2+yBL/DoHecEZ3/+/q6yUDUDhcpPh7n03I44kUrWtuAQXH9r4Tqgk1bBjH4ZPYMDwBNNH+lN3gv6Gd7L/Ay0PRqFx2IxA6u3pmu/VyaniohhHB/dy1kfWNBuBSdqtX2t7+qQu1BSOPY= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705502540; c=relaxed/simple; bh=yKtfPs/AUlwGKkA/PrvTfeKZ5dYRVmQq17Lu08NGqMQ=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=cbZEOuEeW4d2ReY43rnVb33P/MK1rMS4O041UUqegg7sejZc04rwND3jgAvkBlbx6tpvCwtl43Y8lSUCh2vyEdjtj45eFQEU+UJ1afK+L+18rwo1GCVwvpK3P46rZpSJ/VOfF+8Lx5hEPT3VxEIthCzLasS8oe8Odhqxg1UOFts= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-io1-xd2d.google.com with SMTP id ca18e2360f4ac-7bbec1d1c9dso539649239f.1 for ; Wed, 17 Jan 2024 06:42:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1705502538; x=1706107338; darn=gcc.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=K8oxTHco+ka7uzpeUnmW+H2taWKgwxWXizA09F8tFhc=; b=ORjS3i4bqjne5sWVQd/CVPLJQaY03Iz9HR4qyCPwHYgeJk46g1LOeSBco+25f33FTa txSEhObmDC5GujaWxVHXrAYdN7xnul9H7ghjlBV4tKU6bvTRT1Pryw+2vdZQ2xvjV7Yh Yy9pDMTGDnyVbAUlkPf9VkwNInQvXQfyy4hAyzHkvTKIpAC/Brh2I54qI5nA11w+Hxla bc9Y1+W8TLT5LViE+/2Lm1uMHmP34eAnA+jpqEOub4/bTHW78c7Qq9ihERFsT9kDRHLq xSSFZEdO/hkJwicTf6Xpc+kpRMM+RT2itozzdItyAvEIfnDIQg69QN7gh/2yoM2vEQCw Tk5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705502538; x=1706107338; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=K8oxTHco+ka7uzpeUnmW+H2taWKgwxWXizA09F8tFhc=; b=OnRwnrg/HGQAW8afLxX8oMvx878GxEsRME6k6CwPecyhrbtwbvTGeg1cniORfWX/Hd odvKfXNwPQPFO8OgGm7d2nwkogkgtr6pJOrdFV67VVvv8NifLUFLNopx7tuBlqQRXyys nTsZsa85/S6LTmUA+uhhWGMEo//TwI9zBhOJ8/J3bfPMpne/WS1X2KW+564ZpredKTtR pQvjYx4Y5s43zOyxjNqk5s9OxnSukbwMXTxkRUofgNS1N9OC9UDqISUyVWQN8qQgQ5pA v2uqUb59DVHKpGYHqiqqFqRnUngGDZX81pGjlAQprMbcz6a/1h7/D9lA0Mc2rYx3E7Yf BsDw== X-Gm-Message-State: AOJu0Yxbat/O6WDUVXTfTgIk+y+obY5ioOdOAyRG8gw4gyA70uMHyMyr 7rWOdT64Lukz8YnoBowUhgk= X-Google-Smtp-Source: AGHT+IHx1morLWU5mF6g/J4Umt+EHYz2kGn+7Aq2hriaKfMYgwm0/GRYvEOKMN97FQNBWswitDDyxw== X-Received: by 2002:a6b:7803:0:b0:7bf:286f:2d92 with SMTP id j3-20020a6b7803000000b007bf286f2d92mr10167682iom.12.1705502537890; Wed, 17 Jan 2024 06:42:17 -0800 (PST) Received: from [172.31.0.109] ([136.36.72.243]) by smtp.gmail.com with ESMTPSA id c24-20020a02a618000000b0046d98c3cd7bsm450524jam.14.2024.01.17.06.42.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 17 Jan 2024 06:42:17 -0800 (PST) Message-ID: Date: Wed, 17 Jan 2024 07:42:15 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/4] rtl-ssa: Run finalize_new_accesses forwards [PR113070] Content-Language: en-US To: Alex Coplan , gcc-patches@gcc.gnu.org Cc: Richard Sandiford , Kyrylo Tkachov , Richard Earnshaw References: From: Jeff Law In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 1/13/24 08:43, Alex Coplan wrote: > The next patch in this series exposes an interface for creating new uses > in RTL-SSA. The intent is that new user-created uses can consume new > user-created defs in the same change group. This is so that we can > correctly update uses of memory when inserting a new store pair insn in > the aarch64 load/store pair fusion pass (the affected uses need to > consume the new store pair insn). > > As it stands, finalize_new_accesses is called as part of the backwards > insn placement loop within change_insns, but if we want new uses to be > able to depend on new defs in the same change group, we need > finalize_new_accesses to be called on earlier insns first. This is so > that when we process temporary uses and turn them into permanent uses, > we can follow the last_def link on the temporary def to ensure we end up > with a permanent use consuming a permanent def. > > Bootstrapped/regtested on aarch64-linux-gnu, OK for trunk? > > Thanks, > Alex > > gcc/ChangeLog: > > PR target/113070 > * rtl-ssa/changes.cc (function_info::change_insns): Split out the call > to finalize_new_accesses from the backwards placement loop, run it > forwards in a separate loop. So just to be explicit -- given this is adjusting the rtl-ssa infrastructure, I was going to let Richard S. own the review side -- he knows that code better than I. Jeff