From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id DF6CF3858284 for ; Fri, 15 Sep 2023 14:14:15 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org DF6CF3858284 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1694787255; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type; bh=AJ1hbCrQLbwoJoLQKnyvZfWTXT/441c68ruWx85K7+g=; b=OsGrfVa60GI8njQmP4wSawS4moESVX4Mjl6zWLtISRWNf3/OPd8dX6LaFi3SafJ2YjwL00 cDHOyZ+XOH88lhsaF52cpyyT4izdmcbSddS+OxUPYJ4a0XIHaFhORrQXQdkJpSepYfTRue zKSWjUOCPpLbNMNHgVLWms5FwOFDkqo= Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-631-aspQ-O-FOvq5tI8_bDNWGA-1; Fri, 15 Sep 2023 10:14:14 -0400 X-MC-Unique: aspQ-O-FOvq5tI8_bDNWGA-1 Received: by mail-qv1-f70.google.com with SMTP id 6a1803df08f44-6563873fef9so6606416d6.2 for ; Fri, 15 Sep 2023 07:14:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694787253; x=1695392053; h=subject:from:cc:to:content-language:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=lmB3/UxCFQWsiVdCvtdtf96oI1CIq3rsDTu0ckr3WWY=; b=CxrX7al+HS9bjyLMD4sEKOTa8A0OxZxs6CPbJYJCD/mvPX1cgUCMGUYLo3zM1wPmz+ f0lY9ucwNl8ku2hOIKOPQWqCEIW+NJ7P5oe+Vmu/t9oXp8en9fT9A9pL3YOQMRfxTadq 033+5bNb3loKlWYZNbyvlZgrh94Wn6KVZlAurgO+cRJOeMfIs+IBXxgK1dbWYjJDYYg+ YqAjwsctF7D9O6oCmkgfSbli7m7Ga7INt2ect81ErVBFmZCdM+hwH4E2uXkj9FHxRqvw Ysc8ETTomhEPLCipV2htW17M6/VhzTzbB2xco6kJNd6e4dnxy11Slbg9nnDVKQdrTn6E agjg== X-Gm-Message-State: AOJu0YwbwzvtFnfiEorosu8Bqyl/OqWG7JEPGpleal2i95itlBrZzSkf hV6zhTPourrzpCxEPCp22HU5qitc8fJMa9PBdWw3tY4wPJwhRatikB+spl4F+Cla2slCm/DJY4K RlHbIPzeS0XM5HWvoionCWBwxoEkAstLB0zqm7GkfjDPgVakwy5e34iD5bnRXe/XtKpoYDknO1y 0yhw== X-Received: by 2002:a0c:e448:0:b0:64f:69a3:af3f with SMTP id d8-20020a0ce448000000b0064f69a3af3fmr1890621qvm.39.1694787253121; Fri, 15 Sep 2023 07:14:13 -0700 (PDT) X-Google-Smtp-Source: AGHT+IH+6IfdfjO65qFn0NPIOBVwkAtuD92rTvvX7q7zZUU02CMj92PO/bBvqtXZPi5ze6nGC3Fwtg== X-Received: by 2002:a0c:e448:0:b0:64f:69a3:af3f with SMTP id d8-20020a0ce448000000b0064f69a3af3fmr1890596qvm.39.1694787252797; Fri, 15 Sep 2023 07:14:12 -0700 (PDT) Received: from ?IPV6:2605:8d80:5e0:23ed:dc0e:d72:28b1:179f? ([2605:8d80:5e0:23ed:dc0e:d72:28b1:179f]) by smtp.gmail.com with ESMTPSA id o10-20020a05620a110a00b0076cbcf8ad3bsm1246909qkk.55.2023.09.15.07.14.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 15 Sep 2023 07:14:12 -0700 (PDT) Message-ID: Date: Fri, 15 Sep 2023 10:14:11 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 To: gcc-patches Cc: "hernandez, aldy" From: Andrew MacLeod Subject: [COMMITTED 2/2] Always do PHI analysis before loop analysis. X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/mixed; boundary="------------9m6tnNWKEaWp3mcRT0ZLZkry" Content-Language: en-US X-Spam-Status: No, score=-12.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: This is a multi-part message in MIME format. --------------9m6tnNWKEaWp3mcRT0ZLZkry Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit The original invocation of phi_analysis was only invoked if there was no loop information available.  I have found situations where phi analysis enhances existing loop information, and as such this patch moves the phi analysis block to before loop analysis is invoked (in case a query is made from within that area), and does it unconditionally.  There is minimal impact on compilation time. Bootstrapped on x86_64-pc-linux-gnu with no regressions.  Pushed. Andrew --------------9m6tnNWKEaWp3mcRT0ZLZkry Content-Type: text/x-patch; charset=UTF-8; name="0002-Always-do-PHI-analysis-and-before-loop-analysis.patch" Content-Disposition: attachment; filename*0="0002-Always-do-PHI-analysis-and-before-loop-analysis.patch" Content-Transfer-Encoding: base64 RnJvbSA1ZDVmOTBlYzNiNGE5MzljYWU1Y2U0ZjMzYjc2ODQ5ZjZiMDhlM2E5IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBbmRyZXcgTWFjTGVvZCA8YW1hY2xlb2RAcmVkaGF0LmNvbT4K RGF0ZTogV2VkLCAxMyBTZXAgMjAyMyAxMDowOToxNiAtMDQwMApTdWJqZWN0OiBbUEFUQ0ggMi8z XSBBbHdheXMgZG8gUEhJIGFuYWx5c2lzIGFuZCBiZWZvcmUgbG9vcCBhbmFseXNpcy4KClBISSBh bmFseXNpcyB3YXNuJ3QgYmVpbmcgZG9uZSBpZiBsb29wIGFuYWx5c2lzIGZvdW5kIGEgdmFsdWUu ICBBbHdheXMKZG8gdGhlIFBISSBhbmFseXNpcywgYW5kIHJ1biBpdCBmb3IgYW4gaW5paXRhbCB2 YWx1ZSBiZWZvcmUgaW52b2tpbmcKbG9vcCBhbmFseXNpcy4KCgkqIGdpbXBsZS1yYW5nZS1mb2xk LmNjIChmb2xkX3VzaW5nX3JhbmdlOjpyYW5nZV9vZl9waGkpOiBBbHdheXMKCXJ1biBwaGkgYW5h bHlzaXMsIGFuZCBkbyBpdCBiZWZvcmUgbG9vcCBhbmFseXNpcy4KLS0tCiBnY2MvZ2ltcGxlLXJh bmdlLWZvbGQuY2MgfCA1MyArKysrKysrKysrKysrKysrKysrKy0tLS0tLS0tLS0tLS0tLS0tLS0t CiAxIGZpbGUgY2hhbmdlZCwgMjYgaW5zZXJ0aW9ucygrKSwgMjcgZGVsZXRpb25zKC0pCgpkaWZm IC0tZ2l0IGEvZ2NjL2dpbXBsZS1yYW5nZS1mb2xkLmNjIGIvZ2NjL2dpbXBsZS1yYW5nZS1mb2xk LmNjCmluZGV4IDAzODA1ZDg4ZDliLi5kMTk0NWNjYjU1NCAxMDA2NDQKLS0tIGEvZ2NjL2dpbXBs ZS1yYW5nZS1mb2xkLmNjCisrKyBiL2djYy9naW1wbGUtcmFuZ2UtZm9sZC5jYwpAQCAtOTM5LDcg KzkzOSwzMiBAQCBmb2xkX3VzaW5nX3JhbmdlOjpyYW5nZV9vZl9waGkgKHZyYW5nZSAmciwgZ3Bo aSAqcGhpLCBmdXJfc291cmNlICZzcmMpCiAJfQogICAgIH0KIAotICBib29sIGxvb3BfaW5mb19w ID0gZmFsc2U7CisgIC8vIElmIFBISSBhbmFseXNpcyBpcyBhdmFpbGFibGUsIHNlZSBpZiB0aGVy ZSBpcyBhbiBpbmlpdGFsIHJhbmdlLgorICBpZiAocGhpX2FuYWx5c2lzX2F2YWlsYWJsZV9wICgp CisgICAgICAmJiBpcmFuZ2U6OnN1cHBvcnRzX3AgKFRSRUVfVFlQRSAocGhpX2RlZikpKQorICAg IHsKKyAgICAgIHBoaV9ncm91cCAqZyA9IChwaGlfYW5hbHlzaXMoKSlbcGhpX2RlZl07CisgICAg ICBpZiAoZyAmJiAhKGctPnJhbmdlICgpLnZhcnlpbmdfcCAoKSkpCisJeworCSAgaWYgKGR1bXBf ZmlsZSAmJiAoZHVtcF9mbGFncyAmIFRERl9ERVRBSUxTKSkKKwkgICAgeworCSAgICAgIGZwcmlu dGYgKGR1bXBfZmlsZSwgIlBISSBHUk9VUCBxdWVyeSBmb3IgIik7CisJICAgICAgcHJpbnRfZ2Vu ZXJpY19leHByIChkdW1wX2ZpbGUsIHBoaV9kZWYsIFRERl9TTElNKTsKKwkgICAgICBmcHJpbnRm IChkdW1wX2ZpbGUsICIgZm91bmQgOiAiKTsKKwkgICAgICBnLT5yYW5nZSAoKS5kdW1wIChkdW1w X2ZpbGUpOworCSAgICAgIGZwcmludGYgKGR1bXBfZmlsZSwgIiBhbmQgYWRqdXN0ZWQgb3JpZ2lu YWwgcmFuZ2UgZnJvbSA6Iik7CisJICAgICAgci5kdW1wIChkdW1wX2ZpbGUpOworCSAgICB9CisJ ICByLmludGVyc2VjdCAoZy0+cmFuZ2UgKCkpOworCSAgaWYgKGR1bXBfZmlsZSAmJiAoZHVtcF9m bGFncyAmIFRERl9ERVRBSUxTKSkKKwkgICAgeworCSAgICAgIGZwcmludGYgKGR1bXBfZmlsZSwg IiB0byA6Iik7CisJICAgICAgci5kdW1wIChkdW1wX2ZpbGUpOworCSAgICAgIGZwcmludGYgKGR1 bXBfZmlsZSwgIlxuIik7CisJICAgIH0KKwl9CisgICAgfQorCiAgIC8vIElmIFNDRVYgaXMgYXZh aWxhYmxlLCBxdWVyeSBpZiB0aGlzIFBISSBoYXMgYW55IGtub3duIHZhbHVlcy4KICAgaWYgKHNj ZXZfaW5pdGlhbGl6ZWRfcCAoKQogICAgICAgJiYgIVBPSU5URVJfVFlQRV9QIChUUkVFX1RZUEUg KHBoaV9kZWYpKSkKQEAgLTk2MiwzMiArOTg3LDYgQEAgZm9sZF91c2luZ19yYW5nZTo6cmFuZ2Vf b2ZfcGhpICh2cmFuZ2UgJnIsIGdwaGkgKnBoaSwgZnVyX3NvdXJjZSAmc3JjKQogCQkgIGZwcmlu dGYgKGR1bXBfZmlsZSwgIlxuIik7CiAJCX0KIAkgICAgICByLmludGVyc2VjdCAobG9vcF9yYW5n ZSk7Ci0JICAgICAgbG9vcF9pbmZvX3AgPSB0cnVlOwotCSAgICB9Ci0JfQotICAgIH0KLQotICBp ZiAoIWxvb3BfaW5mb19wICYmIHBoaV9hbmFseXNpc19hdmFpbGFibGVfcCAoKQotICAgICAgJiYg aXJhbmdlOjpzdXBwb3J0c19wIChUUkVFX1RZUEUgKHBoaV9kZWYpKSkKLSAgICB7Ci0gICAgICBw aGlfZ3JvdXAgKmcgPSAocGhpX2FuYWx5c2lzKCkpW3BoaV9kZWZdOwotICAgICAgaWYgKGcgJiYg IShnLT5yYW5nZSAoKS52YXJ5aW5nX3AgKCkpKQotCXsKLQkgIGlmIChkdW1wX2ZpbGUgJiYgKGR1 bXBfZmxhZ3MgJiBUREZfREVUQUlMUykpCi0JICAgIHsKLQkgICAgICBmcHJpbnRmIChkdW1wX2Zp bGUsICJQSEkgR1JPVVAgcXVlcnkgZm9yICIpOwotCSAgICAgIHByaW50X2dlbmVyaWNfZXhwciAo ZHVtcF9maWxlLCBwaGlfZGVmLCBUREZfU0xJTSk7Ci0JICAgICAgZnByaW50ZiAoZHVtcF9maWxl LCAiIGZvdW5kIDogIik7Ci0JICAgICAgZy0+cmFuZ2UgKCkuZHVtcCAoZHVtcF9maWxlKTsKLQkg ICAgICBmcHJpbnRmIChkdW1wX2ZpbGUsICIgYW5kIGFkanVzdGVkIG9yaWdpbmFsIHJhbmdlIGZy b20gOiIpOwotCSAgICAgIHIuZHVtcCAoZHVtcF9maWxlKTsKLQkgICAgfQotCSAgci5pbnRlcnNl Y3QgKGctPnJhbmdlICgpKTsKLQkgIGlmIChkdW1wX2ZpbGUgJiYgKGR1bXBfZmxhZ3MgJiBUREZf REVUQUlMUykpCi0JICAgIHsKLQkgICAgICBmcHJpbnRmIChkdW1wX2ZpbGUsICIgdG8gOiIpOwot CSAgICAgIHIuZHVtcCAoZHVtcF9maWxlKTsKLQkgICAgICBmcHJpbnRmIChkdW1wX2ZpbGUsICJc biIpOwogCSAgICB9CiAJfQogICAgIH0KLS0gCjIuNDEuMAoK --------------9m6tnNWKEaWp3mcRT0ZLZkry--