From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by sourceware.org (Postfix) with ESMTPS id 19CAC3858D28 for ; Mon, 3 Jul 2023 03:19:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 19CAC3858D28 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linux.ibm.com Received: from pps.filterd (m0353729.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 3633CGco020950; Mon, 3 Jul 2023 03:19:41 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date : mime-version : subject : to : references : cc : from : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=S/YT+/CwwnLug16RW/WrO+odqmnSICfByp/BigSPHPM=; b=VehHwjUSUOHoZsnEpyBjjEn57CQRBfJpJ59lLzOTklpsQF7hC5rMKabQsFiLt4nS96S9 4YQvvkQoJDRE4lA3/swUPjH4JOI21/cD+h8kJ5ZRSD0HGsmBr+4bSNoKrDcwZ7VahYO0 qhGW97Tx9w4D51VHhQVSb+LWVszUhNdhdR7MlevqeY1+H87hkeiXT/2vCSM1UdNyEWst UDxZctSDs/NE8/lp3taY/Oue3xFLu/AWQfrdIdAmSYeJ9POnkarN45FzJR4lVd51EcuY Gse3j0nmxojmFjcqUYlQeJjnF7jKDaX7urgkxT1JucuNVXvx+lzVE0kFNoPur8Sacm0W nA== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3rkp7c05g5-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 03 Jul 2023 03:19:41 +0000 Received: from m0353729.ppops.net (m0353729.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 3633DLXs023982; Mon, 3 Jul 2023 03:19:40 GMT Received: from ppma03ams.nl.ibm.com (62.31.33a9.ip4.static.sl-reverse.com [169.51.49.98]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3rkp7c05ff-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 03 Jul 2023 03:19:40 +0000 Received: from pps.filterd (ppma03ams.nl.ibm.com [127.0.0.1]) by ppma03ams.nl.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 3633Bthg008376; Mon, 3 Jul 2023 03:19:38 GMT Received: from smtprelay04.fra02v.mail.ibm.com ([9.218.2.228]) by ppma03ams.nl.ibm.com (PPS) with ESMTPS id 3rjbs4s2aa-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 03 Jul 2023 03:19:38 +0000 Received: from smtpav02.fra02v.mail.ibm.com (smtpav02.fra02v.mail.ibm.com [10.20.54.101]) by smtprelay04.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 3633JaDp37618268 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 3 Jul 2023 03:19:36 GMT Received: from smtpav02.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 1E47D20043; Mon, 3 Jul 2023 03:19:36 +0000 (GMT) Received: from smtpav02.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 28A6120040; Mon, 3 Jul 2023 03:19:34 +0000 (GMT) Received: from [9.197.241.204] (unknown [9.197.241.204]) by smtpav02.fra02v.mail.ibm.com (Postfix) with ESMTP; Mon, 3 Jul 2023 03:19:33 +0000 (GMT) Message-ID: Date: Mon, 3 Jul 2023 11:19:32 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: [PATCH 4/9] vect: Adjust vectorizable_load costing on VMAT_ELEMENTWISE and VMAT_STRIDED_SLP Content-Language: en-US To: gcc-patches@gcc.gnu.org References: <0281a2a022869efe379130aea6e0782e4827ef61.1686573640.git.linkw@linux.ibm.com> Cc: richard.guenther@gmail.com, segher@kernel.crashing.org, bergner@linux.ibm.com, richard.sandiford@arm.com From: "Kewen.Lin" In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: LodnNKUNs2zaQz0yokT0MP9PMlQJkZlq X-Proofpoint-GUID: sEWV_bCrGxzZbOW-Fpx16vZcpAnPixHu X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26 definitions=2023-07-03_02,2023-06-30_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxlogscore=938 impostorscore=0 bulkscore=0 malwarescore=0 adultscore=0 lowpriorityscore=0 spamscore=0 priorityscore=1501 mlxscore=0 phishscore=0 clxscore=1015 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2305260000 definitions=main-2307030027 X-Spam-Status: No, score=-6.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Richard, on 2023/7/2 16:58, Richard Sandiford wrote: > Kewen Lin writes: >> @@ -9743,11 +9739,23 @@ vectorizable_load (vec_info *vinfo, >> unsigned int n_groups = 0; >> for (j = 0; j < ncopies; j++) >> { >> - if (nloads > 1) >> + if (nloads > 1 && !costing_p) >> vec_alloc (v, nloads); >> gimple *new_stmt = NULL; >> for (i = 0; i < nloads; i++) >> { >> + if (costing_p) >> + { >> + if (VECTOR_TYPE_P (ltype)) >> + vect_get_load_cost (vinfo, stmt_info, 1, >> + alignment_support_scheme, misalignment, >> + false, &inside_cost, nullptr, cost_vec, >> + cost_vec, true); >> + else >> + inside_cost += record_stmt_cost (cost_vec, 1, scalar_load, >> + stmt_info, 0, vect_body); >> + continue; >> + } > > Just a note that this might make life harder for AArch64 costing. > Strided SLP loads are still equivalent to vector loads for AArch64, > since they happen on the FPR/vector side even if they have integral > modes. > > But I agree this is more accurate from a general target-independent POV, > especially given the relatively coarse-grain costing enum. So I think > that's just something AArch64 will need to account for. Sorry for the inconvenience. Hope accounting for it with target hook on vect costing isn't very complicated. BR, Kewen