From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 2859C3858429 for ; Thu, 11 Aug 2022 14:22:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 2859C3858429 Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-516-h0yIueZsMwi6kKUGr_zMzA-1; Thu, 11 Aug 2022 10:22:48 -0400 X-MC-Unique: h0yIueZsMwi6kKUGr_zMzA-1 Received: by mail-qt1-f197.google.com with SMTP id k10-20020ac85fca000000b00342f51f0b13so9598483qta.11 for ; Thu, 11 Aug 2022 07:22:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:user-agent:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc; bh=8FjTCqZVTuScroS07GghM6Vyiw8oKLS6sllWznAyjLg=; b=sZw7itmahZSxIdeFH1CrTI55ByMDnyCMmaYMCMFYdm5CXokwhsGUx4XRu6C0jfiBh0 GDOJEvPU1mVQ7HihvFI+jSsmmwqhK+B/GqBBBaVlxGYWhQwQhWSwQ66xKLq/WUCFuFv7 IaT+EblGO4/f3IIjs50agpCMUII7+6fHCW6g2O8wlF821DcbXAgXDHFn5sRhWZMTbTDj 2OHAz4eJ8fTq595mGhTjbDTesyZVHmnozcHc8IjqwjnhQCh2yV80GHm83LnHYo9BmXTT Nh+fOvi4bA+LgV0RbUWqrlhX5XLBjI/ZfX2EDU6Bsdr3ois4DMXN+hKakkFpAMseKsR1 8ExA== X-Gm-Message-State: ACgBeo3wC2AddznFevKuLFBaR+F1DXOWJ6DyOIk0lDIuKO1NWnOQ9YwY 21oaJgt3gDhKA2SajGqQg/VaMoPk7toFDGSE4hqvgDjMPJBJ08InFjh41xsqRR2vqYJN2jTrX6Q HAM60oqeLP8mOTeIPpQ== X-Received: by 2002:a05:622a:1391:b0:31e:f6b2:d3aa with SMTP id o17-20020a05622a139100b0031ef6b2d3aamr28485821qtk.523.1660227768260; Thu, 11 Aug 2022 07:22:48 -0700 (PDT) X-Google-Smtp-Source: AA6agR6QwOx8F+JAyeP3UDk5DUHRW2RHesUrBhdU/HK5K5LTFa7FKVMOQkzBoMGCzrW+tDrijiOVWA== X-Received: by 2002:a05:622a:1391:b0:31e:f6b2:d3aa with SMTP id o17-20020a05622a139100b0031ef6b2d3aamr28485811qtk.523.1660227768091; Thu, 11 Aug 2022 07:22:48 -0700 (PDT) Received: from t14s.localdomain (c-73-69-212-193.hsd1.ma.comcast.net. [73.69.212.193]) by smtp.gmail.com with ESMTPSA id i11-20020a05620a404b00b006b949afa980sm2125678qko.56.2022.08.11.07.22.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Aug 2022 07:22:47 -0700 (PDT) Message-ID: Subject: Re: [PATCH] analyzer: fix ICE casued by dup2 in sm-fd.cc[PR106551] From: David Malcolm To: mirimnan017@gmail.com, gcc-patches@gcc.gnu.org Cc: Immad Mir Date: Thu, 11 Aug 2022 10:22:45 -0400 In-Reply-To: References: User-Agent: Evolution 3.38.4 (3.38.4-1.fc33) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.7 required=5.0 tests=BAYES_00, BODY_8BITS, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 Aug 2022 14:22:51 -0000 On Thu, 2022-08-11 at 14:41 +0530, Immad Mir wrote: > This patch fixes the ICE caused by valid_to_unchecked_state, > at analyzer/sm-fd.cc by handling the m_start state in > check_for_dup. > > Tested lightly on x86_64. > > gcc/analyzer/ChangeLog: >         PR analyzer/106551 >         * sm-fd.cc (check_for_dup): handle the m_start >         state when transitioning the state of LHS >         of dup, dup2 and dup3 call. > > gcc/testsuite/ChangeLog: >         * gcc.dg/analyzer/fd-dup-1.c: New testcases. >         * gcc.dg/analyzer/fd-uninit-1.c: Remove bogus >         warning. > Signed-off-by: Immad Mir Thanks for the updated patch; looks ready for trunk. Dave