From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-x52e.google.com (mail-ed1-x52e.google.com [IPv6:2a00:1450:4864:20::52e]) by sourceware.org (Postfix) with ESMTPS id 79E5C3882123 for ; Fri, 14 Jun 2024 16:00:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 79E5C3882123 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 79E5C3882123 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::52e ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1718380857; cv=none; b=DnI5JoF/a84XtuUIcd1WM06CVuLl8uiT0RyU/JuRgT8W1Vbz/fcb+8ATNtJ7B51xCuM0LKHyGGsZTwCHfh3E/Hw/jNaqkVpthRLVily6Ra/E1iMpKo132l1qy6yX3VMZtJvhVhrMCxyIs0/A3qwgsck88pOmDq0q/l7gObKlUFI= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1718380857; c=relaxed/simple; bh=k7yYyVZeNYpH3D46DZHwAPmT2CF95lfK6EDNypJjhz4=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=SVmCJw02G+2HO2JJIS+tJDj/XpGT90IW+E/AtNAbT2jUe62Scq2AkY/B2sX2mTGWwKzpyY3DTD3iiYPv2cNk1g8j9TpgwW/HGNnu0j8qbh+SSHhArqjg+Jo10ITTxVN2PX0qlcyKH7izZd+FRISBk8tuKUaOLeUkdY/0dfKesDI= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-ed1-x52e.google.com with SMTP id 4fb4d7f45d1cf-57c73a3b3d7so2650505a12.1 for ; Fri, 14 Jun 2024 09:00:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1718380853; x=1718985653; darn=gcc.gnu.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:cc:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=E57Ip/DPFxrBDDsmQjQoDN67l9ShfBQrFv9cBALM+eI=; b=IgEB6kIxcab6SgtSdOnf+Q1AiL6/X+wL8u9XaqNbYh/z+n+F6gSJo0p3mK7QFI6oyu Xj6lIk3Ayncyco56MHWIyACZVS/Us/M+0aPcwaoyNaMpIMrAXMakfvdNw+MXzTixUa+d 5ldihFCh4vpP5qW7dyuFoOyQee9mYB+s0CtARMcCtimtqLtKByxokqEuAGSTkqgjOtAj zrym5JytCCjcmXBTZY5yetUWkyFWxO6AwzIb5pogzlovhzwbdpCbL/W5w+m31Vyhyhqw zItlouz3s6glAGV3pJ7Minicn0zKhY5G/9j64kikj7QtCnRV7qRZSZKVZVyO7SYDzNez 2EYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718380853; x=1718985653; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:cc:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=E57Ip/DPFxrBDDsmQjQoDN67l9ShfBQrFv9cBALM+eI=; b=MAP7KTBpgPwnRDBsaHs7FoIxTJ4v6ZMGLt6sXBUeQ8bq2JbMCCjkTQ5oi58CGHqQt0 Fcgt7UtMqYndztxnkeoKGLaRhkTRv5JRBwG62xB5irbVXq3wJyMYWCwjCpW/mKSOLzbP 7uthnVsj/M8LtZcxohAGKy3KQwRERZMQIrhQdTyoQu7TawgDXzZmm/duFKE+exKDsmrq juiVnY0dKYdzPeUlYKlPRxfkcL6TBgxyZzQ2TWvOzylD25Ojmr/JygKauWDVhngL/erQ ZT6ELL54EP3xdtuvdta5NUP5OKNhiq/crCCfiAnlI3iVW77LRVdDlaZoO3AtUZ5GymO7 kjyw== X-Forwarded-Encrypted: i=1; AJvYcCWIjfqkCeqtceyeudy/LaeE4xFq8aCPKADXfeQ8EizGAXRJc1Xc5il/LLp/jV1qQ01F5LrOHE/wxBMtitTSLYRfYxaC4vIupA== X-Gm-Message-State: AOJu0Yx75OEntCMJWx3Hp5xSZiU9WTdPzI9VOSjMkrYXNY24ztK03EWu yBeirmD6+U9zYn1bZpru7Q2iGZJ0UU8Xn9YnGkxvMQQKdpVeN7hv X-Google-Smtp-Source: AGHT+IF4vw33JV3xCvfFdQMZxWWHQsBYRMI7+lWojNjee0GSOlLO7yGGQ5FzeBeP8wdXj3QruxeZjw== X-Received: by 2002:a50:d7c2:0:b0:57c:b7c3:99f1 with SMTP id 4fb4d7f45d1cf-57cbd6635f7mr2190311a12.11.1718380852899; Fri, 14 Jun 2024 09:00:52 -0700 (PDT) Received: from [192.168.1.23] (ip-149-172-150-237.um42.pools.vodafone-ip.de. [149.172.150.237]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-57cb72e95d7sm2435976a12.47.2024.06.14.09.00.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 14 Jun 2024 09:00:52 -0700 (PDT) Message-ID: Date: Fri, 14 Jun 2024 18:00:51 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Cc: rdapp.gcc@gmail.com, gnu-toolchain@rivosinc.com, Robin Dapp Subject: Re: [PATCH V2 1/2] RISC-V: Fix vwsll combine on rv32 targets To: Edwin Lu , gcc-patches@gcc.gnu.org References: <20240613205626.244598-1-ewlu@rivosinc.com> <20240613205626.244598-2-ewlu@rivosinc.com> Content-Language: en-US From: Robin Dapp In-Reply-To: <20240613205626.244598-2-ewlu@rivosinc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-9.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > diff --git a/gcc/config/riscv/autovec-opt.md b/gcc/config/riscv/autovec-opt.md > index 6a2eabbd854..29916adb62b 100644 > --- a/gcc/config/riscv/autovec-opt.md > +++ b/gcc/config/riscv/autovec-opt.md > @@ -1517,8 +1517,7 @@ (define_insn_and_split "*vwsll_zext1_scalar_" > "&& 1" > [(const_int 0)] > { > - if (GET_CODE (operands[2]) == SUBREG) > - operands[2] = SUBREG_REG (operands[2]); > + operands[2] = gen_lowpart (Pmode, operands[2]); > insn_code icode = code_for_pred_vwsll_scalar (mode); > riscv_vector::emit_vlmax_insn (icode, riscv_vector::BINARY_OP, operands); > DONE; Please also correct it in the other expander (_trunc_). OK with that change if the testsuite still looks ok :) Regards Robin