From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by sourceware.org (Postfix) with ESMTPS id 678C3385F01D for ; Thu, 2 Apr 2020 10:33:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 678C3385F01D Received: from pps.filterd (m0098410.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 032AWGNW097498 for ; Thu, 2 Apr 2020 06:33:12 -0400 Received: from e06smtp02.uk.ibm.com (e06smtp02.uk.ibm.com [195.75.94.98]) by mx0a-001b2d01.pphosted.com with ESMTP id 304swss4ty-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 02 Apr 2020 06:33:12 -0400 Received: from localhost by e06smtp02.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 2 Apr 2020 11:32:58 +0100 Received: from b06avi18878370.portsmouth.uk.ibm.com (9.149.26.194) by e06smtp02.uk.ibm.com (192.168.101.132) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Thu, 2 Apr 2020 11:32:55 +0100 Received: from d06av24.portsmouth.uk.ibm.com (d06av24.portsmouth.uk.ibm.com [9.149.105.60]) by b06avi18878370.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 032AX6JW40173846 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 2 Apr 2020 10:33:07 GMT Received: from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id D3D364204B; Thu, 2 Apr 2020 10:33:06 +0000 (GMT) Received: from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 0D21C4203F; Thu, 2 Apr 2020 10:33:04 +0000 (GMT) Received: from KewenLins-MacBook-Pro.local (unknown [9.197.245.104]) by d06av24.portsmouth.uk.ibm.com (Postfix) with ESMTP; Thu, 2 Apr 2020 10:33:03 +0000 (GMT) Subject: Re: [PATCH] Fix PR94401 by considering reverse overrun To: Richard Biener Cc: GCC Patches , Segher Boessenkool , Bill Schmidt References: From: "Kewen.Lin" Date: Thu, 2 Apr 2020 18:33:02 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/mixed; boundary="------------82A8E8ABCFF467F39A021EB3" Content-Language: en-US X-TM-AS-GCONF: 00 x-cbid: 20040210-0008-0000-0000-00000369036D X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 20040210-0009-0000-0000-00004A8A8ED2 Message-Id: X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.138, 18.0.676 definitions=2020-04-02_01:2020-03-31, 2020-04-02 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 suspectscore=0 bulkscore=0 clxscore=1015 lowpriorityscore=0 mlxlogscore=999 phishscore=0 adultscore=0 impostorscore=0 malwarescore=0 priorityscore=1501 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2003020000 definitions=main-2004020092 X-Spam-Status: No, score=-24.9 required=5.0 tests=BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, KAM_DMARC_STATUS, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 Apr 2020 10:33:14 -0000 This is a multi-part message in MIME format. --------------82A8E8ABCFF467F39A021EB3 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit on 2020/4/2 下午5:21, Richard Biener wrote: > On Thu, Apr 2, 2020 at 9:15 AM Kewen.Lin wrote: >> >> Hi, >> >> The commit r10-7415 brings scalar type consideration >> to eliminate epilogue peeling for gaps, but it exposed >> one problem that the current handling doesn't consider >> the memory access type VMAT_CONTIGUOUS_REVERSE, for >> which the overrun happens on low address side. This >> patch is to make the code take care of it by updating >> the offset and construction element order accordingly. >> >> Bootstrapped/regtested on powerpc64le-linux-gnu P8 >> and aarch64-linux-gnu. > > OK with the formatting changes suggested by Jakub. > Thanks Richi, I'll push the formatted one as attached. BR, Kewen --------------82A8E8ABCFF467F39A021EB3 Content-Type: text/plain; charset=UTF-8; x-mac-type="0"; x-mac-creator="0"; name="PR94401_REVERSE_formatted.diff" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="PR94401_REVERSE_formatted.diff" ZGlmZiAtLWdpdCBhL2djYy90cmVlLXZlY3Qtc3RtdHMuYyBiL2djYy90cmVlLXZlY3Qtc3Rt dHMuYwppbmRleCAxMmJlZWY2OTc4Yy4uNzczMGU3MWI5NGQgMTAwNjQ0Ci0tLSBhL2djYy90 cmVlLXZlY3Qtc3RtdHMuYworKysgYi9nY2MvdHJlZS12ZWN0LXN0bXRzLmMKQEAgLTk1OTAs MTEgKzk1OTAsMjAgQEAgdmVjdG9yaXphYmxlX2xvYWQgKHN0bXRfdmVjX2luZm8gc3RtdF9p bmZvLCBnaW1wbGVfc3RtdF9pdGVyYXRvciAqZ3NpLAogCQkJICAgIGlmIChuZXdfdnR5cGUg IT0gTlVMTF9UUkVFKQogCQkJICAgICAgbHR5cGUgPSBoYWxmX3Z0eXBlOwogCQkJICB9CisJ CQl0cmVlIG9mZnNldAorCQkJICA9IChkYXRhcmVmX29mZnNldCA/IGRhdGFyZWZfb2Zmc2V0 CisJCQkJCSAgICA6IGJ1aWxkX2ludF9jc3QgKHJlZl90eXBlLCAwKSk7CisJCQlpZiAobHR5 cGUgIT0gdmVjdHlwZQorCQkJICAgICYmIG1lbW9yeV9hY2Nlc3NfdHlwZSA9PSBWTUFUX0NP TlRJR1VPVVNfUkVWRVJTRSkKKwkJCSAgeworCQkJICAgIHVuc2lnbmVkIEhPU1RfV0lERV9J TlQgZ2FwCisJCQkgICAgICA9IERSX0dST1VQX0dBUCAoZmlyc3Rfc3RtdF9pbmZvKTsKKwkJ CSAgICBnYXAgKj0gdHJlZV90b191aHdpIChUWVBFX1NJWkVfVU5JVCAoZWxlbV90eXBlKSk7 CisJCQkgICAgdHJlZSBnYXBjc3QgPSBidWlsZF9pbnRfY3N0IChyZWZfdHlwZSwgZ2FwKTsK KwkJCSAgICBvZmZzZXQgPSBzaXplX2Jpbm9wIChQTFVTX0VYUFIsIG9mZnNldCwgZ2FwY3N0 KTsKKwkJCSAgfQogCQkJZGF0YV9yZWYKLQkJCSAgPSBmb2xkX2J1aWxkMiAoTUVNX1JFRiwg bHR5cGUsIGRhdGFyZWZfcHRyLAotCQkJCQkgZGF0YXJlZl9vZmZzZXQKLQkJCQkJID8gZGF0 YXJlZl9vZmZzZXQKLQkJCQkJIDogYnVpbGRfaW50X2NzdCAocmVmX3R5cGUsIDApKTsKKwkJ CSAgPSBmb2xkX2J1aWxkMiAoTUVNX1JFRiwgbHR5cGUsIGRhdGFyZWZfcHRyLCBvZmZzZXQp OwogCQkJaWYgKGFsaWdubWVudF9zdXBwb3J0X3NjaGVtZSA9PSBkcl9hbGlnbmVkKQogCQkJ ICA7CiAJCQllbHNlIGlmIChEUl9NSVNBTElHTk1FTlQgKGZpcnN0X2RyX2luZm8pID09IC0x KQpAQCAtOTYwNywxNiArOTYxNiwyNyBAQCB2ZWN0b3JpemFibGVfbG9hZCAoc3RtdF92ZWNf aW5mbyBzdG10X2luZm8sIGdpbXBsZV9zdG10X2l0ZXJhdG9yICpnc2ksCiAJCQkJCQkgIFRZ UEVfQUxJR04gKGVsZW1fdHlwZSkpOwogCQkJaWYgKGx0eXBlICE9IHZlY3R5cGUpCiAJCQkg IHsKLQkJCSAgICB2ZWN0X2NvcHlfcmVmX2luZm8gKGRhdGFfcmVmLCBEUl9SRUYgKGZpcnN0 X2RyX2luZm8tPmRyKSk7CisJCQkgICAgdmVjdF9jb3B5X3JlZl9pbmZvIChkYXRhX3JlZiwK KwkJCQkJCURSX1JFRiAoZmlyc3RfZHJfaW5mby0+ZHIpKTsKIAkJCSAgICB0cmVlIHRlbSA9 IG1ha2Vfc3NhX25hbWUgKGx0eXBlKTsKIAkJCSAgICBuZXdfc3RtdCA9IGdpbXBsZV9idWls ZF9hc3NpZ24gKHRlbSwgZGF0YV9yZWYpOwotCQkJICAgIHZlY3RfZmluaXNoX3N0bXRfZ2Vu ZXJhdGlvbiAoc3RtdF9pbmZvLCBuZXdfc3RtdCwgZ3NpKTsKKwkJCSAgICB2ZWN0X2Zpbmlz aF9zdG10X2dlbmVyYXRpb24gKHN0bXRfaW5mbywgbmV3X3N0bXQsCisJCQkJCQkJIGdzaSk7 CiAJCQkgICAgZGF0YV9yZWYgPSBOVUxMOwogCQkJICAgIHZlYzxjb25zdHJ1Y3Rvcl9lbHQs IHZhX2djPiAqdjsKIAkJCSAgICB2ZWNfYWxsb2MgKHYsIDIpOwotCQkJICAgIENPTlNUUlVD VE9SX0FQUEVORF9FTFQgKHYsIE5VTExfVFJFRSwgdGVtKTsKLQkJCSAgICBDT05TVFJVQ1RP Ul9BUFBFTkRfRUxUICh2LCBOVUxMX1RSRUUsCi0JCQkJCQkgICAgYnVpbGRfemVyb19jc3Qg KGx0eXBlKSk7CisJCQkgICAgaWYgKG1lbW9yeV9hY2Nlc3NfdHlwZSA9PSBWTUFUX0NPTlRJ R1VPVVNfUkVWRVJTRSkKKwkJCSAgICAgIHsKKwkJCQlDT05TVFJVQ1RPUl9BUFBFTkRfRUxU ICh2LCBOVUxMX1RSRUUsCisJCQkJCQkJYnVpbGRfemVyb19jc3QgKGx0eXBlKSk7CisJCQkJ Q09OU1RSVUNUT1JfQVBQRU5EX0VMVCAodiwgTlVMTF9UUkVFLCB0ZW0pOworCQkJICAgICAg fQorCQkJICAgIGVsc2UKKwkJCSAgICAgIHsKKwkJCQlDT05TVFJVQ1RPUl9BUFBFTkRfRUxU ICh2LCBOVUxMX1RSRUUsIHRlbSk7CisJCQkJQ09OU1RSVUNUT1JfQVBQRU5EX0VMVCAodiwg TlVMTF9UUkVFLAorCQkJCQkJCWJ1aWxkX3plcm9fY3N0IChsdHlwZSkpOworCQkJICAgICAg fQogCQkJICAgIGdjY19hc3NlcnQgKG5ld192dHlwZSAhPSBOVUxMX1RSRUUpOwogCQkJICAg IGlmIChuZXdfdnR5cGUgPT0gdmVjdHlwZSkKIAkJCSAgICAgIG5ld19zdG10ID0gZ2ltcGxl X2J1aWxkX2Fzc2lnbiAoCg== --------------82A8E8ABCFF467F39A021EB3--