From: Richard Earnshaw <Richard.Earnshaw@foss.arm.com>
To: Richard Biener <rguenther@suse.de>, gcc-patches@gcc.gnu.org
Cc: richard.sandiford@arm.com
Subject: Re: [PATCH 1/9] aarch64: Don't add crtfastmath.o for -shared
Date: Fri, 13 Jan 2023 10:49:34 +0000 [thread overview]
Message-ID: <f758895b-3953-ae29-eaf1-02cd6e3525f9@foss.arm.com> (raw)
In-Reply-To: <20230113075953.34CCB13913@imap2.suse-dmz.suse.de>
On 13/01/2023 07:59, Richard Biener via Gcc-patches wrote:
> Don't add crtfastmath.o for -shared to avoid altering the FP
> environment when loading a shared library.
>
> PR target/55522
> * config/aarch64/aarch64-elf-raw.h (ENDFILE_SPEC): Don't add
> crtfastmath.o for -shared.
> * config/aarch64/aarch64-freebsd.h (GNU_USER_TARGET_MATHFILE_SPEC):
> Likewise.
> * config/aarch64/aarch64-linux.h (GNU_USER_TARGET_MATHFILE_SPEC):
> Likewise.
> ---
> gcc/config/aarch64/aarch64-elf-raw.h | 2 +-
> gcc/config/aarch64/aarch64-freebsd.h | 2 +-
> gcc/config/aarch64/aarch64-linux.h | 2 +-
> 3 files changed, 3 insertions(+), 3 deletions(-)
>
OK.
R.
> diff --git a/gcc/config/aarch64/aarch64-elf-raw.h b/gcc/config/aarch64/aarch64-elf-raw.h
> index d4d820a9d54..fa5b4527ea0 100644
> --- a/gcc/config/aarch64/aarch64-elf-raw.h
> +++ b/gcc/config/aarch64/aarch64-elf-raw.h
> @@ -25,7 +25,7 @@
> #define STARTFILE_SPEC " crti%O%s crtbegin%O%s crt0%O%s"
> #define ENDFILE_SPEC \
> " crtend%O%s crtn%O%s " \
> - "%{Ofast|ffast-math|funsafe-math-optimizations:crtfastmath.o%s}"
> + "%{Ofast|ffast-math|funsafe-math-optimizations:%{!shared:crtfastmath.o%s}}"
>
> #ifndef LINK_SPEC
> #define LINK_SPEC "%{h*} \
> diff --git a/gcc/config/aarch64/aarch64-freebsd.h b/gcc/config/aarch64/aarch64-freebsd.h
> index 13beb3781b6..2cf9cf6f046 100644
> --- a/gcc/config/aarch64/aarch64-freebsd.h
> +++ b/gcc/config/aarch64/aarch64-freebsd.h
> @@ -50,7 +50,7 @@
> #define LINK_SPEC FBSD_TARGET_LINK_SPEC AARCH64_ERRATA_LINK_SPEC
>
> #define GNU_USER_TARGET_MATHFILE_SPEC \
> - "%{Ofast|ffast-math|funsafe-math-optimizations:crtfastmath.o%s}"
> + "%{Ofast|ffast-math|funsafe-math-optimizations:%{!shared:crtfastmath.o%s}}"
>
> #undef ENDFILE_SPEC
> #define ENDFILE_SPEC \
> diff --git a/gcc/config/aarch64/aarch64-linux.h b/gcc/config/aarch64/aarch64-linux.h
> index 5e4553d79f5..61ed4067fc5 100644
> --- a/gcc/config/aarch64/aarch64-linux.h
> +++ b/gcc/config/aarch64/aarch64-linux.h
> @@ -50,7 +50,7 @@
> #define LINK_SPEC LINUX_TARGET_LINK_SPEC AARCH64_ERRATA_LINK_SPEC
>
> #define GNU_USER_TARGET_MATHFILE_SPEC \
> - "%{Ofast|ffast-math|funsafe-math-optimizations:crtfastmath.o%s}"
> + "%{Ofast|ffast-math|funsafe-math-optimizations:%{!shared:crtfastmath.o%s}}"
>
> #undef ENDFILE_SPEC
> #define ENDFILE_SPEC \
prev parent reply other threads:[~2023-01-13 10:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-13 7:59 Richard Biener
2023-01-13 10:49 ` Richard Earnshaw [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f758895b-3953-ae29-eaf1-02cd6e3525f9@foss.arm.com \
--to=richard.earnshaw@foss.arm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=rguenther@suse.de \
--cc=richard.sandiford@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).