From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gerald@pfeifer.com>
Received: from hamza.pair.com (hamza.pair.com [209.68.5.143])
 by sourceware.org (Postfix) with ESMTPS id CDF2D3858D28
 for <gcc-patches@gcc.gnu.org>; Thu, 18 Aug 2022 20:53:39 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org CDF2D3858D28
Authentication-Results: sourceware.org;
 dmarc=none (p=none dis=none) header.from=pfeifer.com
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=pfeifer.com
Received: from hamza.pair.com (localhost [127.0.0.1])
 by hamza.pair.com (Postfix) with ESMTP id D811E33E73;
 Thu, 18 Aug 2022 16:53:37 -0400 (EDT)
Received: from [192.168.42.150] (213162081030.public.t-mobile.at
 [213.162.81.30])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
 (No client certificate requested)
 by hamza.pair.com (Postfix) with ESMTPSA id 334DD33EAD;
 Thu, 18 Aug 2022 16:53:37 -0400 (EDT)
Date: Thu, 18 Aug 2022 22:53:29 +0200 (CEST)
From: Gerald Pfeifer <gerald@pfeifer.com>
To: =?ISO-8859-15?Q?Martin_Li=A8ka?= <mliska@suse.cz>
cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH][DOCS] Document make jobserver related changes for GCC 13.
In-Reply-To: <87f6f563-8e1a-0f14-8993-cc0bfb3d926c@suse.cz>
Message-ID: <f75d5211-8d21-f4d1-a4cf-5860d0c9e77a@pfeifer.com>
References: <87f6f563-8e1a-0f14-8993-cc0bfb3d926c@suse.cz>
MIME-Version: 1.0
X-Scanned-By: mailmunge 3.09 on 209.68.5.143
X-Spam-Status: No, score=-3.6 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS,
 SPF_HELO_NONE, SPF_PASS, TXREP,
 T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
 server2.sourceware.org
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT
X-Content-Filtered-By: Mailman/MimeDel 2.1.29
X-BeenThere: gcc-patches@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gcc-patches mailing list <gcc-patches.gcc.gnu.org>
List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-patches>,
 <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-request@gcc.gnu.org?subject=help>
List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-patches>,
 <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 18 Aug 2022 20:53:40 -0000

On Thu, 18 Aug 2022, Martin Liška wrote:
> Ready for master?

Nearly. :)

> +    Link-time optimization improvements:
> +    <ul>
> +        <li>LTO supports the newly added GNU make's jobserver that uses named pipes (<code>--jobserver-style=fifo</code>)

I believe that's just "GNU make" (instead of "GNU make's"), or maybe 
"...the newly added jobserver of GNU make...".

Not 100% sure myself.

> +        <li>If make's jobserver is active, parallel LTO WPA streaming 
>    communicates with it and so the streaming
> +        does not lead to the system overcommitting.</li>

Might we be able to simplify this to something like

  "...parallel LTO WPA streaming communicates with it and thus avoids
  system overcommitting" ?


Just two minor points; the patch as such looks fine.

Thank you,
Gerald