From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id 300BC3858D28 for ; Tue, 20 Feb 2024 11:50:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 300BC3858D28 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=loongson.cn Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=loongson.cn ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 300BC3858D28 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2001:470:142:3::10 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1708429860; cv=none; b=URylLGtk3tUFpYwMhLe2WJBil/SqWwsNFikHKfaFAg4JFmeju2mK8glLkXxPPtmPmdAUVYfqlT3nm1DexWz/j28Pa6NKGfaA1RA8IGqVJJogPppo+79TsKVcjsoKvDVueNzx9kP2iSbvA8KhMHYHXRCxYqiH4jXeGoAlDw3ueVE= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1708429860; c=relaxed/simple; bh=3U2zYysRl0nrVqW7pLUu8AMBOg1xeSbxamfKdGrs2Bw=; h=Subject:To:From:Message-ID:Date:MIME-Version; b=r1FH/XWJaJI191E7xTcXCfff2xWg8c3ISoFrAM4FbxNESyNUsmvyZ5bvnXuds4IuBP4yAK7RR5OjEjY2nbPyKPPXRx5QbuwZvMleWgc+JEkDUO5Nx+YL6E+UM53rt5HH3DVS66SZ7SXsPUXih3sOgOp+dhhId95lBvtgKvD3bYU= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from mail.loongson.cn ([114.242.206.163]) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rcOeF-0006hx-Aw for gcc-patches@gcc.gnu.org; Tue, 20 Feb 2024 06:50:57 -0500 Received: from loongson.cn (unknown [10.20.4.107]) by gateway (Coremail) with SMTP id _____8DxbOkNktRliTYPAA--.29632S3; Tue, 20 Feb 2024 19:50:38 +0800 (CST) Received: from [10.20.4.107] (unknown [10.20.4.107]) by localhost.localdomain (Coremail) with SMTP id AQAAf8DxvhMNktRlRLo8AA--.35768S3; Tue, 20 Feb 2024 19:50:37 +0800 (CST) Subject: Re: LoongArch: Backport r14-4674 "LoongArch: Delete macro definition ASM_OUTPUT_ALIGN_WITH_NOP."? To: Xi Ruoyao Cc: gcc-patches@gcc.gnu.org, WANG Xuerui , Jiajie Chen , Chenghua Xu References: <9b08cb2a-a193-3da9-9e28-50740898062e@loongson.cn> <74d30af4a8d6366e2b47496c32462243d00406a9.camel@xry111.site> <92ff9d8c-f1e4-5be4-72eb-4d3569b92eae@loongson.cn> From: chenglulu Message-ID: Date: Tue, 20 Feb 2024 19:50:37 +0800 User-Agent: Mozilla/5.0 (X11; Linux loongarch64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-CM-TRANSID:AQAAf8DxvhMNktRlRLo8AA--.35768S3 X-CM-SenderInfo: xfkh0wpoxo3qxorr0wxvrqhubq/ X-Coremail-Antispam: 1Uk129KBj93XoW7tFWDAw13XFWfJFyrKw4Utrc_yoW8XF1fpF Zrta4YkFyqk3Z2kan7K34avr45trs5tFWDJw4kKrW8ZrsIkF9Fgr4Yvrs5uFy2gw4vgr1Y vr4fKw13Xry0yFXCm3ZEXasCq-sJn29KB7ZKAUJUUUUr529EdanIXcx71UUUUU7KY7ZEXa sCq-sGcSsGvfJ3Ic02F40EFcxC0VAKzVAqx4xG6I80ebIjqfuFe4nvWSU5nxnvy29KBjDU 0xBIdaVrnRJUUUBFb4IE77IF4wAFF20E14v26r1j6r4UM7CY07I20VC2zVCF04k26cxKx2 IYs7xG6rWj6s0DM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48v e4kI8wA2z4x0Y4vE2Ix0cI8IcVAFwI0_JFI_Gr1l84ACjcxK6xIIjxv20xvEc7CjxVAFwI 0_Jr0_Gr1l84ACjcxK6I8E87Iv67AKxVW8Jr0_Cr1UM28EF7xvwVC2z280aVCY1x0267AK xVW8Jr0_Cr1UM2kKe7AKxVWUXVWUAwAS0I0E0xvYzxvE52x082IY62kv0487Mc804VCY07 AIYIkI8VC2zVCFFI0UMc02F40EFcxC0VAKzVAqx4xG6I80ewAv7VC0I7IYx2IY67AKxVWU XVWUAwAv7VC2z280aVAFwI0_Jr0_Gr1lOx8S6xCaFVCjc4AY6r1j6r4UM4x0Y48IcVAKI4 8JMxk0xIA0c2IEe2xFo4CEbIxvr21l42xK82IYc2Ij64vIr41l4I8I3I0E4IkC6x0Yz7v_ Jr0_Gr1l4IxYO2xFxVAFwI0_Jw0_GFylx2IqxVAqx4xG67AKxVWUJVWUGwC20s026x8Gjc xK67AKxVWUGVWUWwC2zVAF1VAY17CE14v26r126r1DMIIYrxkI7VAKI48JMIIF0xvE2Ix0 cI8IcVAFwI0_Jr0_JF4lIxAIcVC0I7IYx2IY6xkF7I0E14v26r1j6r4UMIIF0xvE42xK8V AvwI8IcIk0rVWUJVWUCwCI42IY6I8E87Iv67AKxVWUJVW8JwCI42IY6I8E87Iv6xkF7I0E 14v26r1j6r4UYxBIdaVFxhVjvjDU0xZFpf9x07jjwZcUUUUU= Received-SPF: pass client-ip=114.242.206.163; envelope-from=chenglulu@loongson.cn; helo=mail.loongson.cn X-Spam_score_int: -51 X-Spam_score: -5.2 X-Spam_bar: ----- X-Spam_report: (-5.2 / 5.0 requ) BAYES_00=-1.9,NICE_REPLY_A=-3.297,SPF_HELO_NONE=0.001,SPF_PASS=-0.001,T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Status: No, score=-8.6 required=5.0 tests=BAYES_00,KAM_DMARC_STATUS,NICE_REPLY_A,SPF_FAIL,SPF_HELO_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: 在 2024/2/20 下午7:31, Xi Ruoyao 写道: > On Tue, 2024-02-20 at 19:25 +0800, Xi Ruoyao wrote: >> On Tue, 2024-02-20 at 10:07 +0800, chenglulu wrote: >> >>> So I think that without worrying about performance and ensuring that >>> there is no problem >>> >>> with binutils, I think we can make the following modifications: >>> >>>    -/* "nop" instruction 54525952 (andi $r0,$r0,0) is >>>    -   used for padding.  */ >>>    +/* ".align num,,4" will insert "nop"(andi $r0,$r0,0) into padding by >>>    +   default.  */ >>>     #define ASM_OUTPUT_ALIGN_WITH_NOP(STREAM, LOG) \ >>>    -  fprintf (STREAM, "\t.align\t%d,54525952,4\n", (LOG)) >>>    +  fprintf (STREAM, "\t.align\t%d,,4\n", (LOG)) >>> >>> What do you think of it? >> Unfortunately it will cause warnings with GAS 2.41 or earlier like >> >> t1.s:1: Warning: expected fill pattern missing >> t1.s:5: Warning: expected fill pattern missing >> >> And AFAIK these things may cause many test failures due to "excessive >> errors" if running the GCC test suite with these earlier GAS versions. >> Maybe we'll have to add some autoconf-based probing for the linker >> anyway? > Or just silence the warning passing "--no-warn" to the assembler but I'm > highly unsure if this is really a good idea :(. > I am not opposed to adding detection code, but I looked at this problem today and I think this change is the smallest change. I asked Meng Qinggang and he said that the warning of GAS 2.41 can be removed.