From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5745 invoked by alias); 2 May 2017 15:37:23 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 5685 invoked by uid 89); 2 May 2017 15:37:22 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_PASS autolearn=ham version=3.3.2 spammy=H*MI:sk:b283df6, Hx-languages-length:2120 X-HELO: mx1.suse.de Received: from mx2.suse.de (HELO mx1.suse.de) (195.135.220.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 02 May 2017 15:37:20 +0000 Received: from relay2.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 804ADAAF2; Tue, 2 May 2017 15:37:20 +0000 (UTC) Subject: [PATCH] Fix documentation and a ctor in gcov.c To: Nathan Sidwell , Martin Sebor , gcc-patches@gcc.gnu.org References: <4f99730aa8b94384864c11e9026bcb9036d121e7.1493371589.git.mliska@suse.cz> <00fc8b09-85b6-eae2-e439-410b76e16f92@acm.org> Cc: hubicka@ucw.cz From: =?UTF-8?Q?Martin_Li=c5=a1ka?= Message-ID: Date: Tue, 02 May 2017 15:38:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/mixed; boundary="------------CE5A73C1ECCDF947A5F454CE" X-IsSubscribed: yes X-SW-Source: 2017-05/txt/msg00121.txt.bz2 This is a multi-part message in MIME format. --------------CE5A73C1ECCDF947A5F454CE Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-length: 227 On 04/28/2017 07:23 PM, Nathan Sidwell wrote: > Write proper member initializers please. Hi. Done that, patch can bootstrap on ppc64le-redhat-linux and survives regression tests. I consider the patch as pre-approved. Martin --------------CE5A73C1ECCDF947A5F454CE Content-Type: text/x-patch; name="0001-Fix-documentation-and-a-ctor-in-gcov.c.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="0001-Fix-documentation-and-a-ctor-in-gcov.c.patch" Content-length: 1879 >From e694ed03b29882bbaaa02747acb188e16d459514 Mon Sep 17 00:00:00 2001 From: marxin Date: Tue, 2 May 2017 13:38:57 +0200 Subject: [PATCH] Fix documentation and a ctor in gcov.c gcc/ChangeLog: 2017-05-02 Martin Liska * doc/gcov.texi: Add missing preposition. * gcov.c (function_info::function_info): Properly fill up all member variables. --- gcc/doc/gcov.texi | 2 +- gcc/gcov.c | 7 ++++--- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/gcc/doc/gcov.texi b/gcc/doc/gcov.texi index c96f86df830..706aa6cf0b0 100644 --- a/gcc/doc/gcov.texi +++ b/gcc/doc/gcov.texi @@ -325,7 +325,7 @@ containing no code. Unexecuted lines are marked @samp{#####} or @samp{====}, depending on whether they are reachable by non-exceptional paths or only exceptional paths such as C++ exception handlers, respectively. Given @samp{-a} option, unexecuted blocks are -marked @samp{$$$$$} or @samp{%%%%%}, depending whether a basic block +marked @samp{$$$$$} or @samp{%%%%%}, depending on whether a basic block is reachable via non-exceptional or exceptional paths. Some lines of information at the start have @var{line_number} of zero. diff --git a/gcc/gcov.c b/gcc/gcov.c index 4e6771e79d0..a5aa4aadcac 100644 --- a/gcc/gcov.c +++ b/gcc/gcov.c @@ -435,10 +435,11 @@ static char *mangle_name (const char *, char *); static void release_structures (void); extern int main (int, char **); -function_info::function_info () +function_info::function_info (): name (NULL), demangled_name (NULL), + ident (0), lineno_checksum (0), cfg_checksum (0), has_catch (0), + blocks (), blocks_executed (0), counts (NULL), num_counts (0), + line (0), src (0), next_file_fn (NULL), next (NULL) { - /* The type is POD, so that we can use memset. */ - memset (this, 0, sizeof (*this)); } function_info::~function_info () -- 2.12.2 --------------CE5A73C1ECCDF947A5F454CE--