From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10898 invoked by alias); 12 Jun 2019 10:32:13 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 10890 invoked by uid 89); 12 Jun 2019 10:32:13 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-24.9 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,KAM_SHORT,SPF_PASS autolearn=ham version=3.3.1 spammy=2018-10, 201810 X-HELO: mx1.suse.de Received: from mx2.suse.de (HELO mx1.suse.de) (195.135.220.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 12 Jun 2019 10:32:12 +0000 Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 8E23DAF3B; Wed, 12 Jun 2019 10:32:09 +0000 (UTC) Subject: Re: [PATCH, OpenACC] Add support for gang local storage allocation in shared memory To: Jakub Jelinek , Julian Brown Cc: Bernhard Reutner-Fischer , gcc-patches@gcc.gnu.org, Chung-Lin Tang References: <524d9017-e7f0-87a2-6a62-9b23abd65ac2@codesourcery.com> <94ac317d-5e4c-7738-4b22-b59d29dc114a@codesourcery.com> <20180815174637.7f7f9666@squid.athome> <1532490C-015A-4F89-8512-FD9751C7EEA4@gmail.com> <20180816164643.01e26476@squid.athome> <20181211150811.47a032cf@squid.athome> <20190603170245.4a62a0ad@squid.athome> <20190603162300.GR19695@tucnak> <20190607150837.299df55b@squid.athome> <20190612102239.GV19695@tucnak> From: Tom de Vries Message-ID: Date: Wed, 12 Jun 2019 10:32:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190612102239.GV19695@tucnak> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2019-06/txt/msg00693.txt.bz2 On 12-06-19 12:22, Jakub Jelinek wrote: > On Fri, Jun 07, 2019 at 03:08:37PM +0100, Julian Brown wrote: >> diff --git a/gcc/omp-low.c b/gcc/omp-low.c >> index a7f35ffe416..67e1e82ec00 100644 >> --- a/gcc/omp-low.c >> +++ b/gcc/omp-low.c >> @@ -9794,6 +9882,8 @@ lower_omp_target (gimple_stmt_iterator *gsi_p, omp_context *ctx) >> >> if (offloaded) >> { >> + mark_oacc_gangprivate (&ctx->oacc_addressable_var_decls, ctx); >> + > > The above one still doesn't seem to be guarded for OpenACC constructs only. > > As for the rest of the patch, you need Tom to look over the nvptx changes. I haven't seen any nvptx changes mentioned since I ok-ed the nvptx part ( https://gcc.gnu.org/ml/gcc-patches/2018-10/msg00324.html ), so on that basis I'd say it's still ok. Thanks, - Tom