From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by sourceware.org (Postfix) with ESMTPS id 577C53858D32 for ; Tue, 14 Nov 2023 16:29:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 577C53858D32 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=oracle.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=oracle.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 577C53858D32 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=205.220.165.32 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1699979341; cv=pass; b=m7uGOVrEg1lWy1gYTImlPARo0+wExvveJpVmSALLT9gmSvL09cv0fRTcc5Y3QB4SnA87uaZZ5S7NCKlhs+B0/HtlAxgZbrgOCqemM9u5Q2yaEjpd5z/q9lT4ZCQPzE7Ys8E3DDj4QRFNb8CGb65dQjgPZPRnF5/VMYKC4pp+7I8= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1699979341; c=relaxed/simple; bh=sM6gIxn5qQjx7s8wQ0TYo7k7Ks+8UMCJmBbDC7+b42Q=; h=DKIM-Signature:DKIM-Signature:Message-ID:Date:Subject:To:From: MIME-Version; b=FOsbThnQO0QVxCT7F3ydlRVlPjbuVywYdcbSl3xdcEFgrAxVw5F1iNzvBrswgm5xn6U+USzaqBESrCpWdAIebOE9OQ8nV5iAVV1f5kIrAqxiiZtO2xAorn1YbkDrKakRs8OJqMAMloXJIgeaaWRRVjhmRnHrWU3f4dnnJ/bx62g= ARC-Authentication-Results: i=2; server2.sourceware.org Received: from pps.filterd (m0246617.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 3AEFP76S025320 for ; Tue, 14 Nov 2023 16:28:58 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=message-id : date : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2023-03-30; bh=ZwIFhg1lUtF1pb5T2VJgZRAvO72QjGhHkJs7KTleTdY=; b=H5TqtJZmVyuRiWXpaZeO9ybeqC0zU23qepNtLUSizf2C40zsg/V3+7tbIlvYksmVxrbF hqrqzyomCP61+VXfvfgouYG8W6V2/A9OhIN5LbtepcaUD03Q6TneqeHqssDTf971+xod KdZyUGFSWd6pd1MgVDCPShy83MGIv3qBAzgnRZIg6dgtshcX3oWBNY2RgLmXZxUqR0wz Mm7G6s6JYYzH9PavGgJxFTINKY5h2QZjCUGRcScpkB9qotcaALUEFJiGvg55iEMJ7MUg pMG3/uMWQVYR9alaPChYHeFEhfjYBoUhqnvwr8Apq+tG1Fon4tUX1uZMBqlCJpykyykp Ow== Received: from phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta02.appoci.oracle.com [147.154.114.232]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3ua2stp1c4-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Tue, 14 Nov 2023 16:28:57 +0000 Received: from pps.filterd (phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 3AEG3fxA008681 for ; Tue, 14 Nov 2023 16:28:57 GMT Received: from nam10-mw2-obe.outbound.protection.outlook.com (mail-mw2nam10lp2100.outbound.protection.outlook.com [104.47.55.100]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 3uaxpw9mg6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Tue, 14 Nov 2023 16:28:57 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mIKx4PasURnCf/EERHQD+3ar2MrEHTsuREzpnL5kYBDtG+pUuqP6nhISFIyC44FQMw0zwLZsI0UUMX9t12Ko9KZB82TPG1ISDfbIXgrfEu65L9WgCVKcrQHDoCrK15NzAl7I0XYa7ECqxtRszx/RwIUF2mCwH1f76751qVumJIkjcl5YnCOmO53254IQt5Z7bIci1JvNMMnP3b4wYTrV4keLw8Rt00M9+Wn6UHssLbc86SyhT53iEPeQdLiIzwCPbj24iYw28EpXjYkh6LTBpr0aMvok1hMjX8C4b8jBNYvO5Bk8gAvcs9WN7wS1trE8uT4bWz31fXgwofWcJOsmkA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZwIFhg1lUtF1pb5T2VJgZRAvO72QjGhHkJs7KTleTdY=; b=IEolDhPVMOVSRYn5qRc9kqFdnR1IbBKza2Rx5KejivSZ6VricY941grldDSR1qd7YH/EIjG0D4eAvHkpQ/gkzaDNe78lZd19GJbb5OlIrbzp9CgQpIK3/HIbUabTSCE6jBS8jwqOMjJrcrJN0+/YiG1WT/St/JsUEKV/SwNVKwNgX0v1n/dGPszoScfum3XFJwsRly9E1NuLwLbPlILzOzkNkg/Qvp9UIPtopQn55QgOKdd7X3FcbQURfmag89p9eL+e2NK+FhBv1enpDSuNOssISuW7PE9g2GoE8PUMCvgrkpr34YeSDRmWwjIAUjGHumFzCEtk0FNxDp+rcA13og== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZwIFhg1lUtF1pb5T2VJgZRAvO72QjGhHkJs7KTleTdY=; b=VKpUwNqCK0DWOBByQUXxhVnU5MhNbr1/2/JxBtQCODM9saPoznRf5klUY0tudAfb9n69uK8lr44eL1b3kfpW9YtxN2EAbXzKcR3vrt2liInjBYoNepr8Yi55VSc2ex5nHC8PJ71H0gdjR8ZsfHs2BbzDsYmvPkLcucpcMn4rJwg= Received: from MN2PR10MB3213.namprd10.prod.outlook.com (2603:10b6:208:131::33) by BLAPR10MB5106.namprd10.prod.outlook.com (2603:10b6:208:30c::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7002.17; Tue, 14 Nov 2023 16:28:54 +0000 Received: from MN2PR10MB3213.namprd10.prod.outlook.com ([fe80::d8:db85:8025:ed64]) by MN2PR10MB3213.namprd10.prod.outlook.com ([fe80::d8:db85:8025:ed64%7]) with mapi id 15.20.6977.029; Tue, 14 Nov 2023 16:28:54 +0000 Message-ID: Date: Tue, 14 Nov 2023 08:28:51 -0800 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] Fixed problem with BTF defining smaller enums. Content-Language: en-US To: Cupertino Miranda Cc: gcc-patches@gcc.gnu.org, jose.marchesi@oracle.com, elena.zannoni@oracle.com References: <20231113223739.11844-1-cupertino.miranda@oracle.com> From: David Faust In-Reply-To: <20231113223739.11844-1-cupertino.miranda@oracle.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: SJ0PR03CA0378.namprd03.prod.outlook.com (2603:10b6:a03:3a1::23) To MN2PR10MB3213.namprd10.prod.outlook.com (2603:10b6:208:131::33) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MN2PR10MB3213:EE_|BLAPR10MB5106:EE_ X-MS-Office365-Filtering-Correlation-Id: 324872f1-9973-4d39-c222-08dbe52ecb4a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: HuEh6IpSKEFVMJeUyieLTEVKKFe3o6YReCrDwTMzhQvMCh/AcEMdUvXZ38VEABmmDcozEFxFAyBxaaCRSNgL852rB0ECZteYAVDX3KedXfYMgSOAVEjcNR6YhmuAL8hv3miSFA62ohF5f8s2Afme/Yd4O6DbyCe4DH7nZDBEvNSIyDsm2Efashb5BKyQDOB3FdzL9iygX1AXGICNz3xBE4/wPKIq6pMqXds3ca9YXTGGk07X4z+rmvvUGf0XmmV/u3aE20ZocKAilNv0xDbvr/scnszgg8GlwVM9BsDFoDOU/Ej5xItYSXIMkzPkXAzZMg5UyForiCzJasrCZgwRNRPG96YPfzmWc0ZO5xXmSpqjvvGKUeElpaGNKqWesv5Mr8UOfM71D18omCfnzICmng1+1yirCSGvOuPzdZG4IEcPhYmeTofEXzpcEWK2K2frb5zKJC9nlLpRFMIJQ4M5DjqNy93Sx2V5nF56Gbs4cft725qzNKrf0EwPBIoCAoMUGd1T+Wwn/8uY4i2D3ObfXeTnAMPqyhhnInfvbY0mMcNmp+sZQIiYihhZvQevCubbKNELobZI1ARvDprpkSyb+4BwdZ96bIki7odo0ouNLlJcf65x3v1ELtaKxKnDYnHFlBrqOUUGLwvzyfCU0ciKJw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN2PR10MB3213.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(396003)(136003)(346002)(39860400002)(376002)(366004)(230922051799003)(451199024)(186009)(1800799009)(64100799003)(6506007)(6512007)(44832011)(53546011)(36756003)(2906002)(26005)(38100700002)(83380400001)(86362001)(41300700001)(31696002)(2616005)(5660300002)(107886003)(478600001)(6636002)(37006003)(316002)(66476007)(66556008)(66946007)(6486002)(31686004)(6666004)(8676002)(6862004)(4326008)(8936002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SFpGK3RwdlhLeTZKVE5xdzMxSGVTK08zSmJUNDZzcHZlb1Y4QVlvd3NOSXZz?= =?utf-8?B?bHY1UmhRRENzMzhWc25LRkY5NVB1bGxNcDlLZmN6Zzc1S0ZaRVBPaFNVMEdZ?= =?utf-8?B?WTVacWp3clpRTlZzWFRBZ3VlSi9FTS9wR3lpY2NVd2VmNS8wNU0vbi9sRnJr?= =?utf-8?B?a3BFaVoxK3VRcTY2cGdHNm96c2p5NHJscUlqak1LcXp0RmxpUUZZdzVCSkh1?= =?utf-8?B?YUljT2J4ODFzMk1RZC9tMW1aSEttMEQzSUNKdFU5clJRR013bitIY3lYRWx1?= =?utf-8?B?c01xdEszZHpYYXFLZ3VlNDNoNEtPdExiektyV0pTN283VXgrUmp1cG80RDhr?= =?utf-8?B?S1BpeHpKT0t0dGZESXEzd3ZpdGxPKzhEWVJmY0pIKy9rb1JrWVkvSkFjaDFU?= =?utf-8?B?MGF1UnIwdVFOMkt5SWpkQXJLS3VHN1J5T2l6MitUT1REcWUxU0dyVnlpb2NN?= =?utf-8?B?NVhsMFlqRVNyQW56c2prODVJbHMxMkhYRGxZc2FpOVBaWUZtQXMyblZQTktL?= =?utf-8?B?RU5MY2N0aitJUUlxS2x2ZWpiWElzNExuU2ZvM3JBUkNEZXc4WWtQVUNIOE9O?= =?utf-8?B?UEV5Nmk1Z2JPYzBoOUJTMU9pTGJxNWI0NVpUUk5VVGNKbHo5MjM3ZmxiL2k5?= =?utf-8?B?c2pUWjdnZnZML3g4TXNaUk1FN29FZkdXS2xVbWswOG0yZWgxY1MvN0NRMGNF?= =?utf-8?B?YUNrK2pIYkpvTVIyREJQOWtNS3VnZ2lhazkyUVduSXJDWG13ZDdDQ2svZ3VG?= =?utf-8?B?NlNBOG5nVnYzem11aFVIcGJqeVJIVXcwL1lqeStGV2x2Q3c3V0QxeTZQRTUv?= =?utf-8?B?akp1OFJHUDM2eHFEUXROMmtEdEN1RXZ2di9SUVNhUTFpcXVLSkJYNXNWZHg2?= =?utf-8?B?OXR0b1ZuUlBEOVhMMmhxbUJRaUFiMGRpcWdISmVLTVFMaEtWYmFyeFFwWGl2?= =?utf-8?B?YUtNMDRnMXFaRVk5M3RNMEpTZmRXMUNGN0M0T1pxUFYycXh6RkNaNUswanZQ?= =?utf-8?B?Zy9NNlM4dUpSbW02ZmNwTVZ1dEtIV0dqN2RiSllYdjVKQ2hGVkFlZnM5OHli?= =?utf-8?B?bndCOXdOWXU0MW9CcCtWbFJZRW4wa25WQStNWHp6MExxMWlQTkFxaXR6TVRM?= =?utf-8?B?S2NGTHhyOUltcERIdW96TUxqYS9xOThvakR3ckJLb2JKZjI5VENYYVB1RFVF?= =?utf-8?B?MlU2TStJSGRJUlpSaW9oRko4Zy92akVHMGQ1RGVQR2lNcDlIc1VObnA0dlBB?= =?utf-8?B?LytZS0hwMDRITSsvRUtKK0hRd1R4VlZ1Y1phL3dXNnNUeHV6V0V0ZFVuWlor?= =?utf-8?B?QS9BYTk2dEliWks4dndqRTRucnRsQnpjbkxnZFVkeHIrMnEraDNKKytrNkNV?= =?utf-8?B?cjZ2RkxIWHRmMDJzWG1SYXVKaUpkK1RlUlY1ajlTOXJmUkdLc3hIcGJTd1Zo?= =?utf-8?B?clNRcFljdFdEQ3hkRXk1TXdOekJ1aUsrVi9HQnk0QVdwcXhUd0FBd2VtUS82?= =?utf-8?B?NVY2RWxoTXBvbjhBQlZYNnZyZzZlWUVhYkplRUt5dG9SMjMrNDVGZEZlT3dX?= =?utf-8?B?T2d5OFZPUWZoanpYcDFwUHk1Wkd2K3cvbnhUUTZaVjVuN2NJWjQ3ZzRzUFI5?= =?utf-8?B?ZFVsU01COG1TMmcxakM0Q0IyWUovVzNxOVQ2M1YvbmEyZmpuM2RLZy84VE04?= =?utf-8?B?OTMxaVhVV3R4QWVnMnNpZmk4R1kyRVltNDFVcWhxdjNnaXZocE5XdzZtZEps?= =?utf-8?B?eFZpMFptc1FCN3hPY2h0ZnJYZUt3Z1hhcnE5bXJrdWRaeDZFS3FhSXhMKzBD?= =?utf-8?B?YlNnbGxEbzBpcE5vT2V2YUpXSXUwKzZPcjltVU5PWmtNSHhjUU9Sa0FHazBx?= =?utf-8?B?YWpjc2ZBeHAzUHZPUWJFVlFlMUtNZnRZbjI0Yi9na1hjUWtqeWVTUGtDV2ZR?= =?utf-8?B?cVlVSGFLbXpESHYyU2N5Zk0rMmZkdlc4TWRzNzhvbW83YU4xTlR5VWgrVGl4?= =?utf-8?B?WUFyMzVSTk1KWEFCWTZsd2ZhZjF0Vi9JWHZ4RzlHdThBNjdDeUxqZjFQTG9a?= =?utf-8?B?N3dMVE5zcStmV3VEYlkwQUR1NGhkS2hXS1AwVXVObGpXbldXdVVrSmQxd2ZU?= =?utf-8?Q?zFX+wiVI5S1PYqCu7QieJ3/b2?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: dktpPv5cKEy28n1ax4r/eE53y0zmgd8kbQEuDVRrGX3B7xAfEq74wJzGLd+qTZ3y4b8u2FLPV7sfXdOwUbMU7GnZ73lqfKtWguUF0LqnrTr6XLJc0rK7iWMoOwdlZAIDvjRqSYY8VcsERS44yXkZuyWt/NTsDNe5G6VNCJKqTjlvqtzz8z/MR/Wx+BGq2+jzYKhZF0yGJd+WmyiLLJiuEibECbbgvwt825M0igJd/IH7Il7YX5dClv6Wu243pCT1xOWqFEwq3qBSg3kVPqXewh2V2PHQaOrw6QBTg+tJB4ZiltesJAC7Efhoego73MGukS7loNcd2mFhEOmR86W+UNEJa+l88hGzDPnf0zXwfmqXxt4brgua0OuMBIYR3KzN+bhVmVUBwxoqTNivfYDo7ygljaWYvVGGVLKYiWAEMH8eLHdG16ykmafcDOy4HM1KWu2GIK/aWxNd25ysupmg0cSAfcdjTE5qQEabVDhPfOVfxFV6yD4cPKWcpzZkXlLxAaUs1qKP1IfEWW4A1qtcN3OJ67GrNgto+4traxGarO/ZBbrKGZ6ek736fPmxNpnkPx26MaCWXQBh6nXXTQ73YBbKGUfxwf7sJpFoUCJhKldoAPTO0Z2rG9NTidq2mVXKzQq+woLa4pbEsW4QDf6bWiTuM/TR5LNph6AnWupbSeODq3PQIw4KGpu7TVLjZoMPRBgoMcu1VTVqpphAo5MnnRFdtWOcegBrZdxXRZKrT3HOEBdwdEmy8b5vuPGCeTHp X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 324872f1-9973-4d39-c222-08dbe52ecb4a X-MS-Exchange-CrossTenant-AuthSource: MN2PR10MB3213.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Nov 2023 16:28:54.6766 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: egRSUwByAgMUJWr0j0kMXlvPuJB89I46UoS0BFjK/5wTQmls8Brxt8XJE56ZIe1wPaBSFZLUDRg9aEhKO9T8Zg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR10MB5106 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.987,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-11-14_16,2023-11-14_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 adultscore=0 phishscore=0 mlxscore=0 bulkscore=0 spamscore=0 suspectscore=0 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311060000 definitions=main-2311140126 X-Proofpoint-GUID: 2hzqAhzQJkZK3YNmZDum2TjZSYF4ehkY X-Proofpoint-ORIG-GUID: 2hzqAhzQJkZK3YNmZDum2TjZSYF4ehkY X-Spam-Status: No, score=-13.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Cupertino, A couple of comments inline. On 11/13/23 14:37, Cupertino Miranda wrote: > This patch fixes a BTF, which would become invalid when having > smaller then 4 byte definitions of enums. > For example, when using the __attribute__((mode(byte))) in the enum > definition. Please add a test for this case in the BTF testsuite. > > Two problems were identified: > - it would incorrectly create an entry for enum64 when the size of the > enum was different then 4. > - it would allocate less then 4 bytes for the value entry in BTF, in > case the type was smaller. > > BTF generated was validated against clang. > > gcc/ChangeLog: > * bpfout.cc (btf_calc_num_vbytes): Fixed logic for enum64. > (btf_asm_enum_const): Corrected logic for enum64 and smaller > than 4 bytes values. > --- > gcc/btfout.cc | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/gcc/btfout.cc b/gcc/btfout.cc > index e07fed302c24..d2263ec6eec3 100644 > --- a/gcc/btfout.cc > +++ b/gcc/btfout.cc > @@ -299,7 +299,7 @@ btf_calc_num_vbytes (ctf_dtdef_ref dtd) > break; > > case BTF_KIND_ENUM: > - vlen_bytes += (dtd->dtd_data.ctti_size == 0x8) > + vlen_bytes += (dtd->dtd_data.ctti_size > 4) > ? vlen * sizeof (struct btf_enum64) > : vlen * sizeof (struct btf_enum); > break; > @@ -914,13 +914,13 @@ btf_asm_enum_const (unsigned int size, ctf_dmdef_t * dmd, unsigned int idx) > { > dw2_asm_output_data (4, dmd->dmd_name_offset, "ENUM_CONST '%s' idx=%u", > dmd->dmd_name, idx); > - if (size == 4) > - dw2_asm_output_data (size, dmd->dmd_value, "bte_value"); > - else > + if (size > 4) > { > - dw2_asm_output_data (4, dmd->dmd_value & 0xffffffff, "bte_value_lo32"); > + dw2_asm_output_data (4, dmd->dmd_value & 0xfffffffe, "bte_value_lo32"); I don't understand the mask change here. Why clear the low bit of the enum value? > dw2_asm_output_data (4, (dmd->dmd_value >> 32) & 0xffffffff, "bte_value_hi32"); > } > + else > + dw2_asm_output_data (size < 4 ? 4 : size, dmd->dmd_value, "bte_value"); In the else case isn't size guaranteed <= 4? In which case, 'size < 4 ? 4 : size' always evaluates to 4. So I would suggest to just write a literal 4 to keep it simple. > } > > /* Asm'out a function parameter description following a BTF_KIND_FUNC_PROTO. */