* [PATCH] ARM: reset arm_fp16_format
@ 2021-06-01 14:05 Martin Liška
2021-06-01 15:35 ` Richard Earnshaw
2021-06-02 13:37 ` Tamar Christina
0 siblings, 2 replies; 4+ messages in thread
From: Martin Liška @ 2021-06-01 14:05 UTC (permalink / raw)
To: gcc-patches
Hello.
The patch fixes https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98636#c20 where
target option restore can be called and arm_fp16_format should be reset
to ARM_FP16_FORMAT_NONE.
It fixes the ICE in the PR.
Can please ARM folks test me the patch on a Arm machine?
Thanks,
Martin
gcc/ChangeLog:
PR target/98636
* config/arm/arm.c (arm_option_reconfigure_globals): Reset
the option if isa_bit_fp16 is not set.
---
gcc/config/arm/arm.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/gcc/config/arm/arm.c b/gcc/config/arm/arm.c
index 7b37e1b602c..4543f3c6b55 100644
--- a/gcc/config/arm/arm.c
+++ b/gcc/config/arm/arm.c
@@ -3765,6 +3765,8 @@ arm_option_reconfigure_globals (void)
error ("selected fp16 options are incompatible");
arm_fp16_format = ARM_FP16_FORMAT_IEEE;
}
+ else
+ arm_fp16_format = ARM_FP16_FORMAT_NONE;
arm_arch_cde = 0;
arm_arch_cde_coproc = 0;
--
2.31.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ARM: reset arm_fp16_format
2021-06-01 14:05 [PATCH] ARM: reset arm_fp16_format Martin Liška
@ 2021-06-01 15:35 ` Richard Earnshaw
2021-06-23 13:31 ` Martin Liška
2021-06-02 13:37 ` Tamar Christina
1 sibling, 1 reply; 4+ messages in thread
From: Richard Earnshaw @ 2021-06-01 15:35 UTC (permalink / raw)
To: Martin Liška, gcc-patches
On 01/06/2021 15:05, Martin Liška wrote:
> Hello.
>
> The patch fixes https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98636#c20
> where
> target option restore can be called and arm_fp16_format should be reset
> to ARM_FP16_FORMAT_NONE.
>
> It fixes the ICE in the PR.
>
> Can please ARM folks test me the patch on a Arm machine?
> Thanks,
> Martin
>
> gcc/ChangeLog:
>
> PR target/98636
> * config/arm/arm.c (arm_option_reconfigure_globals): Reset
> the option if isa_bit_fp16 is not set.
> ---
> gcc/config/arm/arm.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/gcc/config/arm/arm.c b/gcc/config/arm/arm.c
> index 7b37e1b602c..4543f3c6b55 100644
> --- a/gcc/config/arm/arm.c
> +++ b/gcc/config/arm/arm.c
> @@ -3765,6 +3765,8 @@ arm_option_reconfigure_globals (void)
> error ("selected fp16 options are incompatible");
> arm_fp16_format = ARM_FP16_FORMAT_IEEE;
> }
> + else
> + arm_fp16_format = ARM_FP16_FORMAT_NONE;
>
> arm_arch_cde = 0;
> arm_arch_cde_coproc = 0;
My initial reaction is 'that can't be right'.
How would -mfp16-format=alternative ever work in this case?
R.
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [PATCH] ARM: reset arm_fp16_format
2021-06-01 14:05 [PATCH] ARM: reset arm_fp16_format Martin Liška
2021-06-01 15:35 ` Richard Earnshaw
@ 2021-06-02 13:37 ` Tamar Christina
1 sibling, 0 replies; 4+ messages in thread
From: Tamar Christina @ 2021-06-02 13:37 UTC (permalink / raw)
To: Martin Liška, gcc-patches
Cc: Christophe Lyon, Kyrylo Tkachov, Richard Earnshaw, Ramana Radhakrishnan
Hi Martin,
Testsuite isn't very happy with it:
Before:
# of expected passes 149743
# of unexpected failures 294
# of unexpected successes 2
# of expected failures 947
# of unresolved testcases 56
# of unsupported tests 8248
After:
# of expected passes 148907
# of unexpected failures 380
# of unexpected successes 2
# of expected failures 947
# of unresolved testcases 267
# of unsupported tests 8466
Regards,
Tamar
> -----Original Message-----
> From: Martin Liška <mliska@suse.cz>
> Sent: Tuesday, June 1, 2021 3:06 PM
> To: gcc-patches@gcc.gnu.org
> Cc: Christophe Lyon <christophe.lyon@linaro.org>; Tamar Christina
> <Tamar.Christina@arm.com>; Kyrylo Tkachov <Kyrylo.Tkachov@arm.com>
> Subject: [PATCH] ARM: reset arm_fp16_format
>
> Hello.
>
> The patch fixes https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98636#c20
> where target option restore can be called and arm_fp16_format should be
> reset to ARM_FP16_FORMAT_NONE.
>
> It fixes the ICE in the PR.
>
> Can please ARM folks test me the patch on a Arm machine?
> Thanks,
> Martin
>
> gcc/ChangeLog:
>
> PR target/98636
> * config/arm/arm.c (arm_option_reconfigure_globals): Reset
> the option if isa_bit_fp16 is not set.
> ---
> gcc/config/arm/arm.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/gcc/config/arm/arm.c b/gcc/config/arm/arm.c index
> 7b37e1b602c..4543f3c6b55 100644
> --- a/gcc/config/arm/arm.c
> +++ b/gcc/config/arm/arm.c
> @@ -3765,6 +3765,8 @@ arm_option_reconfigure_globals (void)
> error ("selected fp16 options are incompatible");
> arm_fp16_format = ARM_FP16_FORMAT_IEEE;
> }
> + else
> + arm_fp16_format = ARM_FP16_FORMAT_NONE;
>
> arm_arch_cde = 0;
> arm_arch_cde_coproc = 0;
> --
> 2.31.1
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-06-23 13:31 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-01 14:05 [PATCH] ARM: reset arm_fp16_format Martin Liška
2021-06-01 15:35 ` Richard Earnshaw
2021-06-23 13:31 ` Martin Liška
2021-06-02 13:37 ` Tamar Christina
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).