From: Jeff Law <law@redhat.com>
To: Pat Haugen <pthaugen@linux.ibm.com>,
Jiufu Guo <guojiufu@linux.ibm.com>,
gcc-patches@gcc.gnu.org
Cc: wschmidt@linux.ibm.com, segher@kernel.crashing.org,
pthaugen@us.ibm.com, hubicka@ucw.cz
Subject: Re: [PATCH] correct COUNT and PROB for unrolled loop
Date: Mon, 03 Feb 2020 16:20:00 -0000 [thread overview]
Message-ID: <f89f0a400162aaa855678c57cfe39af136b75f18.camel@redhat.com> (raw)
In-Reply-To: <e9c03138-944f-8ec2-c5f5-0d1a26659803@linux.ibm.com>
On Mon, 2020-02-03 at 10:04 -0600, Pat Haugen wrote:
> On 2/3/20 2:17 AM, Jiufu Guo wrote:
> > +/* { dg-final { scan-rtl-dump-times "REG_BR_PROB 937042044" 1 "loop2_unroll"} } */
>
> Sorry I didn't catch this addition to the original testcase earlier, but I wonder how stable this test is going to be. If there are future changes to default count/probability, or changes in their representation, this may fail and need to be updated. The fact that the loop is still getting aligned is the main concern.
Unless you're really interested in those probabilities, I'd suggest not
testing for them. If you really need to test for them, then I'd
suggest testing for them being "close" rather than a specific value for
REG_BR_PROB.
jeff
next prev parent reply other threads:[~2020-02-03 16:20 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-03 8:17 Jiufu Guo
2020-02-03 16:04 ` Pat Haugen
2020-02-03 16:20 ` Jeff Law [this message]
2020-02-03 16:23 ` Jan Hubicka
2020-02-11 2:29 ` Jiufu Guo
2020-02-17 6:23 ` [PATCH V2] " Jiufu Guo
2020-02-28 7:56 ` Jiufu Guo
2020-03-19 2:21 ` Jiufu Guo
2020-05-19 6:15 ` Jiufu Guo
2020-06-03 5:22 ` [PATCH V2] PING^ " Jiufu Guo
2020-06-18 1:22 ` [PATCH V2] PING^2 " Jiufu Guo
2020-07-02 2:35 ` Jiufu Guo
2020-07-09 11:55 ` Martin Liška
2020-07-10 2:14 ` Jiufu Guo
2020-07-10 7:37 ` Martin Liška
2020-07-10 13:09 ` Jiufu Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f89f0a400162aaa855678c57cfe39af136b75f18.camel@redhat.com \
--to=law@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=guojiufu@linux.ibm.com \
--cc=hubicka@ucw.cz \
--cc=pthaugen@linux.ibm.com \
--cc=pthaugen@us.ibm.com \
--cc=segher@kernel.crashing.org \
--cc=wschmidt@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).