From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 70445 invoked by alias); 19 Jun 2017 10:44:38 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 66788 invoked by uid 89); 19 Jun 2017 10:44:30 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 spammy=multitool, HTo:U*rguenther, Best, sum X-HELO: foss.arm.com Received: from foss.arm.com (HELO foss.arm.com) (217.140.101.70) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 19 Jun 2017 10:44:29 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id F2D0380D; Mon, 19 Jun 2017 03:44:31 -0700 (PDT) Received: from [10.2.206.52] (usa-sjc-imap-foss1.foss.arm.com [10.72.51.249]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 4D3EC3F557; Mon, 19 Jun 2017 03:44:31 -0700 (PDT) Subject: Re: [PATCH, contrib] Support multi-tool sum files in dg-cmp-results.sh To: Richard Biener , Jakub Jelinek , "gcc-patches@gcc.gnu.org" References: <4b5196b2-d2eb-b6b9-1b9e-79402d466b99@foss.arm.com> <9ef88587-ec17-5c35-14cc-1ed56136bc98@foss.arm.com> From: Thomas Preudhomme Message-ID: Date: Mon, 19 Jun 2017 10:44:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <9ef88587-ec17-5c35-14cc-1ed56136bc98@foss.arm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2017-06/txt/msg01290.txt.bz2 Wrong copy paste between the patch I tested and the patch I sent. The first and second command of the sed should be replaced, not the second and third as in the patch I sent. For more safety I'll rerun the tests. Best regards, Thomas On 15/06/17 17:15, Thomas Preudhomme wrote: > Forgetting the patch: check! > Sending it later as a reply to the wrong message: check! > > Hopefully I won't check a second time any of those. > > Best regards, > > Thomas > > On 14/06/17 13:30, Thomas Preudhomme wrote: >> Hi, >> >> dg-cmp-results.sh contrib script is written to work with sum file for >> a single tool only. It throws away the header including the first === >> line and everything starting from the following ===, assuming it is the >> test result. This does not work well for sum files with results for >> multiple tools. >> >> This patch changes the logic to instead keep everything between "Running >> target" line and the beginning of Summary line. Other existing filter >> mechanism will ensure only FAIL, PASS, etc. lines are kept after that. >> >> ChangeLog entry is as follow: >> >> *** contrib/ChangeLog *** >> >> 2017-06-14 Thomas Preud'homme >> >> * dg-cmp-results.sh: Keep test result lines rather than throwing >> header and summary to support sum files with multiple tools. >> >> Tested successfully on sum file with single tool with similar results >> and on sum file with multiple tools now showing a regression with patch >> proposed in https://gcc.gnu.org/ml/gcc-patches/2017-06/msg00875.html >> >> Is this ok for trunk? >> >> Best regards, >> >> Thomas