From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mo4-p00-ob.smtp.rzone.de (mo4-p00-ob.smtp.rzone.de [85.215.255.21]) by sourceware.org (Postfix) with ESMTPS id 99EA83858C29 for ; Sun, 7 Jan 2024 17:17:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 99EA83858C29 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=gjlay.de Authentication-Results: sourceware.org; spf=none smtp.mailfrom=gjlay.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 99EA83858C29 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=85.215.255.21 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1704647874; cv=pass; b=WirWK/sstZ/ua4wLSm0TPVQ/ZVECAxnMpmZuJSJ66RwJ0X68iG1sUjt19c400fi5T72QX85SctUvR62WFVH4m9exmx4p34tULhwo8GDssH2GxCkx1d+/XGW0efEpu9B+MKCETKpDIW1CyABHBeetl4RelezyUm66dR9Xo8u0kiU= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1704647874; c=relaxed/simple; bh=wpYdMZJvIZ6GDpV+n/9XKh+1LtCWm4KjD8/BSadTGy4=; h=DKIM-Signature:DKIM-Signature:Message-ID:Date:MIME-Version: Subject:To:From; b=s5g4IoFSLZJSwl5weYMG+1AONsul8YGvMVGLAMdA2EDcg3qX1UnM7muBOhPqgCPwcUFsuyBL5zzF1xfxQqy3TQz8XF9H8zNLUoxHT9MT7BjXYFvFb98gjF/znNrLv1YMZNMG7CJLgMbbmfJaUKG4r0ubpqJb5b0rkt1gh/jIFrg= ARC-Authentication-Results: i=2; server2.sourceware.org ARC-Seal: i=1; a=rsa-sha256; t=1704647871; cv=none; d=strato.com; s=strato-dkim-0002; b=sqM4O0O8h/I6amU9Fo4a7ZStmIjOt+WwQMVwNZaJb2MARn9BS4aDf2ozjerLTmaKnz QgZqoZmCvvFpTnyieFoW5nIUzs/Z5nrtkn6WxlDZYokm/ozfpGWy/qOJv41yTMHnRufj EGLl5KgI9OR+4/Rjwn5lX6d3HXqW19fSvaS34iGtEXAoHjHbxOEXjCtPDe2w7gIiSfLi nZcxWJ/Xr9kNpyH/eCzrDxXXq/Y1dzoiEPFHiHIB8QrzWXrC8n91UirrY/omCk0Wk/gG s6qIQ2MmmCRkFA60L7ZgJdkpIs85iMln69ESVAMsBHhf79f+E92Xh275nhpQczQuzhiT LBcg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; t=1704647871; s=strato-dkim-0002; d=strato.com; h=In-Reply-To:From:References:To:Subject:Date:Message-ID:Cc:Date:From: Subject:Sender; bh=SbPU+C/b0psFjgGR4xqR8xg5Nq11NMnKPzBW5sVxUDo=; b=hw7eQQItOnn0EF8NkUu1/6kDIkpUZjWkktMIZPBcrOQNMsWpANSPR4phqp+PmLmrAP IWaj9tuHm2l43O6XdWGMcXhkK7bMTDil/+UjEeAL1emWT5I6vwiUHZm6cZWQgrp2B6xD Jj0/cqliaprTD1tun6lsOKo826rDiwXUSfmkKzxPw3P44Dr1KTnm7fPdtfaVWsR8UAo9 hHUY+n4Ba/DeFfzBuvC6dvsB+bU7pvC/FokAbMSZXeKzKn6ZhG+CbxzEjzkml9XnIyFt Ayyp0EEQhnFkU29axzVTO4DTtmc8YaQb0ifkl4kjFHLM/fMZnaGOHqQ4JqOKsvclrm/u W68A== ARC-Authentication-Results: i=1; strato.com; arc=none; dkim=none X-RZG-CLASS-ID: mo00 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1704647871; s=strato-dkim-0002; d=gjlay.de; h=In-Reply-To:From:References:To:Subject:Date:Message-ID:Cc:Date:From: Subject:Sender; bh=SbPU+C/b0psFjgGR4xqR8xg5Nq11NMnKPzBW5sVxUDo=; b=mDmkYpJaz/nQx0IKKpHAQaxC5Lz7XVQZ13p38JjE155EDJVNh/Ij33j6u+ODhikdpj eYu5TF0BjsjYv6jCOiockzkUfqdL7aFjaGCtXjxK48LG/ynxHGh8vVOtuO7mflo/LNA7 DzKDLoLM8hr4OOhnhBGkfG9jwUZzkGl4Pvq9SoRO2fo+5EZfr390blewE0DQufgcDMKE /0GdrhxNz2SPajCBom4XyslsdRHTzdSxMdFm9mpaC0vwvqaAkaesiKiA6mEd64cv3bJM edW3oDNLGiETLrTN1Ei3Y+XN7ybHGeuqlmR18eqgaCWbFH8A48NgmWLBG+NjrmJ2GNZz Oj4Q== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; t=1704647871; s=strato-dkim-0003; d=gjlay.de; h=In-Reply-To:From:References:To:Subject:Date:Message-ID:Cc:Date:From: Subject:Sender; bh=SbPU+C/b0psFjgGR4xqR8xg5Nq11NMnKPzBW5sVxUDo=; b=9U3w0GyiZJ05YsPZ4bKQndHpPNmJj+yL4TDFH5KLN/31QOFjxpP00h83egzLYrBF71 kaENx9TGiSCCy8QfWNAA== X-RZG-AUTH: ":LXoWVUeid/7A29J/hMvvT3koxZnKT7Qq0xotTetVnKkSjsSjq3WhKPVxx3mY" Received: from [192.168.2.102] by smtp.strato.de (RZmta 49.10.2 DYNA|AUTH) with ESMTPSA id 641e88007HHoJv0 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits)) (Client did not present a certificate); Sun, 7 Jan 2024 18:17:50 +0100 (CET) Message-ID: Date: Sun, 7 Jan 2024 18:17:50 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [patch, testsuite, applied] PR52641 Fix more fallout from sloppy tests. Content-Language: en-US To: Jeff Law , gcc-patches@gcc.gnu.org References: <71920087-4b6c-48f4-8b96-5633671fd023@gmail.com> From: Georg-Johann Lay In-Reply-To: <71920087-4b6c-48f4-8b96-5633671fd023@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-3.2 required=5.0 tests=BAYES_00,BODY_8BITS,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Am 07.01.24 um 17:45 schrieb Jeff Law: > > > On 1/7/24 08:53, Georg-Johann Lay wrote: >> Made some tests more generic so they can pass on more targets. >> >> Johann >> >> -- >> >> testsuite/52641: Fix fallout from sloppy tests. >> >> gcc/testsuite/ >>      PR testsuite/52641 >>      * gcc.dg/torture/pr110838.c: Use proper shift offset to get MSB >> or int. >>      * gcc.dg/torture/pr112282.c: Use at least 32 bits for :20 >> bit-fields. >>      * gcc.dg/tree-ssa/bitcmp-5.c: Use integral type with 32 bits or >> more. >>      * gcc.dg/tree-ssa/bitcmp-6.c: Same. >>      * gcc.dg/tree-ssa/cltz-complement-max.c: Same. >>      * gcc.dg/tree-ssa/cltz-max.c: Same. >>      * gcc.dg/tree-ssa/if-to-switch-8.c: Use literals that fit int. >>      * gcc.dg/tree-ssa/if-to-switch-9.c [avr]: Set >> case-values-threshold=3. >>      * gcc.dg/tree-ssa/negneg-3.c: Discriminate [not] large_double. >>      * gcc.dg/tree-ssa/phi-opt-25b.c: Use types of correct widths for >>      __builtin_bswapN. >>      * gcc.dg/tree-ssa/pr55177-1.c: Same. >>      * gcc.dg/tree-ssa/popcount-max.c: Use int32_t where required. >>      * gcc.dg/tree-ssa/pr111583-1.c: Use intptr_t as needed. >>      * gcc.dg/tree-ssa/pr111583-2.c: Same. > Are you checking this on other targets?  My tester just started > complaining about these (ft30-elf, fr30-elf), more expected as today's > run progresses) > > >> Tests that now fail, but worked before (2 tests): >> >> ft32-sim: gcc: gcc.dg/tree-ssa/phi-opt-25b.c (test for excess errors) >> ft32-sim: gcc: gcc.dg/tree-ssa/phi-opt-25b.c (test for excess errors) > > Jeff Hi Jeff, thanks for fixing the typo. It slipped through because "int short" works in that place. Usually when going after PR52641 I used dg-require, dg-skip or dg-xfail for tests that fail on 16-bit int etc. The take above was more ambitious in that it tried to make some tests work without breaking other platforms of course. It's not always easy to get the intent of a test case and how to make it more generic though. Johann