From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 126628 invoked by alias); 2 Jul 2019 14:55:21 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 126617 invoked by uid 89); 2 Jul 2019 14:55:21 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=AWL,BAYES_00,HTML_MESSAGE,KAM_SHORT autolearn=ham version=3.3.1 spammy=HX-Languages-Length:3790, H*c:alternative X-HELO: foss.arm.com Received: from foss.arm.com (HELO foss.arm.com) (217.140.110.172) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 02 Jul 2019 14:55:19 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id CE02928; Tue, 2 Jul 2019 07:55:17 -0700 (PDT) Received: from [10.2.206.47] (e120808-lin.cambridge.arm.com [10.2.206.47]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 1FDDB3F703; Tue, 2 Jul 2019 07:55:17 -0700 (PDT) Subject: Re: [PATCH][gcc] libgccjit: check result_type in gcc_jit_context_new_binary_op To: David Malcolm , Andrea Corallo Cc: "gcc-patches@gcc.gnu.org" , "jit@gcc.gnu.org" , nd References: <1560897082.3885.10.camel@redhat.com> <1561391539.3885.22.camel@redhat.com> <1561409068.3885.28.camel@redhat.com> <1561555176.13494.13.camel@redhat.com> <1562078770.2530.36.camel@redhat.com> From: Kyrill Tkachov Message-ID: Date: Tue, 02 Jul 2019 14:55:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.1 MIME-Version: 1.0 In-Reply-To: <1562078770.2530.36.camel@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-SW-Source: 2019-07/txt/msg00162.txt.bz2 Hi David, Andrea, On 7/2/19 3:46 PM, David Malcolm wrote: > On Wed, 2019-06-26 at 15:05 +0000, Andrea Corallo wrote: > > David Malcolm writes: > > > > > On Tue, 2019-06-25 at 08:11 +0000, Andrea Corallo wrote: > > > > Hi, > > > > third version for this patch with the simplified test. > > > > > > > > make check-jit pass clean > > > > > > > > Bests > > > >   Andrea > > > > > > > > 2019-06-09  Andrea Corallo andrea.corallo@arm.com > > > > > > > > * libgccjit.c (gcc_jit_context_new_binary_op): Check result_type > > > > to > > > > be a > > > > numeric type. > > > > > > > > > > > > 2019-06-20  Andrea Corallo andrea.corallo@arm.com > > > > > > > > * jit.dg/test-error-gcc_jit_context_new_binary_op-bad-res-type.c: > > > > New testcase. > > > > > > Thanks for the updated patch. > > > > > > This is good for trunk. > > > > > > (Copying and pasting from my other review): are you working on > > > getting > > > SVN commit access, or do you want me to commit your two patches on > > > your > > > behalf? > > > > > > Thanks > > > Dave > > > > Hi David, > > I can work on to get the SVN commit access. > > As a maintainer has to sponsor it would you mind being the one? > > https://www.gnu.org/software/gcc/svnwrite.html says: > "a well-established GCC maintainer (including reviewers) can approve > for write access any person with GNU copyright assignment papers in > place and known to submit good patches." > > Thanks for your patches so far. > > I approve of you getting "Write after approval" access to GCC svn, > provided the copyright assignment paperwork is in place (which I'm > assuming is, based on your @arm.com email address). > > I'm not quite sure what the next steps are. > It means Andrea needs to fill out the form at https://sourceware.org/cgi-bin/pdw/ps_form.cgi with his SSH key and putting your address as an approver. You'll then get a request to approve it. Cheers, Kyrill > Dave