From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x631.google.com (mail-pl1-x631.google.com [IPv6:2607:f8b0:4864:20::631]) by sourceware.org (Postfix) with ESMTPS id AD2C63858D20 for ; Tue, 8 Aug 2023 22:45:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org AD2C63858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pl1-x631.google.com with SMTP id d9443c01a7336-1bbf3da0ea9so41320045ad.2 for ; Tue, 08 Aug 2023 15:45:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1691534719; x=1692139519; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=fBSLUfa7neCEWgY6NPxCHk4EioKLGo5BJ0YowgUkiJc=; b=f48afAHeJ4+qC8pVtDBcAwprly8AHF75NeGkFHzjc+Th3zvnWAe/rAFe5bYjtCZ+oh V56NatjPm9HnC3EFynp1P0w+QTEMMfQaA7FHAX6+Jf3H0EW4fBhWosLtgEXkuEwCU0FW tppB1UDDwWaWggj1gyOSWO+CqDsZyGbZ0Ip85M889OBLBwkYYr+8JSEmVbPAm3Ma3pxO GXfXSHP20kKZGPlnsO+M61uBH1DaD30bVyt9GI0GltxHRRv+9scX8d/2LKSXx+8ddU25 K5Rz/txibIia+ow2XZ5EXj3NVMVYvnuBoE1m7zwsw3aChMVNaPX2TwTA/nvoHMwMOxtD xrRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691534719; x=1692139519; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=fBSLUfa7neCEWgY6NPxCHk4EioKLGo5BJ0YowgUkiJc=; b=B8jrUKvT61ueblwBymVzmPvFvyeHqHhBoTykYfnqHIAGcRza4v9nDgehnjFSDRufym vHM1vAmP+Xqagy3M1CvJ9W+GWQJyHHjbJIyTZdr+dheNSHVFZg5vQvbCWavv5ES6Elte 0fLtkIv3aG76fZzqyAy2Ba4Kg0RoKLSS+ou+gW3i3b+PCyXbiK8y5it2pQ8dz9ecfLF3 uOX7gp7uyOZ9ga/00MNdybvhVvEaYuaRyNt7imWE3YRYSzI4lWZwGv01njpq4JW1HSFf Ji9+NzwD2Eo1eCgOgb9BrhPSaruCHdHWnCmuuAZtddX6dNq4IzvmBclMROCTc9MvU0qc MXlA== X-Gm-Message-State: AOJu0Yw3nwsfodZHk/9sSI7pKIGsVC79u2aqNL979tf/t6Y83DlNOa4T 3tFTKpDQwz4l9ay8DlJRmottogFUJrM= X-Google-Smtp-Source: AGHT+IFF74yx0PnpTJ5IXiLuCVPh0UqaaYR5dgUKMb4OS80vieRmfHwodZ1wOmPxdUUJ6VEcVlGppQ== X-Received: by 2002:a17:902:f684:b0:1b6:bced:1dc2 with SMTP id l4-20020a170902f68400b001b6bced1dc2mr1076411plg.0.1691534719447; Tue, 08 Aug 2023 15:45:19 -0700 (PDT) Received: from [172.31.0.109] ([136.36.130.248]) by smtp.gmail.com with ESMTPSA id c13-20020a170902d48d00b001b9c5e07bc3sm9472262plg.238.2023.08.08.15.45.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 08 Aug 2023 15:45:18 -0700 (PDT) Message-ID: Date: Tue, 8 Aug 2023 16:45:17 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [committed][RISC-V] Fix 20010221-1.c with zicond Content-Language: en-US To: "Maciej W. Rozycki" Cc: Xiao Zeng , gcc-patches , gaofei References: <003943c5-c68c-0d15-8f2f-b890cd7b17e1@gmail.com> <202308041729232721253@eswincomputing.com> <37f727f2-73ea-d9ad-af62-7cc87cc2f408@gmail.com> From: Jeff Law In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 8/8/23 15:52, Maciej W. Rozycki wrote: > On Fri, 4 Aug 2023, Jeff Law via Gcc-patches wrote: > >> It's also something I kept meaning to resolve and your submission just gave me >> the proper motivation to move zicond forward. The target specific bits you >> did lined up perfectly with the community feedback on the original VRULL >> implementation as well as the direction Ventana had taken on our internal >> tree. > > I wonder however why do we need so much more code, including the middle > end too, to support this ISA extension than we do for the very same set of > MIPSr6 instructions under ISA_HAS_SEL, hmm... Because it doesn't handle as many cases as we're handling in the RISC-V port. I'd bet if you take Xiao's testcases and run them on a mips cross many, if not most, won't optimize down into the mips equivalents. One such example would be (set (target) (if_then_else (eq (reg A) (const_int 0)) (reg A) (reg B))) This is just one example obviously, but there are others. jeff