From: Andrew Stubbs <ams@codesourcery.com>
To: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Subject: [OG12 commit] amdgcn: disallow USM on gfx908
Date: Mon, 24 Oct 2022 17:38:23 +0100 [thread overview]
Message-ID: <f9795e65-9425-9216-0556-a82266b7c336@codesourcery.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 562 bytes --]
I've committed this patch to the devel/omp/gcc-12 branch. I will have to
fold it into my previous OpenMP memory management patch series when I
repost it.
The GFX908 (MI100) devices only partially support the Unified Shared
Memory model that we have, and only then with additional kernel boot
parameters. Without that there are unexplained memory access faults at
runtime, and it's generally not a good user experience.
For this reason we have decided not to support USM on gfx908 in the
toolchain. The gfx90a (MI200) devices are still supported.
Andrew
[-- Attachment #2: 221024-disallow-gfx908-usm.patch --]
[-- Type: text/plain, Size: 636 bytes --]
amdgcn: disallow USM on gfx908
It does work, but not well and only with the amdgpu.noreply=0 kernel boot
option.
gcc/ChangeLog:
* config/gcn/gcn.cc (gcn_init_cumulative_args): Disallow gfx908.
diff --git a/gcc/config/gcn/gcn.cc b/gcc/config/gcn/gcn.cc
index 9c2fd4c5b8a..720c0a08a13 100644
--- a/gcc/config/gcn/gcn.cc
+++ b/gcc/config/gcn/gcn.cc
@@ -2905,6 +2905,7 @@ gcn_init_cumulative_args (CUMULATIVE_ARGS *cum /* Argument info to init */ ,
case PROCESSOR_FIJI:
case PROCESSOR_VEGA10:
case PROCESSOR_VEGA20:
+ case PROCESSOR_GFX908:
error ("GPU architecture does not support Unified Shared Memory");
default:
;
reply other threads:[~2022-10-24 16:38 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f9795e65-9425-9216-0556-a82266b7c336@codesourcery.com \
--to=ams@codesourcery.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).