Re: [PATCH] c++: Allow module name to be a single letter on Windows

[Nathan Sidwell <nathan@acm.org>]

On 11/8/22 05:18, Torbjorn SVENSSON wrote:
> Hi Nathan,
> 
> On 2022-11-08 00:03, Nathan Sidwell wrote:

>>
>> Yes, something like the above, but I think you're missing "/bob' in the 
>> DOS_BASED case?  shouldn't that also be a pathname?
>>
>> if (IS_DIR_SEPARATOR (ptr[ptr[0] == '.']) // ./FOO or /FOO
>> #if HAVE_DOS_BASED_FILE_SYSTEM
>>      // DOS-FS IS_ABSOLUTE_PATH thinks 'A:B' is absolute, but we need to consider
>>      // that as a module:partition.
>>      || (HAS_DRIVE_SPEC (ptr) && IS_DIR_SEPARATOR (ptr[2])) // A:/FOO
>> #endif
>>      || false)
>>     return ....
>>
>> Does (something like) that work?
> 
> I tested it and your solution appears to work.
> Are you okay with me pushing that solution or do you want me to send a v2 with 
> it first?

I think it needs a better introductory comment than the one I slapped in there. 
More explanation of the drive vs partition distinction.  Something along the 
lines of 'things that clearly start as pathnames are header-names, everything 
else is treated as a (possibly malformed) named module.

Feel free to just go with it, or iterate here

nathan

-- 
Nathan Sidwell