From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-x42f.google.com (mail-pf1-x42f.google.com [IPv6:2607:f8b0:4864:20::42f]) by sourceware.org (Postfix) with ESMTPS id 0445F3858D28 for ; Wed, 24 May 2023 22:13:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0445F3858D28 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=rivosinc.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=rivosinc.com Received: by mail-pf1-x42f.google.com with SMTP id d2e1a72fcca58-64d1e96c082so1130030b3a.1 for ; Wed, 24 May 2023 15:13:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20221208.gappssmtp.com; s=20221208; t=1684966401; x=1687558401; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=phObXvtDDfd9WPHOO61kNaWjQOPVf+l3D9GSJTPp3aQ=; b=M2tF/BSHz3XGZs1LmcjCDyJehuw+WsMVd11V+ygO3P/rkzBjDPJgCaKDu6XzJ2rvqs KyeahSbsL0/wICsCKF6SPK5ox3OsxAOesLh4cKAxJy/OcaX6aa7wbjxw/fz6duXcqf9T /U95AM3U+D4R6aZLMMYKlyuoRLAXc0OnPiSy1NodV0tBtgemDQ6hpjtgaY7ucV9Q8BS1 XVJWdTidHisosUaAFUjF79JYunzVqtAhBoPRs+zJGSWhNr3zmHHultFWN5jKel4KcYm/ zJx0Qtt4AQjMc/oZLZr9NPtdp5c/8pN/wPri48rrKIky8Tl3iWRbDlPOJsxjKGDO+MYW BVGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684966401; x=1687558401; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=phObXvtDDfd9WPHOO61kNaWjQOPVf+l3D9GSJTPp3aQ=; b=cZ5m/MhPBPS3QGN5/1U4997xQQ3VtpJL7KXZXRWUTjHi9QXUnL/4DZHbJYkdb4EBAv u018iYKr2nY72TLVFrnpFaCoW7LEAZ/rSgT76ptjYzjH/k/25lt00b4ie9reCdnsDjRv aTGdhoZEEjHJfBPeImeRwQU/XWLXZD8vkw2/p8P2yjkA9ZDkZ6j83JRGjmdfK7xfUm63 KorcULuvDL1WNu3X/W24/6wMCf6exSO4qupirVd43UuC9paJwUlCS6T1u85Bo4aOIvDv UPIhcmpY3UiqBbD0L1T6VfpIavRtBS4WAVLTvooAQe6KFlB2GqpwlxuCL4V84Tv6RjFf P+TQ== X-Gm-Message-State: AC+VfDxL0aJeQdTAVbHs5Me/aupEYyEW3kxAQkJMrYDdFjMA39Iu99Au VvbQ4HBqWDRvhFSb4LYgUJ59fQ== X-Google-Smtp-Source: ACHHUZ5sQYGCmYbpxwd4JYs13DOV8uWPhY+DgFmeq63bmtZsp+kIGSwmF0vkwRD5XBKak+Mw5fTsJw== X-Received: by 2002:a17:903:11cf:b0:1ae:10bc:4ae8 with SMTP id q15-20020a17090311cf00b001ae10bc4ae8mr21848059plh.26.1684966401454; Wed, 24 May 2023 15:13:21 -0700 (PDT) Received: from [192.168.50.116] ([71.202.114.183]) by smtp.gmail.com with ESMTPSA id bj6-20020a170902850600b001a183ade911sm9225936plb.56.2023.05.24.15.13.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 24 May 2023 15:13:21 -0700 (PDT) Message-ID: Date: Wed, 24 May 2023 15:13:19 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH] RISC-V: Add missing torture-init and torture-finish for rvv.exp Content-Language: en-US To: Thomas Schwinge , Kito Cheng Cc: gcc-patches@gcc.gnu.org, kito.cheng@gmail.com, patrick@rivosinc.com, jlaw@ventanamicro.com, "Maciej W . Rozycki" References: <20230522064138.74056-1-kito.cheng@sifive.com> <87jzwxsc3b.fsf@dem-tschwing-1.ger.mentorg.com> From: Vineet Gupta In-Reply-To: <87jzwxsc3b.fsf@dem-tschwing-1.ger.mentorg.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-8.7 required=5.0 tests=BAYES_00,BODY_8BITS,DKIM_SIGNED,DKIM_VALID,GIT_PATCH_0,KAM_SHORT,LIKELY_SPAM_BODY,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 5/24/23 13:34, Thomas Schwinge wrote: > Yeah, at this point I'm not sure whether my recent changes really are > related/relevant here. > >> Apparently in addition to Kito's patch below, If I comment out the >> additional torture options, failures go down drastically. > Meaning that *all* those ERRORs disappear? No but they reduced significantly. Anyhow I think the issue should be simple enough for someone familiar with how the tcl stuff works... > >> diff --git a/gcc/testsuite/gcc.target/riscv/riscv.exp >> b/gcc/testsuite/gcc.target/riscv/riscv.exp >> >> -lappend ADDITIONAL_TORTURE_OPTIONS {-Og -g} {-Oz} >> +#lappend ADDITIONAL_TORTURE_OPTIONS {-Og -g} {-Oz} >> >> @Thomas, do you have some thoughts on how to fix riscv.exp properly in >> light of recent changes to exp files. > I'm trying to understand this, but so far don't. Can I please see a > complete 'gcc.log' file where the ERRORs are visible? So we are at bleeding edge gcc from today      2023-05-24 ec2e86274427 Fortran: reject bad DIM argument of SIZE intrinsic in simplification [PR104350] With an additional fix from Kito along the lines of.. diff --git a/gcc/testsuite/gcc.target/riscv/rvv/rvv.exp b/gcc/testsuite/gcc.target/riscv/rvv/rvv.exp  dg-init +torture-init  # All done. +torture-finish  dg-finish I'm pasting a snippet of gcc.log. Issue is indeed triggered by rvv.exp which needs some love. PASS: gcc.target/riscv/zmmul-2.c   -O2 -flto -fuse-linker-plugin -fno-fat-lto-objects  (test for excess errors) PASS: gcc.target/riscv/zmmul-2.c   -O2 -flto -fuse-linker-plugin -fno-fat-lto-objects   scan-assembler-times mul\t 1 PASS: gcc.target/riscv/zmmul-2.c   -O2 -flto -fuse-linker-plugin -fno-fat-lto-objects   scan-assembler-not div\t PASS: gcc.target/riscv/zmmul-2.c   -O2 -flto -fuse-linker-plugin -fno-fat-lto-objects   scan-assembler-not rem\t testcase /scratch/vineetg/gnu/toolchain-upstream/gcc/gcc/testsuite/gcc.target/riscv/riscv.exp completed in 60 seconds Running /scratch/vineetg/gnu/toolchain-upstream/gcc/gcc/testsuite/gcc.target/riscv/rvv/rvv.exp ... ERROR: tcl error sourcing /scratch/vineetg/gnu/toolchain-upstream/gcc/gcc/testsuite/gcc.target/riscv/rvv/rvv.exp. ERROR: tcl error code NONE ERROR: torture-init: torture_without_loops is not empty as expected     while executing "error "torture-init: torture_without_loops is not empty as expected""     invoked from within "if [info exists torture_without_loops] {     error "torture-init: torture_without_loops is not empty as expected"     }"     (procedure "torture-init" line 4)     invoked from within "torture-init"     (file "/scratch/vineetg/gnu/toolchain-upstream/gcc/gcc/testsuite/gcc.target/riscv/rvv/rvv.exp" line 42)     invoked from within "source /scratch/vineetg/gnu/toolchain-upstream/gcc/gcc/testsuite/gcc.target/riscv/rvv/rvv.exp"     ("uplevel" body line 1)     invoked from within "uplevel #0 source /scratch/vineetg/gnu/toolchain-upstream/gcc/gcc/testsuite/gcc.target/riscv/rvv/rvv.exp"     invoked from within "catch "uplevel #0 source $test_file_name" msg" UNRESOLVED: testcase '/scratch/vineetg/gnu/toolchain-upstream/gcc/gcc/testsuite/gcc.target/riscv/rvv/rvv.exp' aborted due to Tcl error testcase /scratch/vineetg/gnu/toolchain-upstream/gcc/gcc/testsuite/gcc.target/riscv/rvv/rvv.exp completed in 0 seconds Running /scratch/vineetg/gnu/toolchain-upstream/gcc/gcc/testsuite/gcc.target/rl78/rl78.exp ... ...