From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mengyan1223.wang (mengyan1223.wang [89.208.246.23]) by sourceware.org (Postfix) with ESMTPS id CB2CF3858400 for ; Sat, 27 Nov 2021 23:43:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org CB2CF3858400 Received: from [IPv6:240e:35a:1026:7200:dc73:854d:832e:2] (unknown [IPv6:240e:35a:1026:7200:dc73:854d:832e:2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature ECDSA (P-384)) (Client did not present a certificate) (Authenticated sender: xry111@mengyan1223.wang) by mengyan1223.wang (Postfix) with ESMTPSA id 3CA0F66293; Sat, 27 Nov 2021 18:43:12 -0500 (EST) Message-ID: Subject: Re: [PATCH 01/12] LoongArch Port: gcc build From: Xi Ruoyao To: chenglulu , gcc-patches@gcc.gnu.org Cc: xuchenghua@loongson.cn, yangyujie@loongson.cn Date: Sun, 28 Nov 2021 07:43:07 +0800 In-Reply-To: References: <20211127082735.4139682-1-chenglulu@loongson.cn> <20211127082735.4139682-2-chenglulu@loongson.cn> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.42.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-3030.2 required=5.0 tests=BAYES_00, BODY_8BITS, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, JMQ_SPF_NEUTRAL, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 27 Nov 2021 23:43:18 -0000 On Sun, 2021-11-28 at 07:39 +0800, Xi Ruoyao via Gcc-patches wrote: > > > In function ‘int isa_fpu_compat_p(const loongarch_isa*, const loongarch_isa*)’, > > inlined from ‘void loongarch_config_target(loongarch_target*, long int, int, int, int, int, int, int, int)’ at ../../gcc/config/loongarch/loongarch-opts.c:194:28: > > ../../gcc/config/loongarch/loongarch-opts.c:436:24: error: ‘t.loongarch_target::isa.loongarch_isa::fpu’ may be used uninitialized [-Werror=maybe-uninitialized  ] > >   436 |         return set1 -> fpu == ISA_EXT_FPU32 || set1 -> fpu == ISA_EXT_FPU64; > >       |                ~~~~~~~~^~~ By the way, we shouldn't have whitespaces around "->" (i. e. it should be set1->fpu). > if (isa_fpu_compat_p (&(t.isa), &(force_isa))); And we shouldn't have those unneeded extra brackets, i. e. it should be &t.isa and &force_isa. -- Xi Ruoyao School of Aerospace Science and Technology, Xidian University