From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 75269 invoked by alias); 24 Nov 2019 17:11:01 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 75261 invoked by uid 89); 24 Nov 2019 17:11:01 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.1 spammy=interest, device X-HELO: us-smtp-1.mimecast.com Received: from us-smtp-delivery-1.mimecast.com (HELO us-smtp-1.mimecast.com) (207.211.31.120) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 24 Nov 2019 17:11:00 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1574615458; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=0trFqn+3lN+CgFm+G1v6ICVsNHzDr01geU4Z2SfNe8k=; b=VxAg2oOH1Y28jZnvpL4pqRmmFbpFqZtxsuSzb186g29yvXIKOVb0gJOo8M42cHNnTYJxu6 Jme9ZSub6TbGoZYa2P/bRxaJ9eyd0Hclod1L2GqJD4vF1CyLhn5YHxs5Nro1l1KRPfLYy0 uOmzlI0O1zrHAPdJVoHsGyi0p36OMj4= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-141-iFZTCpnnOIiAt9yuybGTTg-1; Sun, 24 Nov 2019 12:10:54 -0500 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 9389C1034B20; Sun, 24 Nov 2019 17:10:53 +0000 (UTC) Received: from localhost.localdomain (ovpn-112-3.rdu2.redhat.com [10.10.112.3]) by smtp.corp.redhat.com (Postfix) with ESMTP id ECF8160856; Sun, 24 Nov 2019 17:10:52 +0000 (UTC) Subject: Re: [PATCH 1/4] MSP430: Disable TM clone registry by default To: Jozef Lawrynowicz Cc: "gcc-patches@gcc.gnu.org" References: <20191107213110.0ceea63a@jozef-kubuntu> <20191107213418.2b32fc3c@jozef-kubuntu> <20191124142018.036e2ad2@jozef-kubuntu> From: Jeff Law Message-ID: Date: Sun, 24 Nov 2019 17:24:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: <20191124142018.036e2ad2@jozef-kubuntu> X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2019-11/txt/msg02280.txt.bz2 On 11/24/19 7:20 AM, Jozef Lawrynowicz wrote: > On Sun, 17 Nov 2019 12:11:23 -0700 > Jeff Law wrote: > >> On 11/7/19 2:34 PM, Jozef Lawrynowicz wrote: >>> Given that MSP430 is a resource constrained, embedded target disabling >>> transactional memory by default is a good idea to save on code size in >>> the runtime library. >>> >>> It can still be enabled by passing --enable-tm-clone-registry (although as far >>> as I understand the feature is fundamentally incompatible with MSP430 given >>> reliance on libitm, lack of thread support without an OS and the memory >>> limitations of the device. >>> >> I'm not a huge fan of making the default configurations behave >> differently. But I can also see how something like TM in particular >> isn't of much interest in the embedded space (hell, it's having trouble >> getting real traction in the server space as well). >> >> May be a reasonable path forward is to add the configury bits, keep TM >> on by default and create a different msp target which disables this stuff? > > Ok fair enough, what would an acceptable form for a new target triplet look > like? "msp430-*-elfbare"? Yea, that seems reasonable. > > Since we're into stage 3 now I'll look at doing this for GCC 11. I'd seriously consider letting this into gcc-10. It's going to be well isolated and it's an iteration of something you posted before the stage1->stage3 transition. Your choice if you want to try and pull it together quickly for gcc-10. Jeff