From: Jeff Law <law@redhat.com>
To: Ilya Leoshkevich <iii@linux.ibm.com>,
gcc-patches@gcc.gnu.org, krebbel@linux.ibm.com,
rdapp@linux.ibm.com, ro@CeBiTec.Uni-Bielefeld.DE,
rdsandiford@googlemail.com
Subject: Re: [PATCH] Fix EQ_ATTR_ALT size calculation (PR bootstrap/87417)
Date: Tue, 25 Sep 2018 18:36:00 -0000 [thread overview]
Message-ID: <faaccd92-f4e9-add2-b8aa-5a6293f6d63a@redhat.com> (raw)
In-Reply-To: <874lee17l7.fsf@googlemail.com>
On 9/24/18 11:15 PM, Richard Sandiford wrote:
> Ilya Leoshkevich <iii@linux.ibm.com> writes:
>> Bootstrap and regtest running on s390x-redhat-linux.
>>
>> "r264537: Change EQ_ATTR_ALT to support up to 64 alternatives" changed
>> the format of EQ_ATTR_ALT from ii to ww. This broke the bootstrap on
>> 32-bit systems, because the formula for rtx_code_size assumed that only
>> certain codes contain HOST_WIDE_INTs. This did not surface on 64-bit
>> systems, because rtunion is 8 bytes anyway, but on 32-bit systems it's
>> only 4 bytes. This resulted in out-of-bounds writes and memory
>> corruptions in genattrtab.
>>
>> gcc/ChangeLog:
>>
>> 2018-09-24 Ilya Leoshkevich <iii@linux.ibm.com>
>>
>> PR bootstrap/87417
>> * rtl.c (rtx_code_size): Take into account that EQ_ATTR_ALT
>> contains HOST_WIDE_INTs when computing its size.
>
> OK. Thanks for the quick fix.
And I'll note that my testers were picking up this failure on various
targets -- they're all happy now.
jeff
next prev parent reply other threads:[~2018-09-25 18:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-24 21:53 Ilya Leoshkevich
2018-09-25 6:44 ` Richard Sandiford
2018-09-25 18:36 ` Jeff Law [this message]
2018-10-25 10:41 ` Richard Earnshaw (lists)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=faaccd92-f4e9-add2-b8aa-5a6293f6d63a@redhat.com \
--to=law@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=iii@linux.ibm.com \
--cc=krebbel@linux.ibm.com \
--cc=rdapp@linux.ibm.com \
--cc=rdsandiford@googlemail.com \
--cc=ro@CeBiTec.Uni-Bielefeld.DE \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).