From: David Malcolm <dmalcolm@redhat.com>
To: Hans-Peter Nilsson <hp@axis.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] testsuite: Handle default_packed targets in gcc.dg/plugin
Date: Fri, 17 Mar 2023 12:43:08 -0400 [thread overview]
Message-ID: <fae7bbbaf5be01e83b8e9e576de4306db53de843.camel@redhat.com> (raw)
In-Reply-To: <20230317161047.9F7CE2040E@pchp3.se.axis.com>
On Fri, 2023-03-17 at 17:10 +0100, Hans-Peter Nilsson wrote:
> > From: David Malcolm <dmalcolm@redhat.com>
> > Date: Thu, 16 Mar 2023 14:42:58 -0400
>
> > I think I prefer the top one-liner dg-skip-if approach you
> > mentioned in
> > your original email; it seems simplest.
>
> Ok then. There's also a choice between adding a
> target-specifier (i.e. "{ target { ! default_packed } }") to
> the dg-compile line, but a dg-skip-if is somewhat more
> scalable and can, like here, be a bit more informative.
>
> This is what I'll commit, as "testsuite: Skip some
> gcc.dg/plugin tests for default_packed targets":
Thanks!
Dave
next prev parent reply other threads:[~2023-03-17 16:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-09 18:56 Hans-Peter Nilsson
2023-03-16 15:29 ` Ping: " Hans-Peter Nilsson
2023-03-16 17:55 ` David Malcolm
2023-03-16 18:25 ` Hans-Peter Nilsson
2023-03-16 18:42 ` David Malcolm
2023-03-17 16:10 ` Hans-Peter Nilsson
2023-03-17 16:43 ` David Malcolm [this message]
2023-03-16 18:45 ` Hans-Peter Nilsson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fae7bbbaf5be01e83b8e9e576de4306db53de843.camel@redhat.com \
--to=dmalcolm@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=hp@axis.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).