From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from xry111.site (xry111.site [IPv6:2001:470:683e::1]) by sourceware.org (Postfix) with ESMTPS id F1A3C3858D39 for ; Mon, 27 Mar 2023 10:00:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org F1A3C3858D39 Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=xry111.site Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=xry111.site DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=xry111.site; s=default; t=1679911201; bh=zoNsMklJIOp33MG+pW8N2HvKqMF8zfShN7Y6sXGK6ig=; h=Subject:From:To:Date:In-Reply-To:References:From; b=TulLkILm8mWQCoON9fTPw+UB5RcnzHERgwVW7B/V86WqMT/d6ReX5SACaic25wBNI eNod1WtMy9hgCoCCBXE7jdRVCRZufW9yUkAWlPh+0whJ2aHtPzGOgEQDjOU7ytT0ER 5ERGd3xD4mybGpmPRBzEmlmVW1P/Tfz+0Oyw8Cos= Received: from [192.168.124.9] (unknown [113.140.29.9]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature ECDSA (P-384) server-digest SHA384) (Client did not present a certificate) (Authenticated sender: xry111@xry111.site) by xry111.site (Postfix) with ESMTPSA id E1F1266272; Mon, 27 Mar 2023 06:00:00 -0400 (EDT) Message-ID: Subject: Re: [PATCH] driver: Treat include path args the same way between cpp_unique_options and asm_options. [PR71850] From: Xi Ruoyao To: Costas Argyris , gcc-patches@gcc.gnu.org Date: Mon, 27 Mar 2023 17:59:48 +0800 In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.48.0 MIME-Version: 1.0 X-Spam-Status: No, score=-0.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,LIKELY_SPAM_FROM,RCVD_IN_BARRACUDACENTRAL,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Mon, 2023-03-27 at 10:36 +0100, Costas Argyris via Gcc-patches wrote: > [ping^3] >=20 > This looks like it fixes the bug and also unifies the way include paths a= re > passed from the driver to the compiler and assembler (when a @file has > been passed to the driver in the first place). >=20 > That is, when @file has been passed to the driver, put the include paths > in a temp @file and pass them to the assembler.=C2=A0=C2=A0=C2=A0 Note th= is is already > happening for the compiler, so this patch merely extends this logic to th= e > assembler. >=20 > Is there any reason not to go for it? It's not supported by all GNU assembler releases. For example, GCC installation doc says we require Binutils >=3D 2.13.1 for i?86-*-linux*. Binutils 2.13.1 was released in 2002, but @FILE support was added into Binutils in 2005. > >=20 --=20 Xi Ruoyao School of Aerospace Science and Technology, Xidian University