From: Jeff Law <law@redhat.com>
To: Tamar Christina <Tamar.Christina@arm.com>,
GCC Patches <gcc-patches@gcc.gnu.org>
Cc: James Greenhalgh <James.Greenhalgh@arm.com>,
Richard Earnshaw <Richard.Earnshaw@arm.com>,
Marcus Shawcroft <Marcus.Shawcroft@arm.com>,
nd <nd@arm.com>
Subject: Re: [PATCH] Allow FP to be used as a call-saved registe
Date: Mon, 12 Sep 2016 17:22:00 -0000 [thread overview]
Message-ID: <fb73390a-0895-a471-d66e-7bfd172f6f39@redhat.com> (raw)
In-Reply-To: <VI1PR0801MB2031CAD1F37FA14F8AA4B6CEFFE60@VI1PR0801MB2031.eurprd08.prod.outlook.com>
On 09/05/2016 08:59 AM, Tamar Christina wrote:
> Hi All,
>
> This patch allows the FP register to be used as a call-saved
> register when -fomit-frame-pointer is used.
>
> The change is done in such a way that the defaults do not change.
> To use the FP register both -fomit-frame-pointer and
> -fcall-saved-<hard_fp_reg> need to be used.
>
> Regression ran on aarch64-none-linux-gnu and no regressions.
> Bootstrapped and ran regressions on `x86_64` and no regressions.
>
> A new test fp_free_1 was added to test functionality.
>
> Ok for trunk?
>
> Thanks,
> Tamar
>
> PS. I don't have commit rights so if OK can someone apply the patch for me.
>
> gcc/
> 2016-09-01 Tamar Christina <tamar.christina@arm.com>
>
> * gcc/reginfo.c (fix_register): Allow FP to be set if
> -fomit-frame-pointer.
I'm a little surprised you need this. Most ports allow use of FP as a
call-saved register with -fomit-frame-pointer.
Also note the documentation explicitly forbids using -fcall-saved for
the stack or frame pointer.
Jeff
next prev parent reply other threads:[~2016-09-12 17:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-05 15:00 Tamar Christina
2016-09-12 10:41 ` James Greenhalgh
2016-09-12 17:22 ` Jeff Law [this message]
2016-09-13 11:15 ` Tamar Christina
2016-09-15 16:43 ` Jeff Law
2016-09-19 10:55 ` Richard Earnshaw (lists)
2016-09-19 16:56 ` Jeff Law
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fb73390a-0895-a471-d66e-7bfd172f6f39@redhat.com \
--to=law@redhat.com \
--cc=James.Greenhalgh@arm.com \
--cc=Marcus.Shawcroft@arm.com \
--cc=Richard.Earnshaw@arm.com \
--cc=Tamar.Christina@arm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=nd@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).