From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 69534 invoked by alias); 12 Sep 2016 17:16:23 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 68088 invoked by uid 89); 12 Sep 2016 17:16:23 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1072, rights X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 12 Sep 2016 17:16:13 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id C23398553C; Mon, 12 Sep 2016 17:16:11 +0000 (UTC) Received: from localhost.localdomain (ovpn-116-111.phx2.redhat.com [10.3.116.111]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u8CHGBPQ021235; Mon, 12 Sep 2016 13:16:11 -0400 Subject: Re: [PATCH] Allow FP to be used as a call-saved registe To: Tamar Christina , GCC Patches References: Cc: James Greenhalgh , Richard Earnshaw , Marcus Shawcroft , nd From: Jeff Law Message-ID: Date: Mon, 12 Sep 2016 17:22:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2016-09/txt/msg00649.txt.bz2 On 09/05/2016 08:59 AM, Tamar Christina wrote: > Hi All, > > This patch allows the FP register to be used as a call-saved > register when -fomit-frame-pointer is used. > > The change is done in such a way that the defaults do not change. > To use the FP register both -fomit-frame-pointer and > -fcall-saved- need to be used. > > Regression ran on aarch64-none-linux-gnu and no regressions. > Bootstrapped and ran regressions on `x86_64` and no regressions. > > A new test fp_free_1 was added to test functionality. > > Ok for trunk? > > Thanks, > Tamar > > PS. I don't have commit rights so if OK can someone apply the patch for me. > > gcc/ > 2016-09-01 Tamar Christina > > * gcc/reginfo.c (fix_register): Allow FP to be set if > -fomit-frame-pointer. I'm a little surprised you need this. Most ports allow use of FP as a call-saved register with -fomit-frame-pointer. Also note the documentation explicitly forbids using -fcall-saved for the stack or frame pointer. Jeff