From: Jeff Law <jeffreyalaw@gmail.com>
To: Jan-Benedict Glaw <jbglaw@lug-owl.de>,
Denis Chertykov <chertykov@gmail.com>,
gcc-patches@gcc.gnu.org
Subject: Re: PING: [AVR] Fix unused argument warning
Date: Tue, 5 Oct 2021 08:53:00 -0600 [thread overview]
Message-ID: <fba7a03d-2b76-cd2c-91ae-56f6e770255a@gmail.com> (raw)
In-Reply-To: <20211005144613.vzmpjn4d2yszhfrk@lug-owl.de>
On 10/5/2021 8:46 AM, Jan-Benedict Glaw wrote:
> Hi,
>
> On Thu, 2021-09-30 21:27:23 +0200, Jan-Benedict Glaw <jbglaw@lug-owl.de> wrote:
>> gcc/ChangeLog:
>>
>> * common/config/avr/avr-common.c (avr_handle_option): Mark
>> argument as ATTRIBUTE_UNUSED.
>>
>> diff --git a/gcc/common/config/avr/avr-common.c b/gcc/common/config/avr/avr-common.c
>> index 6486659d27c..a6939ad03d3 100644
>> --- a/gcc/common/config/avr/avr-common.c
>> +++ b/gcc/common/config/avr/avr-common.c
>> @@ -77,7 +77,8 @@ static const struct default_options avr_option_optimization_table[] =
>>
>> static bool
>> avr_handle_option (struct gcc_options *opts, struct gcc_options*,
>> - const struct cl_decoded_option *decoded, location_t loc)
>> + const struct cl_decoded_option *decoded,
>> + location_t loc ATTRIBUTE_UNUSED)
>> {
>> int value = decoded->value;
>>
>>
>>
>> Ok for trunk?
> Wanted to give this a ping.
I thought I sent a reply a few days ago. Instead of using
ATTRIBUTE_UNUSED, just drop the parameter's name. You should consider
that pre-approved for this and any other cases you run into.
jeff
next prev parent reply other threads:[~2021-10-05 14:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-30 19:27 Jan-Benedict Glaw
2021-10-05 14:46 ` PING: " Jan-Benedict Glaw
2021-10-05 14:53 ` Jeff Law [this message]
2021-10-05 15:03 ` Jan-Benedict Glaw
2021-10-05 15:06 ` Jeff Law
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fba7a03d-2b76-cd2c-91ae-56f6e770255a@gmail.com \
--to=jeffreyalaw@gmail.com \
--cc=chertykov@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jbglaw@lug-owl.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).