From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk1-x734.google.com (mail-qk1-x734.google.com [IPv6:2607:f8b0:4864:20::734]) by sourceware.org (Postfix) with ESMTPS id B70653858429 for ; Tue, 5 Oct 2021 14:53:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B70653858429 Received: by mail-qk1-x734.google.com with SMTP id i132so20060486qke.1 for ; Tue, 05 Oct 2021 07:53:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=euaoYVwWY7Pb16WkqhRylm62kln0PYKb2H/Fsckun6s=; b=kmYXk4ELIEuI0l2n3t44kXrK3zaWddtr7VMSgQVWnTD0XhUaV2x5ZqSQ6EaCjlu9pq k/+6a7IIynkxDwflE9rdmkd32Rw/ppID9Th1qeSaYWwsdJjEpjyjevNc/NFCZvkgszbk bOrJwOwNDgUi2j0JuCVSl+YpLDHbLdSmyKSnGJLuHCzQ2pjg8icFVZAM5/9LU+iX2Z2f AAAQAV4mkG6f4K/hz+p0GdiXLJOD6fwk5Fefls7xszu67T95qBPJnOrnd/0D3ki6xQei TTjKrDTcCd6LUcg+X7mLCVr7xRHTfaHNSABXchtKS8tMu73QYi6cW5lMOrS/uJhRRYrr JTwg== X-Gm-Message-State: AOAM530WEbrl64C3ZvYsKGQtnV0/ytNgZKKzPoOqq3TwFLp9vz2qesVD EaJqCjOnVXLIoHdiAAAHTgkLZ+X1RBw= X-Google-Smtp-Source: ABdhPJy6JnBCIzMdI0bqvJH+fMokiysPBJiN8LapZzTOILFgqCyX2hWSkSVVuLjXD0feXJJd7QudOQ== X-Received: by 2002:a37:9a06:: with SMTP id c6mr15359859qke.53.1633445581960; Tue, 05 Oct 2021 07:53:01 -0700 (PDT) Received: from [172.31.0.175] (c-98-202-48-222.hsd1.ut.comcast.net. [98.202.48.222]) by smtp.gmail.com with ESMTPSA id m5sm11646452qtk.88.2021.10.05.07.53.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 05 Oct 2021 07:53:01 -0700 (PDT) Subject: Re: PING: [AVR] Fix unused argument warning To: Jan-Benedict Glaw , Denis Chertykov , gcc-patches@gcc.gnu.org References: <20210930192723.hbh2nemcsm55bxig@lug-owl.de> <20211005144613.vzmpjn4d2yszhfrk@lug-owl.de> From: Jeff Law Message-ID: Date: Tue, 5 Oct 2021 08:53:00 -0600 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: <20211005144613.vzmpjn4d2yszhfrk@lug-owl.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-Spam-Status: No, score=-8.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Oct 2021 14:53:03 -0000 On 10/5/2021 8:46 AM, Jan-Benedict Glaw wrote: > Hi, > > On Thu, 2021-09-30 21:27:23 +0200, Jan-Benedict Glaw wrote: >> gcc/ChangeLog: >> >> * common/config/avr/avr-common.c (avr_handle_option): Mark >> argument as ATTRIBUTE_UNUSED. >> >> diff --git a/gcc/common/config/avr/avr-common.c b/gcc/common/config/avr/avr-common.c >> index 6486659d27c..a6939ad03d3 100644 >> --- a/gcc/common/config/avr/avr-common.c >> +++ b/gcc/common/config/avr/avr-common.c >> @@ -77,7 +77,8 @@ static const struct default_options avr_option_optimization_table[] = >> >> static bool >> avr_handle_option (struct gcc_options *opts, struct gcc_options*, >> - const struct cl_decoded_option *decoded, location_t loc) >> + const struct cl_decoded_option *decoded, >> + location_t loc ATTRIBUTE_UNUSED) >> { >> int value = decoded->value; >> >> >> >> Ok for trunk? > Wanted to give this a ping. I thought I sent a reply a few days ago.  Instead of using ATTRIBUTE_UNUSED, just drop the parameter's name.  You should consider that pre-approved for this and any other cases you run into. jeff