From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-x52a.google.com (mail-pg1-x52a.google.com [IPv6:2607:f8b0:4864:20::52a]) by sourceware.org (Postfix) with ESMTPS id BBD6C3858D35 for ; Tue, 23 Apr 2024 00:31:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org BBD6C3858D35 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=rivosinc.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=rivosinc.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org BBD6C3858D35 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::52a ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713832313; cv=none; b=LoSls+y1lp/4+VH5p5BGJVbwoBInrQGrverXjZblEXXv2E0qebFByrPVH1vrFxvMWq8pqjidz4mnW4iqmO0nvY1NrrrfbYHjC1gIfqz8T4fR/6pn0psLbqkF2iVQCC6xlllXS38jKwt79IjcoaXqw2yPg2s0SqcMf61vIpWSRrw= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713832313; c=relaxed/simple; bh=BAL5uPpS8SuH/tmwivveyM42f2DVux+PhwWmBNuilTs=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:From:To; b=Bg9qjDh57G7OWQt2nqCONHlRDsQ4kgkGCFbGDQDgK+C8InfMgf66VhwriWMc4GR3jctKPkL/WbU2MsOfqq/v8w3zL6XMKJ2vXO3QKjLPnctdybN+8KshuU5VwFAR3VCMt8V2m2oajMJGGlRR/fs104DCtFblI0u9vJgeDKnuUL4= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pg1-x52a.google.com with SMTP id 41be03b00d2f7-60275a82611so589069a12.1 for ; Mon, 22 Apr 2024 17:31:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20230601.gappssmtp.com; s=20230601; t=1713832309; x=1714437109; darn=gcc.gnu.org; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:user-agent:mime-version:date:message-id:from:to :cc:subject:date:message-id:reply-to; bh=LTxA2ETmInPCw3dvZlUXAYaTKA4sws/UmH+/blUGhN4=; b=ZExqaaEkN6qW83Q+d8QTnZVNhXlaMZ8Dqct36D8SPogajsfKW+88Bm+z3+Y7x8K1+n k2E+98Q7aY5B6PdUPK8eukSlJ91GTcLG3ltWOd5iYXQurOwGBaLVwL+RdG0q0TBQkqYd OFfceo4Nu5Cz45iAV4nMzs42nE8P75Z7JM9uTKtFk4HqB2MMldV72c6rpJWCAkjdb/G5 K8bDeOFadLT3xJ7obLJENOLuXgk5OhaI/HILUKF5B+aX3L+TWjpk3ceyp6nq7amnRKyI XvfZDWOTJTeB8Ug1D6uBK2vKhh/MCPzXybEsNbkvOLGwy0C+Z3wBX+6PVBGCrBqCTT2G 6OcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713832309; x=1714437109; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=LTxA2ETmInPCw3dvZlUXAYaTKA4sws/UmH+/blUGhN4=; b=M/s+w9MoOshXk0BZ41MMhdi9ovLrR46LcBejP1FiHwtLihGze5CyOe11jAClyV1Le6 WF4zD46H3F0rFplqbLRuBES6jipT86uUGAccETA1/aM1ovgmKc0kDNGwHJaOifeK+Rwf ROjytrfXS5OlFHpL1iwCU2KTUgh13D39NKmLsBu/dwg+GIr5II7jHnM5Ux0ORW5r/gY0 R1XQkAbdOWzt6SCc5neVHp8WmwPIlPcywdfuR2ctUOjestYYmATV3pbT8uFKDHlm6HaL msSOKyYhVRC7like/nAMUqIq8NBUBCCnBmvbQlkEtedZORlQBU8m3b1IPk6xCzaC+LzI PL5w== X-Forwarded-Encrypted: i=1; AJvYcCWGnkrPvU93lwYUUrIhGJLvgwzyWGzoYitvchP2zBfJXRzPl18WOxiD/d2OJ2IBlB6AiiqrKqYq1rul4qeGbzTlOWMwwuDgyQ== X-Gm-Message-State: AOJu0Yxq4llAIAXaI7YLVgnlDpv3JzaMdY4xjKOqPBFybu0iuHN2cjYe 0K00fRcN5w8+OMl8vStYM1qCfE2/YKYLH3u0VgHpGA+LzVPc3kDlkB7ZbO97xMmZ7PTp7Zg5acv D X-Google-Smtp-Source: AGHT+IHHkJG2yIdhdzcp4Urfkzn/ysicgJCf+Ik4g8PrgJnxpCHyB4f3BZHRtkbn9D6TFTdAy+QXSA== X-Received: by 2002:a17:90a:de91:b0:2ab:a825:ae5 with SMTP id n17-20020a17090ade9100b002aba8250ae5mr9227967pjv.22.1713832309546; Mon, 22 Apr 2024 17:31:49 -0700 (PDT) Received: from [10.0.17.156] ([50.145.13.30]) by smtp.gmail.com with ESMTPSA id mv15-20020a17090b198f00b002ae3f808a31sm1726401pjb.39.2024.04.22.17.31.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 22 Apr 2024 17:31:49 -0700 (PDT) Message-ID: Date: Mon, 22 Apr 2024 17:31:47 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1] RISC-V: Adjust overlap attr after revert d3544cea63d and e65aaf8efe1 From: Patrick O'Neill To: pan2.li@intel.com, gcc-patches@gcc.gnu.org Cc: juzhe.zhong@rivai.ai, kito.cheng@gmail.com, rdapp.gcc@gmail.com References: <20240422134734.1909499-1-pan2.li@intel.com> Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-9.7 required=5.0 tests=BAYES_00,BODY_8BITS,DKIM_SIGNED,DKIM_VALID,GIT_PATCH_0,KAM_NUMSUBJECT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: This patch in particular does not cause any more regressions. It's one of the other reverts from the weekend. Before the reverts [1]:                                             |          gcc |          g++ |     gfortran |     rv64gcv/  lp64d/ medlow |   48/    32 |     12/    3|   12 /    2 After the reverts:                                             |          gcc |          g++ |     gfortran |     rv64gcv/  lp64d/ medlow |   50 /    33 |   12 /     3 |   26 /     7 | gcc new fails: FAIL: gcc.dg/graphite/pr111878.c (internal compiler error: in extract_insn, at recog.cc:2812) FAIL: gcc.dg/graphite/pr111878.c (test for excess errors) gfortran new fails: FAIL: gfortran.dg/graphite/id-27.f90   -O  (internal compiler error: in extract_insn, at recog.cc:2812) FAIL: gfortran.dg/graphite/id-27.f90   -O  (test for excess errors) FAIL: gfortran.dg/graphite/pr14741.f90   -O  (internal compiler error: in extract_insn, at recog.cc:2812) FAIL: gfortran.dg/graphite/pr14741.f90   -O  (test for excess errors) FAIL: gfortran.dg/graphite/pr29581.f90   -O3 -fomit-frame-pointer -funroll-loops -fpeel-loops -ftracer -finline-functions  (internal compiler error: in extract_insn, at recog.cc:2812) FAIL: gfortran.dg/graphite/pr29581.f90   -O3 -fomit-frame-pointer -funroll-loops -fpeel-loops -ftracer -finline-functions  (test for excess errors) FAIL: gfortran.dg/graphite/pr29581.f90   -O3 -g  (internal compiler error: in extract_insn, at recog.cc:2812) FAIL: gfortran.dg/graphite/pr29581.f90   -O3 -g  (test for excess errors) FAIL: gfortran.dg/graphite/pr29832.f90   -O3 -fomit-frame-pointer -funroll-loops -fpeel-loops -ftracer -finline-functions  (internal compiler error: in extract_insn, at recog.cc:2812) FAIL: gfortran.dg/graphite/pr29832.f90   -O3 -fomit-frame-pointer -funroll-loops -fpeel-loops -ftracer -finline-functions  (test for excess errors) FAIL: gfortran.dg/graphite/pr29832.f90   -O3 -g  (internal compiler error: in extract_insn, at recog.cc:2812) FAIL: gfortran.dg/graphite/pr29832.f90   -O3 -g  (test for excess errors) FAIL: gfortran.dg/graphite/vect-pr40979.f90   -O  (internal compiler error: in extract_insn, at recog.cc:2812) FAIL: gfortran.dg/graphite/vect-pr40979.f90   -O  (test for excess errors) For future reference, the precommit does not do well with many unrelated patches that are dependent on eachother. In the future sending these as a series would allow precommit to properly test them (as always you can see the testing results on patchworks). Thanks, Patrick [1] https://github.com/patrick-rivos/gcc-postcommit-ci/issues/801 On 4/22/24 12:55, Patrick O'Neill wrote: > Hi Pan, > > I was running the testsuite for this and noticed an ICE scroll by when > this patch is applied to cacc55a4c0be8d0bc7417b6a28924eadbbe428e3 for > rv64gcv: > > FAIL: gfortran.dg/graphite/pr29832.f90   -O3 -fomit-frame-pointer > -funroll-loops -fpeel-loops -ftracer -finline-functions  (internal > compiler error: in extract_insn, at recog.cc:2812) > > I'll send the full list of new failures once the runs finish. > > Thanks, > Patrick > > On 4/22/24 06:47, pan2.li@intel.com wrote: >> From: Pan Li >> >> After we reverted below 2 commits, the reference to attr need some >> adjustment as the group_overlap is no longer available. >> >> * RISC-V: Robostify the W43, W86, W87 constraint enabled attribute >> * RISC-V: Rename vconstraint into group_overlap >> >> The below tests are passed for this patch. >> >> * The rv64gcv fully regression tests. >> >> gcc/ChangeLog: >> >>     * config/riscv/vector-crypto.md: >> >> Signed-off-by: Pan Li >> --- >>   gcc/config/riscv/vector-crypto.md | 2 +- >>   1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/gcc/config/riscv/vector-crypto.md >> b/gcc/config/riscv/vector-crypto.md >> index 519c6a10d94..23dc549e5b8 100755 >> --- a/gcc/config/riscv/vector-crypto.md >> +++ b/gcc/config/riscv/vector-crypto.md >> @@ -322,7 +322,7 @@ (define_insn "@pred_vwsll_scalar" >>     "vwsll.v%o4\t%0,%3,%4%p1" >>     [(set_attr "type" "vwsll") >>      (set_attr "mode" "") >> -   (set_attr "group_overlap" >> "W21,W21,W21,W21,W42,W42,W42,W42,W84,W84,W84,W84,none,none")]) >> +   (set_attr "vconstraint" >> "W21,W21,W21,W21,W42,W42,W42,W42,W84,W84,W84,W84,no,no")]) >>     ;; vbrev.v vbrev8.v vrev8.v >>   (define_insn "@pred_v"