From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-x42c.google.com (mail-pf1-x42c.google.com [IPv6:2607:f8b0:4864:20::42c]) by sourceware.org (Postfix) with ESMTPS id A95B93858D1E for ; Tue, 25 Apr 2023 21:35:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A95B93858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pf1-x42c.google.com with SMTP id d2e1a72fcca58-63b5465fc13so5082905b3a.3 for ; Tue, 25 Apr 2023 14:35:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1682458507; x=1685050507; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=RPeLEZ1I/QD63p6E7itRodxVU8weiNUM2ZcdOMnae00=; b=R1B8a1DiZNLXYhjAxNlqbQr89FzxSA3E6gDKJVs/a6ghInngbgCUzi4yBE/OiCJY12 EqwaLuIlcEqjEHgDw0a+EJlzMo4TxSziGC8j2O2ik+EEti+dOzd4TP/HT18iqHioES2s QQOfRRlMegY4sGlRffpNhkh9ReLk+E99NUBVxDAcaiFG3EGSd6QaH+4Wa6zXFgop03Uz rQl9Hm3THhObX+zhskvuUuLS4fFDscdF9N5EYrpY8gdyg0aULMpNg933lfnXsBKHHCSR sPnfZ6A14eVYFByM1hAEBuGiX9b/qaUOnv0UiyZjIklkrpxyJ25gK8WM7jC9IOICTBTc gT4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682458507; x=1685050507; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=RPeLEZ1I/QD63p6E7itRodxVU8weiNUM2ZcdOMnae00=; b=gljTs/9oAaSd+p9vpMYSannLM29byOnFfdkSO8JGW1AFbSjkf9nU3GDMQsDKJKFQko ud4tm5fYT/rLLL2RERmYbcQQ+t0jPq+tGHfGXwNu+leFW+kfhA/kCiN7xG/4j7fC3UUp TLft0kqAAW+CiQpa9a6zDTO5Cl+9R64e9UenYJb/eg6UDGsbLMzn54tOsHYf5NVcQmXG 1gbSioxghKkv03BYuetzSt14yPRJtnwTR8DMmqIk4Abxsh3BwI1SI28RdhX5+mmAjdwh e4fRl/+VXwAnylRzSk6b1tmyOHtXiSNIlV06GBjkpF+6RLQkpJU8kplV0BBn80SINyjj OuYg== X-Gm-Message-State: AAQBX9cJ42sWh269Ef4cNomS5nUADlc9O4yuJJzklNe9AS0gVkx6Trc/ rLQ+sHo1+90K4XetsQA8ZI8= X-Google-Smtp-Source: AKy350YVB84eBydGBaL/uPn7V5/+DbK2xmLvT/QuICDgEoQD/+eMFbH1NS+Obf1csD43NG7u3+jRwQ== X-Received: by 2002:a05:6a00:2d24:b0:640:ddf8:607a with SMTP id fa36-20020a056a002d2400b00640ddf8607amr9139312pfb.14.1682458507453; Tue, 25 Apr 2023 14:35:07 -0700 (PDT) Received: from ?IPV6:2601:681:8600:13d0::99f? ([2601:681:8600:13d0::99f]) by smtp.gmail.com with ESMTPSA id x7-20020a056a00270700b0062ddefe02dfsm10018032pfv.171.2023.04.25.14.35.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 25 Apr 2023 14:35:06 -0700 (PDT) Message-ID: Date: Tue, 25 Apr 2023 15:35:05 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [Committed] riscv: relax splitter restrictions for creating pseudos Content-Language: en-US To: Vineet Gupta , gcc-patches@gcc.gnu.org Cc: kito.cheng@gmail.com, Palmer Dabbelt , Philipp Tomsich , Christoph Mullner , gnu-toolchain@rivosinc.co References: <20230418143635.980594-1-vineetg@rivosinc.com> <680c7bbe-5d6e-07cd-8468-247afc65e1dd@gmail.com> <3d4cda57-e0f0-9861-6969-f31f22ca9ef8@gmail.com> From: Jeff Law In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-3.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 4/25/23 14:20, Vineet Gupta wrote: >> Just a note, there are some regressions in this table.  For example xz >> input #2.  So to be fair when making comparisons it's probably worth >> noting the regressions as well as improvements. > > Fair point, but in my defense I dropped anything under 0.1 % (including > improvements). No worries. >> Anyway, my results are in line with yours. Given the instruction >> counts and known IPC, I think we're taking about a 2.5% hit on >> deepsjeng and about a 1% hit on leela and x264#2 comparing our >> internal gcc-12 vs gcc-13 trees. > > I think you are referring to the bigger deepsjeng regression due to > commit 2e886eef7f2b5a which introduced the splitter movconst_internal. > This patch is about a small improvement to all splitters which reduces > that perf loss slightly (but does regress some tests too as pointed above). Correct. I'm referring to the larger gcc-12 to gcc-13 comparison, not your patch in my comment about regressions. Sorry for not being clear about that. Jeff