From: Jason Merrill <jason@redhat.com>
To: Paolo Carlini <paolo.carlini@oracle.com>,
"gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Subject: Re: [C++ Patch] Fix cp_parser_unqualified_id typo
Date: Mon, 03 Jun 2019 17:34:00 -0000 [thread overview]
Message-ID: <fbba97fd-7c7c-3565-b611-63b8bffaea88@redhat.com> (raw)
In-Reply-To: <c15d762d-67cb-fde5-baea-5553fc2f7b74@oracle.com>
On 5/31/19 5:05 AM, Paolo Carlini wrote:
>
> By the way, we have the option of using build_min_nt_loc instead of
> build_nt in all these places for BIT_NOT_EXPR in
> cp_parser_unqualified_id, Certainly it has the advantage that the
> location information survives in the tree node when cp_expr is
> eventually converted to a plain tree... (below tests fine) What do you
> think?
This patch is OK.
Jason
prev parent reply other threads:[~2019-06-03 17:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-31 9:26 Paolo Carlini
2019-06-03 17:34 ` Jason Merrill [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fbba97fd-7c7c-3565-b611-63b8bffaea88@redhat.com \
--to=jason@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=paolo.carlini@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).