From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 71034 invoked by alias); 3 Jun 2019 17:34:38 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 71026 invoked by uid 89); 3 Jun 2019 17:34:37 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-6.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 spammy=HX-Languages-Length:456 X-HELO: mail-qt1-f171.google.com Received: from mail-qt1-f171.google.com (HELO mail-qt1-f171.google.com) (209.85.160.171) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 03 Jun 2019 17:34:33 +0000 Received: by mail-qt1-f171.google.com with SMTP id l3so10401877qtj.5 for ; Mon, 03 Jun 2019 10:34:32 -0700 (PDT) Return-Path: Received: from [192.168.1.116] (209-6-216-142.s141.c3-0.smr-cbr1.sbo-smr.ma.cable.rcncustomer.com. [209.6.216.142]) by smtp.gmail.com with ESMTPSA id l40sm1889683qtc.51.2019.06.03.10.34.29 (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Mon, 03 Jun 2019 10:34:30 -0700 (PDT) Subject: Re: [C++ Patch] Fix cp_parser_unqualified_id typo To: Paolo Carlini , "gcc-patches@gcc.gnu.org" References: From: Jason Merrill Message-ID: Date: Mon, 03 Jun 2019 17:34:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2019-06/txt/msg00108.txt.bz2 On 5/31/19 5:05 AM, Paolo Carlini wrote: > > By the way, we have the option of using build_min_nt_loc instead of > build_nt in all these places for BIT_NOT_EXPR in > cp_parser_unqualified_id, Certainly it has the advantage that the > location information survives in the tree node when cp_expr is > eventually converted to a plain tree... (below tests fine) What do you > think? This patch is OK. Jason