From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lj1-x229.google.com (mail-lj1-x229.google.com [IPv6:2a00:1450:4864:20::229]) by sourceware.org (Postfix) with ESMTPS id 18089385840A; Wed, 8 Nov 2023 20:00:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 18089385840A Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 18089385840A Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::229 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699473612; cv=none; b=CqIMnt9/s4FmkeVjEsW63hc5wirasTUkLHTe/RQ71c4+2eaQC9AoQ8NoJOctsN8Z0iyfctFpOyYhBP4yDHV7jBmY/S+r0DSI0XdYPRLDerruJHFsVNp8kVzn/d/sIvIU5XhvDDPFJe8WVzSKLQOHZSMiPwa2QOtakh+13MTQpEw= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699473612; c=relaxed/simple; bh=KxIBkpGJsXTphPUsYQy6irfLpkYjgpwIn2QCA+W2q88=; h=DKIM-Signature:Message-ID:Date:MIME-Version:From:Subject:To; b=URfTVrZe4dqic+1KcAFj4m0RZxI1qbjBFbkyJ49yYk94/QgmTPs1eggXBOtZMVV6N8curo3kwhA8l6HoRwYXLuxgbaFdd8et8H1RlU9krBFbuxJaZj0fPcirxNbVXqBL8aDX247ARofrjOYo+L+tA42xUMzuGJhBoKckoIWWUB4= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-lj1-x229.google.com with SMTP id 38308e7fff4ca-2c7369df9d6so367851fa.1; Wed, 08 Nov 2023 12:00:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1699473606; x=1700078406; darn=gcc.gnu.org; h=content-language:cc:to:subject:from:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=K+x/ig+lPigQTru9itH5qWTZ/mAbDDuvy56DdWyJBqs=; b=T1+OoBjSO8ixUKO0GSdKnnqb08wH+i3L1g01E9HB2Jt2j3WdyB53aEDGwlP/8X4nyf GcykSruuPEUqwdWt5B/FGID+H+J04UurG3Qsr3wdEJ3UnRcZxKbgjxXWlitrH8KRzmCs 14TV5yB5BKIRN/cCbHVgML0eNGn6j+jXuPNkNTiCzV+Y6pCiFRyBpSz0nXk+nzS47iWr D4NHrF8VE7VxKFqeN3Vjvm9iav/vwHhuED+/R/aaZOJVR0fC1erJZm6N4P0LHqjz2f7G xYJowj4C7Yb6vXYFdPXpQVWOO20VHyCEhH/o1ZiU19KVQ87Akbb7HEsvmwHRfz+uCG2k mS5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699473606; x=1700078406; h=content-language:cc:to:subject:from:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=K+x/ig+lPigQTru9itH5qWTZ/mAbDDuvy56DdWyJBqs=; b=A/rYljmm+2zbNF+t141XIF1T5CzlHVIRztfR2lK91aTvzgXPdXR60AUHZCo6Kuw7vZ MtHWFtn0uGCRAtzOxWOxnTm+Y84LEvi9HjHWD9KxoprfLQCETSyTw/vzJjseLVenwoeh zYSaWO0Hz3/+CsW5Q9bWwACXyJ+yQOcgQsIaRrRwbUH2PpLMrV1rBRt5sxhvBFI6H3wO MSofUuf3DbBhZuYGT38UvPGil8CX3po0KgpD2fMZ0lCScrp8rPVnnieBQXJHD2632jcX gf2o+Zpi23io+zY4kbddhzjHeIpZoGAPe/iDMIV8qqa+HcdcL+O2Q4ly/oskkVE2ygy6 dSOA== X-Gm-Message-State: AOJu0YwyQvjNMKhqOMsFyNiJV62zpYVNmKlXQzdUpRSybwdd3O3pj9Hw aUH7KErV7aelAYxeb3xsq/yl15oP3uQ= X-Google-Smtp-Source: AGHT+IGcZ2YNylA7sx6No2qJm7pFkj+s/AJ7ILnU/d8221Ogk0I0sJq0nOLCnGNT5MNRvDgqtVf3ow== X-Received: by 2002:a05:651c:3ca:b0:2c6:f625:cc61 with SMTP id f10-20020a05651c03ca00b002c6f625cc61mr2391124ljp.31.1699473605535; Wed, 08 Nov 2023 12:00:05 -0800 (PST) Received: from ?IPV6:2a01:e0a:1dc:b1c0:50d7:d658:1304:a1c7? ([2a01:e0a:1dc:b1c0:50d7:d658:1304:a1c7]) by smtp.gmail.com with ESMTPSA id k8-20020a05600c1c8800b004081a011c0esm20356033wms.12.2023.11.08.12.00.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 08 Nov 2023 12:00:04 -0800 (PST) Content-Type: multipart/mixed; boundary="------------fJT27PY0sYBs1qKkFmGhC1DV" Message-ID: Date: Wed, 8 Nov 2023 21:00:03 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: =?UTF-8?Q?Fran=C3=A7ois_Dumont?= Subject: [PATCH][_Hahstable] Use RAII to guard node pointer while constructing To: libstdc++ Cc: gcc-patches Content-Language: en-US X-Spam-Status: No, score=-9.6 required=5.0 tests=BAYES_00,BODY_8BITS,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: This is a multi-part message in MIME format. --------------fJT27PY0sYBs1qKkFmGhC1DV Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Another proposal to use RAII rather than __try/__catch block. libstdc++: [_Hashtable] Use RAII type to guard node while constructing value libstdc++-v3/ChangeLog:         * include/bits/hashtable_policy.h         (struct _NodePtrGuard<_HashtableAlloc, _NodePtr>): New.         (_ReuseAllocNode::operator()(_Args&&...)): Use latter to guard allocated node         pointer while constructing in place the value_type instance. Tested under Linux x64, ok to commit ? François --------------fJT27PY0sYBs1qKkFmGhC1DV Content-Type: text/plain; charset=UTF-8; name="raii_reuse_alloc_nodeptr.txt" Content-Disposition: attachment; filename="raii_reuse_alloc_nodeptr.txt" Content-Transfer-Encoding: base64 ZGlmZiAtLWdpdCBhL2xpYnN0ZGMrKy12My9pbmNsdWRlL2JpdHMvaGFzaHRhYmxlX3BvbGlj eS5oIGIvbGlic3RkYysrLXYzL2luY2x1ZGUvYml0cy9oYXNodGFibGVfcG9saWN5LmgKaW5k ZXggY2Q4OTQzZDhkMDUuLmM2N2VlYmQzYjJiIDEwMDY0NAotLS0gYS9saWJzdGRjKystdjMv aW5jbHVkZS9iaXRzL2hhc2h0YWJsZV9wb2xpY3kuaAorKysgYi9saWJzdGRjKystdjMvaW5j bHVkZS9iaXRzL2hhc2h0YWJsZV9wb2xpY3kuaApAQCAtMTczLDYgKzE3MywxOSBAQCBuYW1l c3BhY2UgX19kZXRhaWwKIAl7IHJldHVybiBfX25vZGVfZ2VuKHN0ZDo6Zm9yd2FyZDxfS3Q+ KF9faykpOyB9CiAgICAgfTsKIAorICB0ZW1wbGF0ZTx0eXBlbmFtZSBfSGFzaHRhYmxlQWxs b2MsIHR5cGVuYW1lIF9Ob2RlUHRyPgorICAgIHN0cnVjdCBfTm9kZVB0ckd1YXJkCisgICAg eworICAgICAgX0hhc2h0YWJsZUFsbG9jJiBfTV9oOworICAgICAgX05vZGVQdHIgX01fcHRy OworCisgICAgICB+X05vZGVQdHJHdWFyZCgpCisgICAgICB7CisJaWYgKF9NX3B0cikKKwkg IF9NX2guX01fZGVhbGxvY2F0ZV9ub2RlX3B0cihfTV9wdHIpOworICAgICAgfQorICAgIH07 CisKICAgdGVtcGxhdGU8dHlwZW5hbWUgX05vZGVBbGxvYz4KICAgICBzdHJ1Y3QgX0hhc2h0 YWJsZV9hbGxvYzsKIApAQCAtMjAxLDI3ICsyMTQsMjAgQEAgbmFtZXNwYWNlIF9fZGV0YWls CiAJX19ub2RlX3B0cgogCW9wZXJhdG9yKCkoX0FyZ3MmJi4uLiBfX2FyZ3MpIGNvbnN0CiAJ ewotCSAgaWYgKF9NX25vZGVzKQotCSAgICB7CisJICBpZiAoIV9NX25vZGVzKQorCSAgICBy ZXR1cm4gX01faC5fTV9hbGxvY2F0ZV9ub2RlKHN0ZDo6Zm9yd2FyZDxfQXJncz4oX19hcmdz KS4uLik7CisKIAkgIF9fbm9kZV9wdHIgX19ub2RlID0gX01fbm9kZXM7CiAJICBfTV9ub2Rl cyA9IF9NX25vZGVzLT5fTV9uZXh0KCk7CiAJICBfX25vZGUtPl9NX254dCA9IG51bGxwdHI7 CiAJICBhdXRvJiBfX2EgPSBfTV9oLl9NX25vZGVfYWxsb2NhdG9yKCk7CiAJICBfX25vZGVf YWxsb2NfdHJhaXRzOjpkZXN0cm95KF9fYSwgX19ub2RlLT5fTV92YWxwdHIoKSk7Ci0JICAg ICAgX190cnkKLQkJeworCSAgX05vZGVQdHJHdWFyZDxfX2hhc2h0YWJsZV9hbGxvYywgX19u b2RlX3B0cj4gX19ndWFyZCB7IF9NX2gsIF9fbm9kZSB9OwogCSAgX19ub2RlX2FsbG9jX3Ry YWl0czo6Y29uc3RydWN0KF9fYSwgX19ub2RlLT5fTV92YWxwdHIoKSwKIAkJCQkJIHN0ZDo6 Zm9yd2FyZDxfQXJncz4oX19hcmdzKS4uLik7Ci0JCX0KLQkgICAgICBfX2NhdGNoKC4uLikK LQkJewotCQkgIF9NX2guX01fZGVhbGxvY2F0ZV9ub2RlX3B0cihfX25vZGUpOwotCQkgIF9f dGhyb3dfZXhjZXB0aW9uX2FnYWluOwotCQl9CisJICBfX2d1YXJkLl9NX3B0ciA9IG51bGxw dHI7CiAJICByZXR1cm4gX19ub2RlOwogCX0KLQkgIHJldHVybiBfTV9oLl9NX2FsbG9jYXRl X25vZGUoc3RkOjpmb3J3YXJkPF9BcmdzPihfX2FyZ3MpLi4uKTsKLQl9CiAKICAgICBwcml2 YXRlOgogICAgICAgbXV0YWJsZSBfX25vZGVfcHRyIF9NX25vZGVzOwo= --------------fJT27PY0sYBs1qKkFmGhC1DV--