From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by sourceware.org (Postfix) with ESMTPS id 0ED493870899 for ; Mon, 17 Jun 2024 15:06:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0ED493870899 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linux.ibm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 0ED493870899 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=148.163.158.5 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1718636800; cv=none; b=FcCF0/l/J/kBvI+0FCxf6t1nbvJCRlJOV8eNhLgLPMBZOley9eiSoAxmMDs5pOUMQu55UsKxPXpmKQbqueJJtlwEXk376awfJHS7A+1r4zwk24ER8Cahu08MBovMN6vql4JlhNcV3FG/UXXN4PZtukw8qBR2aq+5FTP6tJIFCnc= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1718636800; c=relaxed/simple; bh=GgL/umz9maCsP0dlQhHYBj3vklROQFcZgEDtemMMnfg=; h=DKIM-Signature:Message-ID:Date:Subject:From:To:MIME-Version; b=oBDFdo23yeUxJIjBckYPpIJSaVouAAPXlWsa6GaZVcNeADBEDShc2kYhtGn/xaM1V7BAq+x3bybd4xE32Li8dXBnaFrXJYGZdlTFpZBdBFk+m7qYDGGZ8knFkZqiqj6s3Do2VqAgsFmwYzjDvyaKqG3xnM4vI+tvRuss4JPA9hU= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from pps.filterd (m0353724.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 45H3Si1f024248; Mon, 17 Jun 2024 05:27:16 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h= message-id:date:subject:from:to:cc:references:in-reply-to :content-type:content-transfer-encoding:mime-version; s=pp1; bh= WWVggYXPCgoZmYoxIrRyKCKBLnQyXItCvomIR1T3y2U=; b=N5WFEmDrbp8TlPJE O6qERiFELJpqwQuNyguQCwMIN5+ts1YpSekgPi/GYDLc1Nj3KyzIcplMfivPjZUb 4g8O8ooFrneLcCXtW6ztId9OOWD97HV9aOsqjGIfFIxj2OnR+91zg7PUADvuDAwC Lu/+VtuISzjAjwyWgqKxwnF/pEE2z2mbWKXS+3u/mFQQNFCpRQEUR5RB+hbm1nOO JoWiF5fT7WSPyzMeV9jCmpW/3u1iO1VcT4foraei+7G6NvDY7bb/nFs+ZeEcPiOa RHG7UrwouN9jkOP60qOFPs7TU4KH+Sow8kp1qELd9s3q4SaEoFw/WDW84bEd6Ifo OH2vgw== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3ytd96r646-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 17 Jun 2024 05:27:15 +0000 (GMT) Received: from m0353724.ppops.net (m0353724.ppops.net [127.0.0.1]) by pps.reinject (8.18.0.8/8.18.0.8) with ESMTP id 45H5RFEE026913; Mon, 17 Jun 2024 05:27:15 GMT Received: from ppma11.dal12v.mail.ibm.com (db.9e.1632.ip4.static.sl-reverse.com [50.22.158.219]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3ytd96r641-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 17 Jun 2024 05:27:15 +0000 (GMT) Received: from pps.filterd (ppma11.dal12v.mail.ibm.com [127.0.0.1]) by ppma11.dal12v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 45H3YmVq013440; Mon, 17 Jun 2024 05:22:59 GMT Received: from smtprelay06.fra02v.mail.ibm.com ([9.218.2.230]) by ppma11.dal12v.mail.ibm.com (PPS) with ESMTPS id 3ysr036nta-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 17 Jun 2024 05:22:59 +0000 Received: from smtpav03.fra02v.mail.ibm.com (smtpav03.fra02v.mail.ibm.com [10.20.54.102]) by smtprelay06.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 45H5MsTg14811558 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 17 Jun 2024 05:22:56 GMT Received: from smtpav03.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 2700F20043; Mon, 17 Jun 2024 05:22:54 +0000 (GMT) Received: from smtpav03.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 5384E20040; Mon, 17 Jun 2024 05:22:52 +0000 (GMT) Received: from [9.200.54.154] (unknown [9.200.54.154]) by smtpav03.fra02v.mail.ibm.com (Postfix) with ESMTP; Mon, 17 Jun 2024 05:22:52 +0000 (GMT) Message-ID: Date: Mon, 17 Jun 2024 13:22:50 +0800 User-Agent: Mozilla Thunderbird Subject: Ping^2 [PATCH-1v3, rs6000] Implement optab_isinf for SFDF and IEEE128 From: HAO CHEN GUI To: gcc-patches Cc: Segher Boessenkool , David , "Kewen.Lin" , Peter Bergner References: <422aad71-d86a-46a9-bbbd-cb1af581cd1f@linux.ibm.com> Content-Language: en-US In-Reply-To: <422aad71-d86a-46a9-bbbd-cb1af581cd1f@linux.ibm.com> Content-Type: text/plain; charset=UTF-8 X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: w47UX1FyU8kHMdyd3UwLjXu38J0nR7Op X-Proofpoint-GUID: WJPseSSKPmU-q6WunWv1SSRDPMx_JbkV Content-Transfer-Encoding: 8bit X-Proofpoint-UnRewURL: 0 URL was un-rewritten MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.28.16 definitions=2024-06-17_04,2024-06-14_03,2024-05-17_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 spamscore=0 lowpriorityscore=0 priorityscore=1501 malwarescore=0 mlxscore=0 clxscore=1015 phishscore=0 adultscore=0 mlxlogscore=999 suspectscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2405170001 definitions=main-2406170039 X-Spam-Status: No, score=-12.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,GIT_PATCH_0,KAM_NUMSUBJECT,KAM_SHORT,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi, Gently ping the series of patches. [PATCH-1v3, rs6000] Implement optab_isinf for SFDF and IEEE128 https://gcc.gnu.org/pipermail/gcc-patches/2024-May/652593.html [PATCH-2v3, rs6000] Implement optab_isfinite for SFDF and IEEE128 https://gcc.gnu.org/pipermail/gcc-patches/2024-May/652594.html [PATCH-3v3, rs6000] Implement optab_isnormal for SFDF and IEEE128 https://gcc.gnu.org/pipermail/gcc-patches/2024-May/652595.html Thanks Gui Haochen 在 2024/6/3 10:40, HAO CHEN GUI 写道: > Hi, > Gently ping the series of patches. > [PATCH-1v3, rs6000] Implement optab_isinf for SFDF and IEEE128 > https://gcc.gnu.org/pipermail/gcc-patches/2024-May/652593.html > [PATCH-2v3, rs6000] Implement optab_isfinite for SFDF and IEEE128 > https://gcc.gnu.org/pipermail/gcc-patches/2024-May/652594.html > [PATCH-3v3, rs6000] Implement optab_isnormal for SFDF and IEEE128 > https://gcc.gnu.org/pipermail/gcc-patches/2024-May/652595.html > > Thanks > Gui Haochen > > 在 2024/5/24 14:02, HAO CHEN GUI 写道: >> Hi, >> This patch implemented optab_isinf for SFDF and IEEE128 by test >> data class instructions. >> >> Compared with previous version, the main change is to narrow >> down the predict for float operand according to review's advice. >> https://gcc.gnu.org/pipermail/gcc-patches/2024-May/652128.html >> >> Bootstrapped and tested on powerpc64-linux BE and LE with no >> regressions. Is it OK for trunk? >> >> Thanks >> Gui Haochen >> >> ChangeLog >> rs6000: Implement optab_isinf for SFDF and IEEE128 >> >> gcc/ >> PR target/97786 >> * config/rs6000/vsx.md (isinf2 for SFDF): New expand. >> (isinf2 for IEEE128): New expand. >> >> gcc/testsuite/ >> PR target/97786 >> * gcc.target/powerpc/pr97786-1.c: New test. >> * gcc.target/powerpc/pr97786-2.c: New test. >> >> patch.diff >> diff --git a/gcc/config/rs6000/vsx.md b/gcc/config/rs6000/vsx.md >> index f135fa079bd..08cce11da60 100644 >> --- a/gcc/config/rs6000/vsx.md >> +++ b/gcc/config/rs6000/vsx.md >> @@ -5313,6 +5313,24 @@ (define_expand "xststdcp" >> operands[4] = CONST0_RTX (SImode); >> }) >> >> +(define_expand "isinf2" >> + [(use (match_operand:SI 0 "gpc_reg_operand")) >> + (use (match_operand:SFDF 1 "vsx_register_operand"))] >> + "TARGET_HARD_FLOAT && TARGET_P9_VECTOR" >> +{ >> + emit_insn (gen_xststdcp (operands[0], operands[1], GEN_INT (0x30))); >> + DONE; >> +}) >> + >> +(define_expand "isinf2" >> + [(use (match_operand:SI 0 "gpc_reg_operand")) >> + (use (match_operand:IEEE128 1 "vsx_register_operand"))] >> + "TARGET_HARD_FLOAT && TARGET_P9_VECTOR" >> +{ >> + emit_insn (gen_xststdcqp_ (operands[0], operands[1], GEN_INT (0x30))); >> + DONE; >> +}) >> + >> ;; The VSX Scalar Test Negative Quad-Precision >> (define_expand "xststdcnegqp_" >> [(set (match_dup 2) >> diff --git a/gcc/testsuite/gcc.target/powerpc/pr97786-1.c b/gcc/testsuite/gcc.target/powerpc/pr97786-1.c >> new file mode 100644 >> index 00000000000..c1c4f64ee8b >> --- /dev/null >> +++ b/gcc/testsuite/gcc.target/powerpc/pr97786-1.c >> @@ -0,0 +1,22 @@ >> +/* { dg-do compile } */ >> +/* { dg-require-effective-target powerpc_vsx } */ >> +/* { dg-options "-O2 -mdejagnu-cpu=power9" } */ >> + >> +int test1 (double x) >> +{ >> + return __builtin_isinf (x); >> +} >> + >> +int test2 (float x) >> +{ >> + return __builtin_isinf (x); >> +} >> + >> +int test3 (float x) >> +{ >> + return __builtin_isinff (x); >> +} >> + >> +/* { dg-final { scan-assembler-not {\mfcmp} } } */ >> +/* { dg-final { scan-assembler-times {\mxststdcsp\M} 2 } } */ >> +/* { dg-final { scan-assembler-times {\mxststdcdp\M} 1 } } */ >> diff --git a/gcc/testsuite/gcc.target/powerpc/pr97786-2.c b/gcc/testsuite/gcc.target/powerpc/pr97786-2.c >> new file mode 100644 >> index 00000000000..ed305e8572e >> --- /dev/null >> +++ b/gcc/testsuite/gcc.target/powerpc/pr97786-2.c >> @@ -0,0 +1,17 @@ >> +/* { dg-do compile } */ >> +/* { dg-require-effective-target ppc_float128_hw } */ >> +/* { dg-require-effective-target powerpc_vsx } */ >> +/* { dg-options "-O2 -mdejagnu-cpu=power9 -mabi=ieeelongdouble -Wno-psabi" } */ >> + >> +int test1 (long double x) >> +{ >> + return __builtin_isinf (x); >> +} >> + >> +int test2 (long double x) >> +{ >> + return __builtin_isinfl (x); >> +} >> + >> +/* { dg-final { scan-assembler-not {\mxscmpuqp\M} } } */ >> +/* { dg-final { scan-assembler-times {\mxststdcqp\M} 2 } } */