From: Tobias Burnus <tburnus@baylibre.com>
To: gcc-patches <gcc-patches@gcc.gnu.org>, Andrew Stubbs <ams@baylibre.com>
Subject: [patch] gcn: Add missing space to ASM_SPEC in gcn-hsa.h
Date: Thu, 25 Jan 2024 13:44:44 +0100 [thread overview]
Message-ID: <fbdec1fa-ae2a-4f14-b83b-9729ad71831e@baylibre.com> (raw)
[-- Attachment #1.1: Type: text/plain, Size: 303 bytes --]
This patch avoids assembler warnings for gfx908 and gfx90a such as
'-xnack-mattr=-sramecc' is not a recognized feature for this target(ignoring feature)
as we pass -mattr=-xnack-mattr=-sramecc to the llvm-mc assembler.
Solution: Add a space before the second '-mattr='.
OK for mainline?
Tobias
[-- Attachment #2: fix-gcn-hsa.diff --]
[-- Type: text/x-patch, Size: 702 bytes --]
gcn: Add missing space to ASM_SPEC in gcn-hsa.h
gcc/
* config/gcn/gcn-hsa.h (ASM_SPEC): Add space after -mxnack= argument.
diff --git a/gcc/config/gcn/gcn-hsa.h b/gcc/config/gcn/gcn-hsa.h
index bf7079fbbc6..f5de0d2969f 100644
--- a/gcc/config/gcn/gcn-hsa.h
+++ b/gcc/config/gcn/gcn-hsa.h
@@ -89,7 +89,7 @@ extern unsigned int gcn_local_sym_hash (const char *name);
#define ASM_SPEC "-triple=amdgcn--amdhsa " \
"%{march=*:-mcpu=%*} " \
"%{!march=*|march=fiji:--amdhsa-code-object-version=3} " \
- "%{" NO_XNACK XNACKOPT "}" \
+ "%{" NO_XNACK XNACKOPT "} " \
"%{" NO_SRAM_ECC SRAMOPT "} " \
"%{march=gfx1030|march=gfx1100:-mattr=+wavefrontsize64} " \
"-filetype=obj"
next reply other threads:[~2024-01-25 12:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-25 12:44 Tobias Burnus [this message]
2024-01-25 14:34 ` Andrew Stubbs
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fbdec1fa-ae2a-4f14-b83b-9729ad71831e@baylibre.com \
--to=tburnus@baylibre.com \
--cc=ams@baylibre.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).