From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 78488 invoked by alias); 6 Feb 2018 19:16:11 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 78424 invoked by uid 89); 6 Feb 2018 19:16:10 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=HTo:U*jwakely, HContent-Transfer-Encoding:8bit, day X-Spam-User: qpsmtpd, 2 recipients X-HELO: mail-wr0-f176.google.com Received: from mail-wr0-f176.google.com (HELO mail-wr0-f176.google.com) (209.85.128.176) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 06 Feb 2018 19:16:09 +0000 Received: by mail-wr0-f176.google.com with SMTP id s5so3140360wra.0; Tue, 06 Feb 2018 11:16:09 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=QKLYVifYAzlbKuIwcJKj1Reb3D4ubt7oolNfw+/oftA=; b=QiuYmhZzUdIYyI53Qb/DsE/zA/g1VBwmkixkmtz6pfyRt5AL4ybWc8/VZ51gBWIv3O 2fF7hzsXe+WTA03KejuM1avbSNstPXje6ATGG1Q7GWUS+q+kY2LXwwmEd0WI7qx5bTkw Tic41yNLRCsm+ibrA11mFwrbBBrW/Ud99k7Prow3h5oITyucNtRjekovqOnckae9fpmN 1AcxoVhD6d5yNv+QBw9MSp8IjOwllmZIX17uvIpFidqfXRtLGzMPAFrjqt4FpD1NlUzd UgciAjz4grqT8ZuLMpTBevA3kcekuW/x4z8EfQ5eI8MRjylJ7UocH+8r8+doMW2nxWHm m5wA== X-Gm-Message-State: APf1xPBet1GuOKp+Ry2XukKaNEORej3vq599FF/X37LLBBlHQAbq8ShX PnooXfj3DkN35hvi5kfyvGyYyg== X-Google-Smtp-Source: AH8x224WGgwS/iR3SZVDPlPvkkO+t0EIwOmrZOMA/jYBz5g5zxcYlzN4XXWDaSGS5hvQeSEr5wlJPw== X-Received: by 10.223.186.3 with SMTP id o3mr3092735wrg.237.1517944567292; Tue, 06 Feb 2018 11:16:07 -0800 (PST) Received: from [192.168.0.23] (arf62-1-82-237-250-248.fbx.proxad.net. [82.237.250.248]) by smtp.googlemail.com with ESMTPSA id 14sm15102434wry.95.2018.02.06.11.16.06 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 06 Feb 2018 11:16:06 -0800 (PST) Subject: Re: Extend aligned_membuf<> usage To: Jonathan Wakely Cc: "libstdc++@gcc.gnu.org" , gcc-patches References: <20180205171622.GG13489@redhat.com> From: =?UTF-8?Q?Fran=c3=a7ois_Dumont?= Message-ID: Date: Tue, 06 Feb 2018 19:16:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <20180205171622.GG13489@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-SW-Source: 2018-02/txt/msg00268.txt.bz2 On 05/02/2018 18:16, Jonathan Wakely wrote: > On 01/02/18 22:48 +0100, François Dumont wrote: >> Hi >> >>     As we just bump version namespace it might be interesting to do >> the following change now. What do you think ? > > I'd rather not make the code harder to read in all those places just > for an optional mode that nobody uses. > I just consider this mode as a nice way to track all abi changes that we will be able to commit one day when we decide an abi breaking change. > Wouldn't it make more sense to simply make __aligned_buffer identical > to __aligned_membuf for the versioned-namespace? Then at least the > conditional code is only in one place. > Yes, __aligned_buffer is indeed not used, we could do that. I'll propose a patch to do so.