From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 46D89384F019 for ; Mon, 13 Jun 2022 18:26:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 46D89384F019 Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-9-CWvMsWPGOy6Eu0Qj-oswDg-1; Mon, 13 Jun 2022 14:26:48 -0400 X-MC-Unique: CWvMsWPGOy6Eu0Qj-oswDg-1 Received: by mail-qk1-f199.google.com with SMTP id o10-20020a05620a2a0a00b006a77a64cd23so4483619qkp.21 for ; Mon, 13 Jun 2022 11:26:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:subject:from:to:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=5JorgVEFz2Ex83pFvhFY4OUkcY4sgA9Hp6eviJwCuaE=; b=ZT8YvOH6s8Z5A/Th8jc2wGgV7uZcyjRYxpwuopzDqu5g4bBR7reJgkYlpYK+yElQiK KuS72xQPN5n2Cy8+BinWyDZFOrRh/R9+rDcp6vaJc8dYfQzWWVmsDJXu1u3vgevrUOnL DSjUsTE33Mxfp/RJi/w9Nl2TpaCNJvydAghVFuGGqb6nOQHFUkk378xZ2XS1/HWzJhJI cLLzH8scdoWcbKXgJZ6HnnZwYGxX1js46hAtVX8nPAgAYxfFAFhpEw4n5E7RiPXBciIp WOn7jJbm0CsJ17GPg05KWrQvjTPdKy08dVRkllZvaxiPAxaLK+sLXC28gaLNn/Eh+J0I SWwA== X-Gm-Message-State: AJIora+beklNW8+Ct7DozzAx0XY8dRY9CU85Qze4kcOx2zzZ2mKG04Dc wPQuHlD/7BxTDQydOi/Fy4BGLZ9yKOTY7L/DbU+fh0ywc6xrdQnYws5ygN6QwpjV3Tkq+5LGWbb JnlM/dGvfL/1kimvKq3eOSXqNcx2z/f3qhffSxNaeEADHcJaBWnOobYQdIr22n4AqR5C/2w== X-Received: by 2002:ad4:596f:0:b0:467:d3ad:b582 with SMTP id eq15-20020ad4596f000000b00467d3adb582mr326758qvb.113.1655144807762; Mon, 13 Jun 2022 11:26:47 -0700 (PDT) X-Google-Smtp-Source: AGRyM1uPMthwhng/hYQ2S+mwycyrM0m+hIYLmhIJZ9c81GYjs62zBgb0Lnc+scS/gwknzhaxJtMYwQ== X-Received: by 2002:ad4:596f:0:b0:467:d3ad:b582 with SMTP id eq15-20020ad4596f000000b00467d3adb582mr326738qvb.113.1655144807360; Mon, 13 Jun 2022 11:26:47 -0700 (PDT) Received: from t14s.localdomain (c-73-69-212-193.hsd1.ma.comcast.net. [73.69.212.193]) by smtp.gmail.com with ESMTPSA id n1-20020a05620a294100b006a6b6638a59sm7184356qkp.53.2022.06.13.11.26.46 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Jun 2022 11:26:46 -0700 (PDT) Message-ID: Subject: PING Re: [PATCH 04/10] tree-switch-conversion.h: use final/override for cluster vfunc impls From: David Malcolm To: gcc-patches@gcc.gnu.org Date: Mon, 13 Jun 2022 14:26:45 -0400 In-Reply-To: <20220523192834.3785673-5-dmalcolm@redhat.com> References: <20220523192834.3785673-1-dmalcolm@redhat.com> <20220523192834.3785673-5-dmalcolm@redhat.com> User-Agent: Evolution 3.38.4 (3.38.4-1.fc33) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-10.8 required=5.0 tests=BAYES_00, BODY_8BITS, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Jun 2022 18:26:51 -0000 Ping for this patch: https://gcc.gnu.org/pipermail/gcc-patches/2022-May/595435.html OK for trunk? Thanks Dave On Mon, 2022-05-23 at 15:28 -0400, David Malcolm wrote: > gcc/ChangeLog: >         * tree-switch-conversion.h: Add "final" and "override" to > cluster >         vfunc implementations as appropriate. > > Signed-off-by: David Malcolm > --- >  gcc/tree-switch-conversion.h | 32 +++++++++++++++++--------------- >  1 file changed, 17 insertions(+), 15 deletions(-) > > diff --git a/gcc/tree-switch-conversion.h b/gcc/tree-switch- > conversion.h > index 2b677d9f7e9..d22515eb296 100644 > --- a/gcc/tree-switch-conversion.h > +++ b/gcc/tree-switch-conversion.h > @@ -130,19 +130,19 @@ public: >    {} >   >    cluster_type > -  get_type () > +  get_type () final override >    { >      return SIMPLE_CASE; >    } >   >    tree > -  get_low () > +  get_low () final override >    { >      return m_low; >    } >   >    tree > -  get_high () > +  get_high () final override >    { >      return m_high; >    } > @@ -153,13 +153,13 @@ public: >    } >   >    void > -  debug () > +  debug () final override >    { >      dump (stderr); >    } >   >    void > -  dump (FILE *f, bool details ATTRIBUTE_UNUSED = false) > +  dump (FILE *f, bool details ATTRIBUTE_UNUSED = false) final override >    { >      PRINT_CASE (f, get_low ()); >      if (get_low () != get_high ()) > @@ -170,12 +170,12 @@ public: >      fprintf (f, " "); >    } >   > -  void emit (tree, tree, tree, basic_block, location_t) > +  void emit (tree, tree, tree, basic_block, location_t) final override >    { >      gcc_unreachable (); >    } >   > -  bool is_single_value_p () > +  bool is_single_value_p () final override >    { >      return tree_int_cst_equal (get_low (), get_high ()); >    } > @@ -224,24 +224,24 @@ public: >    ~group_cluster (); >   >    tree > -  get_low () > +  get_low () final override >    { >      return m_cases[0]->get_low (); >    } >   >    tree > -  get_high () > +  get_high () final override >    { >      return m_cases[m_cases.length () - 1]->get_high (); >    } >   >    void > -  debug () > +  debug () final override >    { >      dump (stderr); >    } >   > -  void dump (FILE *f, bool details = false); > +  void dump (FILE *f, bool details = false) final override; >   >    /* List of simple clusters handled by the group.  */ >    vec m_cases; > @@ -261,13 +261,14 @@ public: >    {} >   >    cluster_type > -  get_type () > +  get_type () final override >    { >      return JUMP_TABLE; >    } >   >    void emit (tree index_expr, tree index_type, > -            tree default_label_expr, basic_block default_bb, > location_t loc); > +            tree default_label_expr, basic_block default_bb, > location_t loc) > +    final override; >   >    /* Find jump tables of given CLUSTERS, where all members of the > vector >       are of type simple_cluster.  New clusters are returned.  */ > @@ -366,7 +367,7 @@ public: >    {} >   >    cluster_type > -  get_type () > +  get_type () final override >    { >      return BIT_TEST; >    } > @@ -388,7 +389,8 @@ public: >      There *MUST* be max_case_bit_tests or less unique case >      node targets.  */ >    void emit (tree index_expr, tree index_type, > -            tree default_label_expr, basic_block default_bb, > location_t loc); > +            tree default_label_expr, basic_block default_bb, > location_t loc) > +     final override; >   >    /* Find bit tests of given CLUSTERS, where all members of the vector >       are of type simple_cluster.  New clusters are returned.  */