From: Patrick O'Neill <patrick@rivosinc.com>
To: Jeff Law <jeffreyalaw@gmail.com>, gcc-patches@gcc.gnu.org
Cc: gnu-toolchain@rivosinc.com
Subject: [Committed] g++: Rely on dg-do-what-default to avoid running pr102788.cc on non-vector targets
Date: Fri, 10 Nov 2023 11:21:27 -0800 [thread overview]
Message-ID: <fc1b0373-630c-463a-a471-2bdd11d8fee0@rivosinc.com> (raw)
In-Reply-To: <974e9e5e-8f07-46dd-b9b9-db8aa46859b5@gmail.com>
On 11/9/23 17:20, Jeff Law wrote:
>
>
> On 11/2/23 17:45, Patrick O'Neill wrote:
>> Testcases in g++.dg/vect rely on check_vect_support_and_set_flags
>> to set dg-do-what-default and avoid running vector tests on non-vector
>> targets. The three testcases in this patch overwrite the default with
>> dg-do run.
>>
>> Removing the dg-do run directive resolves this issue for non-vector
>> targets (while still running the tests on vector targets).
>>
>> gcc/testsuite/ChangeLog:
>>
>> * g++.dg/vect/pr102788.cc: Remove dg-do run directive.
> OK. I'll note your patch has just one file patched, but your comment
> indicates three testcases have this problem. Did you forget to
> include a couple changes?
>
> If so, those are pre-approved as well. Just post them for the
> archiver and commit.
>
> Thanks,
> jeff
Committed
The comment was mistakenly copy/pasted from
https://inbox.sourceware.org/gcc-patches/20231102190911.66763-1-patrick@rivosinc.com/T/#u
Revised commit message to only mention the one testcase.
Thanks,
Patrick
prev parent reply other threads:[~2023-11-10 19:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-02 23:45 [PATCH] " Patrick O'Neill
2023-11-10 1:20 ` Jeff Law
2023-11-10 19:21 ` Patrick O'Neill [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fc1b0373-630c-463a-a471-2bdd11d8fee0@rivosinc.com \
--to=patrick@rivosinc.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=gnu-toolchain@rivosinc.com \
--cc=jeffreyalaw@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).