From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-x435.google.com (mail-pf1-x435.google.com [IPv6:2607:f8b0:4864:20::435]) by sourceware.org (Postfix) with ESMTPS id 4527F3858D32 for ; Fri, 10 Nov 2023 19:21:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 4527F3858D32 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=rivosinc.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=rivosinc.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 4527F3858D32 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::435 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699644095; cv=none; b=wibHXrp/uZ4JhOqCLjiBONLFNjCIlPx0eshCoHMvoUF1cVjd6pldRJ43l9gCjfyuJ+nxxpmMQ9pUrLkpj2aQfsBPYmFA4wBMoWobCLvQjdOThi9mXZFCN1BMOaPHINl7d0TkhERjnj64esJfor/L4wQRTmgGndlAKJYQu8BF/Kc= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699644095; c=relaxed/simple; bh=+5TLqSB7W8WPB7Hb6QdcMyAqEKs+2JYwjIAyrlUPTfc=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=HoehXjV+966AJgEppV17xSxAY54Kmzkvkj3nI8pf/Cdu5YMgjkMnTNx3ykHdUFY6Mh5g16Edhol4VtPrF9qgjp7jIXSR/5PcxGWe65+Y2DO9r4iPL+KQKJIGqBSmjtPAZAsAieIro3DLqUSPmzeZ+u7O6qFW87oNgnwevihGbpc= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pf1-x435.google.com with SMTP id d2e1a72fcca58-6bee11456baso2200029b3a.1 for ; Fri, 10 Nov 2023 11:21:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20230601.gappssmtp.com; s=20230601; t=1699644090; x=1700248890; darn=gcc.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=BYotnBOXPZtdH/zYb3SGGoxH4y5KLevDQHrm76aBjqY=; b=nrOdS3haflxiY1nJCb+Zh0WoCYc+8YK3KZ+tMFwRpz0+AdxskCTmMzsgh53g7Lf22u 7f1XcaDGJrgB4iqQZZoiJiDawg8t6SWKI/QYGVxR9dsgSFYTN38yI1NtNl2kyxU1PrtN barpe5us3OYGzRHs6rQyL9Ikq6yf8ThOcVyiSPsnVbxgrk6uh6xmRUFW3b9LOBISUK/8 T4B368jRM0tzZEPFCnR0k/lGxjxK77cJDnmVryqUts+vivCMe6IqPCwggwK+JKpw1vYK 0aVEtkir8VsTUT3sR7n4AvAczcu6qjjw5EWbJkyr/5NcutX7jDOZLnWj3myCYAKDyOxM WEyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699644090; x=1700248890; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=BYotnBOXPZtdH/zYb3SGGoxH4y5KLevDQHrm76aBjqY=; b=veyQCyJKaN5PMDBoFESfi2RylIYW5h0vDwgPqhoUtJMl2NKN1KIMU9zQBVsQjZkG4u uRXOemq0yvEHKhoD42GhlaAq+wkrwaFyGsoKlcNYFZRxcDFdOhzBv3soNp4QXvVmmUfC 1EhFP2lohUzCy6Ehk28+eyNTRU3QFNfwD0Lw7ivIvAGRNqv91HSX4J26IkGZu+RHbPPm vjU3HPUFdCKrk3+gyz0QHE46ntTEnRKI3vjPi89jARBYcK2WaDFgqMBxnUwpBIPjP3CY Xjx2lbAMbuy2XbR9CBM+ErXtp38Kim2b3pWbgcgvjTqa3cjIYBnH/KvD8qjgxZD3d+1q 1k9Q== X-Gm-Message-State: AOJu0YwCb6CbXkm5/zjNH2xNZQp8fEXzS4MDDQcVln1ByGx+gdJStrTz t9bZx4YBIMgiR8akICeTrWmFCg== X-Google-Smtp-Source: AGHT+IE8KIzgWiAjnjXfV1jOtVuzAtlJH3F7vc9XIcx0+9zRiyrDZa+LV921acawIWcV2Hdvi+HozA== X-Received: by 2002:a05:6a20:4420:b0:13a:e955:d958 with SMTP id ce32-20020a056a20442000b0013ae955d958mr58290pzb.7.1699644089895; Fri, 10 Nov 2023 11:21:29 -0800 (PST) Received: from [10.0.17.156] ([12.44.203.122]) by smtp.gmail.com with ESMTPSA id t8-20020a62ea08000000b006c4d1bb81d6sm53926pfh.67.2023.11.10.11.21.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 10 Nov 2023 11:21:29 -0800 (PST) Message-ID: Date: Fri, 10 Nov 2023 11:21:27 -0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [Committed] g++: Rely on dg-do-what-default to avoid running pr102788.cc on non-vector targets Content-Language: en-US To: Jeff Law , gcc-patches@gcc.gnu.org Cc: gnu-toolchain@rivosinc.com References: <20231102234527.77231-1-patrick@rivosinc.com> <974e9e5e-8f07-46dd-b9b9-db8aa46859b5@gmail.com> From: Patrick O'Neill In-Reply-To: <974e9e5e-8f07-46dd-b9b9-db8aa46859b5@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-3.8 required=5.0 tests=BAYES_00,BODY_8BITS,DKIM_SIGNED,DKIM_VALID,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 11/9/23 17:20, Jeff Law wrote: > > > On 11/2/23 17:45, Patrick O'Neill wrote: >> Testcases in g++.dg/vect rely on check_vect_support_and_set_flags >> to set dg-do-what-default and avoid running vector tests on non-vector >> targets. The three testcases in this patch overwrite the default with >> dg-do run. >> >> Removing the dg-do run directive resolves this issue for non-vector >> targets (while still running the tests on vector targets). >> >> gcc/testsuite/ChangeLog: >> >>     * g++.dg/vect/pr102788.cc: Remove dg-do run directive. > OK.  I'll note your patch has just one file patched, but your comment > indicates three testcases have this problem.  Did you forget to > include a couple changes? > > If so, those are pre-approved as well.  Just post them for the > archiver and commit. > > Thanks, > jeff Committed The comment was mistakenly copy/pasted from https://inbox.sourceware.org/gcc-patches/20231102190911.66763-1-patrick@rivosinc.com/T/#u Revised commit message to only mention the one testcase. Thanks, Patrick