From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by sourceware.org (Postfix) with ESMTPS id 652AB3858D1E for ; Sun, 8 Oct 2023 18:09:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 652AB3858D1E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux.vnet.ibm.com Authentication-Results: sourceware.org; spf=none smtp.mailfrom=linux.vnet.ibm.com Received: from pps.filterd (m0353724.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 398Hodh6013788; Sun, 8 Oct 2023 18:09:26 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=24vKVJgNY47KTABsAfOLyKGqWEnktX2P9LdEUeQ0CVc=; b=TtUKylYB3i/2rO6sc4PuUNXsibINfdh08cbiqgJ3wiB3Qtxxkhs//fkQZk/DZ8IyT5AT ajvQZiaILdNZgE6EVcHvnjEp2twlys9bhQoNnMK3sMDYcJRotXFu9IVMBhILJoL/M4uy DNoIqaOfyNJd62Tz8btvojsq2N10qAvW5RBiXzY1ddHaT7cXx1gsY7OTo699YNiI0TNs znDzn5dQ9qOX5f1ERu6Vvr43yNMFGQNJiFvfOlhEH3CVP0obBsAzgCA3NgvT/M+zdYck Oms/bZxsOFjo1SsBW8fvF+/4b/C158G50Oar8E/QBNK9ESf+QLU7FKT4MPTkZZSZAyAy 2w== Received: from ppma23.wdc07v.mail.ibm.com (5d.69.3da9.ip4.static.sl-reverse.com [169.61.105.93]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3tm15tg6g3-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sun, 08 Oct 2023 18:09:26 +0000 Received: from pps.filterd (ppma23.wdc07v.mail.ibm.com [127.0.0.1]) by ppma23.wdc07v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 398G3svS000640; Sun, 8 Oct 2023 18:09:25 GMT Received: from smtprelay06.dal12v.mail.ibm.com ([172.16.1.8]) by ppma23.wdc07v.mail.ibm.com (PPS) with ESMTPS id 3tkk5k447d-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sun, 08 Oct 2023 18:09:25 +0000 Received: from smtpav04.wdc07v.mail.ibm.com (smtpav04.wdc07v.mail.ibm.com [10.39.53.231]) by smtprelay06.dal12v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 398I9OBm66519476 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sun, 8 Oct 2023 18:09:25 GMT Received: from smtpav04.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id ABF3F58056; Sun, 8 Oct 2023 18:09:24 +0000 (GMT) Received: from smtpav04.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 644B858045; Sun, 8 Oct 2023 18:09:23 +0000 (GMT) Received: from [9.43.77.147] (unknown [9.43.77.147]) by smtpav04.wdc07v.mail.ibm.com (Postfix) with ESMTP; Sun, 8 Oct 2023 18:09:23 +0000 (GMT) Message-ID: Date: Sun, 8 Oct 2023 23:39:21 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PING^1][PATCH] rs6000: Change bitwise xor to inequality operator [PR106907] Content-Language: en-US To: GCC Patches , Segher Boessenkool Cc: Peter Bergner References: <4586392d-ff8b-1c19-4af0-2a816fa63259@linux.ibm.com> From: jeevitha In-Reply-To: <4586392d-ff8b-1c19-4af0-2a816fa63259@linux.ibm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: UvSJIRS8vFLZ71zevS3aBFXa9ubfzEaV X-Proofpoint-ORIG-GUID: UvSJIRS8vFLZ71zevS3aBFXa9ubfzEaV X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.267,Aquarius:18.0.980,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-10-08_15,2023-10-06_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 lowpriorityscore=0 malwarescore=0 suspectscore=0 spamscore=0 bulkscore=0 adultscore=0 mlxscore=0 phishscore=0 clxscore=1011 priorityscore=1501 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2309180000 definitions=main-2310080165 X-Spam-Status: No, score=-5.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Ping! please review. Thanks & Regards Jeevitha On 16/06/23 9:55 am, Peter Bergner wrote: > On 6/12/23 6:18 AM, P Jeevitha wrote: >> Bitwise xor performed on bool >> is similar to checking inequality. So changed to inequality >> operator (!=) instead of bitwise xor (^). > [snip' >> - if (swapped ^ !BYTES_BIG_ENDIAN > [snip] >> + if (swapped != !BYTES_BIG_ENDIAN > > I know Andreas mentioned using "swapped != !BYTES_BIG_ENDIAN" in > the bugzilla, but that's the same as "swapped == BYTES_BIG_ENDIAN", > and it doesn't contain a double-negative and seems a little clearer. > > It's up to Segher though...and if we go with this, then the ChangeLog > entry needs to be updated slightly since we're no longer testing for > inequality. > > Peter >