From: "Steve Ellcey " <sellcey@mips.com>
To: <gcc-patches@gcc.gnu.org>
Subject: [Patch, PR 54128] ira.c change to fix mips bootstrap
Date: Fri, 31 Aug 2012 17:59:00 -0000 [thread overview]
Message-ID: <fc64c2a2-b90e-42d6-856e-11553133b099@EXCHHUB01.MIPS.com> (raw)
Here is my patch to fix the bootstrap comparision failure (PR 54128) on
MIPS. The reason for the comparision failure was a difference in
register usage and I tracked it down to build_insn_chain which checked
all instructions for register usage in order to set the dead_or_set
and live_relevant_regs bitmaps instead of checking only non-debug
instructions. Changing INSN_P to NONDEBUG_INSN_P in build_insn_chain
allowed me to bootstrap and caused no regressions.
OK to checkin?
Steve Ellcey
sellcey@mips.com
2012-08-31 Steve Ellcey <sellcey@mips.com>
PR bootstrap/54128
* ira.c (build_insn_chain): Check only NONDEBUG instructions for
register usage.
diff --git a/gcc/ira.c b/gcc/ira.c
index 3825498..477c87b 100644
--- a/gcc/ira.c
+++ b/gcc/ira.c
@@ -3341,7 +3341,7 @@ build_insn_chain (void)
c->insn = insn;
c->block = bb->index;
- if (INSN_P (insn))
+ if (NONDEBUG_INSN_P (insn))
for (def_rec = DF_INSN_UID_DEFS (uid); *def_rec; def_rec++)
{
df_ref def = *def_rec;
@@ -3432,7 +3432,7 @@ build_insn_chain (void)
bitmap_and_compl_into (live_relevant_regs, elim_regset);
bitmap_copy (&c->live_throughout, live_relevant_regs);
- if (INSN_P (insn))
+ if (NONDEBUG_INSN_P (insn))
for (use_rec = DF_INSN_UID_USES (uid); *use_rec; use_rec++)
{
df_ref use = *use_rec;
next reply other threads:[~2012-08-31 17:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-31 17:59 Steve Ellcey [this message]
2012-09-05 6:19 ` Jakub Jelinek
2012-09-05 22:47 ` Steve Ellcey
2012-09-07 21:50 ` Steve Ellcey
2012-09-08 13:01 ` Richard Sandiford
2012-12-21 7:46 ` Jakub Jelinek
2012-12-21 18:55 ` Steve Ellcey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fc64c2a2-b90e-42d6-856e-11553133b099@EXCHHUB01.MIPS.com \
--to=sellcey@mips.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).