From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-x533.google.com (mail-ed1-x533.google.com [IPv6:2a00:1450:4864:20::533]) by sourceware.org (Postfix) with ESMTPS id 5529E38618CD for ; Fri, 15 Dec 2023 12:54:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 5529E38618CD Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 5529E38618CD Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::533 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702644857; cv=none; b=pCqHVs4qmK/+1ujM8glSsZVuP5Hdb+87ZLSXCSQZqEkh42i+I+HTnIbQjX7qXJcW8bHp/Xzo81wZL56zU7bg1fu+R4hV09ppRHtDxqQJebC2ClVdchdP3OrQT0tfUMS4+/zuXKzSZpkPh7pQIV/hmarySU1XTPV49CbhWR9jMAQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702644857; c=relaxed/simple; bh=nU1pxI6dOvmAUi6/i3iV5eO4tC1iiSA42367IKQzKhI=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=SmP93iO6lbD7iYXSF9+hrk4dqF3M/CFJsiEQ8ExbBSme/cICIY0JwAsOkCNHr7jO7LmeqV5BLj21IvyTmiXes0qQhd1zzjTvXrcabvQ7hM7EEMK8rX+g1UsOEz8jgAhpYscaxpaoWeztn2mJ2666CJaUlTesjDdsR7RNlOOVH+c= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-ed1-x533.google.com with SMTP id 4fb4d7f45d1cf-552d4483414so526218a12.2 for ; Fri, 15 Dec 2023 04:54:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1702644855; x=1703249655; darn=gcc.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:cc:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Qtg73NruPuBxKxR076z/21qcj2/pKtG/TzemNojgbVM=; b=JdxIKaQ8WF0BNsmXefEUfE9kG1sgVnqP+hu7+zh5Cq4Wd4836pxLyLexz8W7g5jJAS 3tOh0FJnFIJq2aV3DYXLWESbl69wIQkIzY6C+/nbdzt+t7CCbhKUV6aVGcTiehpjTc5K YD9RaGE3sbioj5wUu2PA6SBQulTLH0P5TzRfhNZNihq0kA8oUhYkmwM6/KS9s/bgz5uA 2JYm0TGzRZGgvutd7jNSmUmpQm4rp2MlDolsBRMoRbUmEs4dAUwAvi1SU1Q2+wvA3Fgm iLcFw54HaGqzYCRwV54g8H5ZWPcCAcgO726N682IUnWeHEC7+mKDB2YRXLF7WVVFJM7Z B+gg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702644855; x=1703249655; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:cc:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Qtg73NruPuBxKxR076z/21qcj2/pKtG/TzemNojgbVM=; b=Ri/40nUSoxf7Y3SSSA6ljW9kdnsZ2n2vPnL4GaX68lW6h7efJtQqxg8r+UmcQhCxBH wspuzf1G9cgWdmeRid1KRvZOhA9z7/Wuw5zgrbJjrp5G68VlVSbhD5I/49OyYZBgmdBS EtdJa3HUs79L1x7k1syaK1/3rc02nwBTt5vaLxnj4nmKjLSOkQfGt0eNmeC/C/Iwqkoe MWC0puH0Pscofa7gkUUbxurXcuZxfPePSR84oTCXOwB4lcejCiRPFK43Ni/dwSCuMq8Z FezoNnu0txo4A77KhtUbPXLFwU4DDsT5BNqCze12Uk/ucIQp2wSUPURZkTMISmidcEgQ sm9A== X-Gm-Message-State: AOJu0YxpErCzFFfVRJe9tZ1wmmfTZS3kTlvej3ZWYLTLCuJZRpyz8ylq NC5jyJI76inobPzZfViLrYI= X-Google-Smtp-Source: AGHT+IG9yTfGSNepDfGwy3uT9prZsH/RFdxZIBb8XiHy3u3bL1NtbYliN6LfNFvXI1a370cTdHDJ3Q== X-Received: by 2002:a17:906:2dcc:b0:a23:ff5:c249 with SMTP id h12-20020a1709062dcc00b00a230ff5c249mr1439561eji.102.1702644855003; Fri, 15 Dec 2023 04:54:15 -0800 (PST) Received: from [192.168.1.23] (ip-149-172-150-237.um42.pools.vodafone-ip.de. [149.172.150.237]) by smtp.gmail.com with ESMTPSA id uv6-20020a170907cf4600b00a1f699e5217sm10428884ejc.135.2023.12.15.04.54.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 15 Dec 2023 04:54:14 -0800 (PST) Message-ID: Date: Fri, 15 Dec 2023 13:54:13 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Cc: rdapp.gcc@gmail.com, "kito.cheng" , "Kito.cheng" , jeffreyalaw Subject: Re: [PATCH] RISC-V: Fix vmerge optimization bug in vec_perm vectorization Content-Language: en-US To: "juzhe.zhong@rivai.ai" , gcc-patches References: <20231215025750.159162-1-juzhe.zhong@rivai.ai> <7f799b3f-ced5-4c95-a40e-370d028005af@gmail.com> <5F78E561522A59F4+2023121520165641829969@rivai.ai> <50e3e3d0-3af6-4e7b-a8cf-a16a7cbef077@gmail.com> <7872722C291EDF78+2023121520320530796473@rivai.ai> <45f4211c-c045-4c5b-a853-453627159cfe@gmail.com> <06AA6DA91333CF1A+2023121520520243628474@rivai.ai> From: Robin Dapp In-Reply-To: <06AA6DA91333CF1A+2023121520520243628474@rivai.ai> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-3.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 12/15/23 13:52, juzhe.zhong@rivai.ai wrote: > Do you mean : > >   /* We need to use precomputed mask for such situation and such mask >      can only be computed in compile-time known size modes.  */ >   bool indices_fit_selector_p >     = GET_MODE_BITSIZE (GET_MODE_INNER (vmode)) > 8 || known_lt (vec_len, 256); >   if (!indices_fit_selector_p && !vec_len.is_constant ()) >     return false; Yes and then reuse this in the if. Regards Robin