From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id D50793858C83 for ; Mon, 26 Sep 2022 21:22:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D50793858C83 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1664227347; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=eDMHM5yaC0yqlNVgWdtzc3LFiubm4ldad147Ph8yHdc=; b=abz7PxYYQJOtz2JV9fsivHCUVxhsoUe7SA6JuR8wsYi8Uqwnek/YcFX/GS6LWC+fhcCMVa FO7mfdtueXT8vJ4zAeexLamiALhe6juyGBxvEIcEfczV9rxXe6soFBYz5BWESjMh9FIg3/ 9qT2qE7T4iQeJfOKEgWjfbPm7Ix9Irw= Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-489-BHl2h4lqPhO9NJhe-j2kCA-1; Mon, 26 Sep 2022 17:22:26 -0400 X-MC-Unique: BHl2h4lqPhO9NJhe-j2kCA-1 Received: by mail-qk1-f197.google.com with SMTP id x22-20020a05620a259600b006b552a69231so5886520qko.18 for ; Mon, 26 Sep 2022 14:22:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=eDMHM5yaC0yqlNVgWdtzc3LFiubm4ldad147Ph8yHdc=; b=eO/NxcHxToyZSxD6eWfyKeopnCBM0Dbxu2ve/LqA2HryHg/wTjMnh5wGO4aCdpftAZ wj1H8gFPwTxkb9TA44ELAt0LLSnsz2MH7rgLSkYVoT8OrS25GxlnLdsgmFk35XDBbYeL 5LsnXOJ897G+syrDWAY6diFwLUxNFXAlmVsoZ+BNEtnhCvq4lcsi8NleRqg2sI/r/mf6 pc1hah6605k5TRso84fnb0Ws5y6W7VPgBERTGn4mzj/U0vhpqN7NRCpnDXuLvF3mWpGM 9QQtyqeQ4/VdtuD+vXqcOaG15kSMquEt1jq7e7LTZus3g2/nBVIxuBf0BVd7uvlnHj80 eUYA== X-Gm-Message-State: ACrzQf1o1cdRUNaxNgf/mVsSXzG4sysd9P3jxPa7hPi00m/wFYatjatt Gj16YeOQUd3MeuGv4qCnRFXWuS+vF0XSH67sgF9PlqJec6ECzhMR14IGf6kIQ7SitriGqQGq+0f hcoUZ/HWFZA+8GLXGrA== X-Received: by 2002:a05:6214:daf:b0:49f:5ce8:e628 with SMTP id h15-20020a0562140daf00b0049f5ce8e628mr18557150qvh.115.1664227345883; Mon, 26 Sep 2022 14:22:25 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7cqPqu9wuS8GSwhnNvHBsqrGduFfkbplWpkNaCxQ/Qql2/Xui7Hr56A1//H6C+s7KEIIxYOQ== X-Received: by 2002:a05:6214:daf:b0:49f:5ce8:e628 with SMTP id h15-20020a0562140daf00b0049f5ce8e628mr18557134qvh.115.1664227345584; Mon, 26 Sep 2022 14:22:25 -0700 (PDT) Received: from [192.168.1.101] (130-44-159-43.s15913.c3-0.arl-cbr1.sbo-arl.ma.cable.rcncustomer.com. [130.44.159.43]) by smtp.gmail.com with ESMTPSA id n10-20020a05620a294a00b006b8f4ade2c9sm13024462qkp.19.2022.09.26.14.22.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 26 Sep 2022 14:22:25 -0700 (PDT) Message-ID: Date: Mon, 26 Sep 2022 17:22:24 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.13.1 Subject: Re: [EXTERNAL] Re: [PING][PATCH] Add instruction level discriminator support. To: Eugene Rozenfeld , "gcc-patches@gcc.gnu.org" Cc: Andi Kleen , Jan Hubicka References: <5d9b2795-8a75-e4ea-07b1-856e448064dc@redhat.com> <863206fe-f5d6-932c-9b92-811f37774427@redhat.com> From: Jason Merrill In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-8.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 9/8/22 20:45, Eugene Rozenfeld wrote: > Jason, > > Thank for your suggestion. The patch is updated (attached). > @@ -467,12 +471,19 @@ lto_location_cache::apply_location_cache () > current_loc = set_block (current_loc, loc.block); > else > current_loc = LOCATION_LOCUS (current_loc); > + if (loc.discr) > + current_loc = location_with_discriminator (current_loc, loc.discr); > + } > + else if (current_discr != loc.discr) > + { > + current_loc = location_with_discriminator (current_loc, loc.discr); > } We usually don't use { } around a single line. > @@ -1180,6 +1206,7 @@ assign_discriminators (void) > location_t locus = last ? gimple_location (last) : UNKNOWN_LOCATION; > > if (locus == UNKNOWN_LOCATION) > + > continue; Stray newline. OK with those tweaks. Jason