From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa1.mentor.iphmx.com (esa1.mentor.iphmx.com [68.232.129.153]) by sourceware.org (Postfix) with ESMTPS id 2AE283858402 for ; Thu, 9 Dec 2021 16:42:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 2AE283858402 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mentor.com IronPort-SDR: iDIbWibpSuNLzcOhvM7NWs3fJHjo57voxqwJLQnmebUz1atetAiOel3WPEkoA8E+orCX8lUX46 mO+L7ET/3mJWV+cN63HuoUkFz+BVOiWcsBeHQCwSaxok81Ag3tW87Qcx8nhEfaAwz3w3hHh31n Hm+S4FWhvIh9nOH6cHfD71QdNXQQvA5MzKttJIsYlGAeiIPtGXVdlbDVgsiG+vEGFlacO47PW6 5SC80UNttgvAGVEpd/P4ANDWg5UDuRkBcJjvT5xEgyx9JUaciyLXeWCKoaKUURKlc3KXuJYILp IAPnOMsZdHb4QQE76zP0pqex X-IronPort-AV: E=Sophos;i="5.88,193,1635235200"; d="scan'208";a="72014445" Received: from orw-gwy-02-in.mentorg.com ([192.94.38.167]) by esa1.mentor.iphmx.com with ESMTP; 09 Dec 2021 08:42:13 -0800 IronPort-SDR: 6W4YWtBTZ+gQdZQu6SmEegmFE6smp6TDsRuA1ISZOUX9IqJcRInPoMKe8JKb/FKCnRGH6L6824 d1mqnCywZG6iWXXA4nPBnjqMPuk+zjW6oBFN4PmJw4i+o/rc6pBtYmXsHp1FosRf1Kj3Shth4p O8uh5XjEmilzbV6de3ibdzx/RVMBC4SLMRWavDu3NfYL+bFPkiuCg3u5ekQrpcYEm8wbvBCx91 qQBtzhXGoBZrSulq0JVybvp2bAJNc6W8w9AZaNKpwhXNuL1dgwscj/a8K/rCcrxGhsnPyX5Oex +c4= Message-ID: Date: Fri, 10 Dec 2021 00:41:59 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:91.0) Gecko/20100101 Thunderbird/91.3.2 Subject: Re: [PATCH, v5, OpenMP 5.0] Improve OpenMP target support for C++ [PR92120 v5] Content-Language: en-US To: Jakub Jelinek , Thomas Schwinge CC: gcc-patches , Catherine Moore References: <20210624131551.GR7746@tucnak> <20211203164706.GT2646553@tucnak> From: Chung-Lin Tang In-Reply-To: <20211203164706.GT2646553@tucnak> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: svr-orw-mbx-11.mgc.mentorg.com (147.34.90.211) To svr-orw-mbx-02.mgc.mentorg.com (147.34.90.202) X-Spam-Status: No, score=-5.9 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, NICE_REPLY_A, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Dec 2021 16:42:15 -0000 On 2021/12/4 12:47 AM, Jakub Jelinek wrote: > On Tue, Nov 16, 2021 at 08:43:27PM +0800, Chung-Lin Tang wrote: >> 2021-11-16 Chung-Lin Tang >> >> PR middle-end/92120 >> >> gcc/cp/ChangeLog: >> ... >> + if (allow_zero_length_array_sections) >> + { >> + /* When allowing attachment to zero-length array sections, we >> + allow attaching to NULL pointers when the target region is not >> + mapped. */ >> + data = 0; >> + } > > No {}s around single statement if body. > > Otherwise LGTM. > > Jakub > Thanks for the review and approval, Jakub. Thomas, I pushed another 2766448c5cc3efc4 commit to fix the non-offload config FAILs, just FYI. Chung-Lin