From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by sourceware.org (Postfix) with ESMTPS id 0E4753889800 for ; Thu, 20 Jun 2024 08:38:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0E4753889800 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linux.ibm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 0E4753889800 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=148.163.158.5 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1718872703; cv=none; b=iRmlxRDtaPKmzYeLcqWrd7yZZzPKraBcl9ZN9Q2Hr7CfLCl9xw3YmW2YGDDb1sLaWOLNQoEfgrWXFHohYparEYDlaQVixmEBDLFCUutoxBHkW3/rE2MHX2b8ujA9GcZC5JjrRwxysz4ZbN51nAu0A5FjomCxJXQek6gGSLnhGu4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1718872703; c=relaxed/simple; bh=oUlesCkAYukd6lk9ybuIVKIoJQYWpiL1TTvWbJ7fKkY=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=hCKrwz64zgXVJKOeiAMqdstuf1PXTck3jNwMeF3iftagVLGqgzZNuRcC4V58qwYCOtF5AT+YXIc2OmGipwi9KszLLVFRmb6EzgSajHYPud17K4pCHgjwN8f9CK2AGJFgLCS8FM1GCt5ahoR+Kl74TYsiGEgwGjj/6CytUd5Qdfc= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from pps.filterd (m0353722.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 45K8RFou030424; Thu, 20 Jun 2024 08:38:18 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h= message-id:date:mime-version:subject:to:references:from :in-reply-to:content-type:content-transfer-encoding; s=pp1; bh=t KKuKSF7U84UPAD7QEP1m7ZqKH06WlD4YRrcSYJyYYQ=; b=kp2/Nkn5aF2UJaswU Jb064Cm9C1UNtSsWltahACdzA0glC9AyMqVDfauWeos/l2F2vnOe2fhSBmVvzXd5 j40QvCG/PnTYVomuphaALJe6KpB6w09roHDEubU43b3E+lVfOR75w+cLlkTQAIzq L6z1P1ZESpIL/U8AANhhkvSl6QarSrvtksCqaEpY0I6XZy+NfQJh+ofLWwKyD2mZ jA6tX5mesEf2fJDlVZ0NB6rFRfWNnrc4nAmOJO8V9NyGLy7zBbzol1usyUEOmav8 m9LhRA2j++/BwtbWU6dUWpmrfu+0w5V4tVaTY7dfzEcmp6FwaLrEPkWzGyzkQ7Pc CA9ag== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3yverj0bjt-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 20 Jun 2024 08:38:17 +0000 (GMT) Received: from m0353722.ppops.net (m0353722.ppops.net [127.0.0.1]) by pps.reinject (8.18.0.8/8.18.0.8) with ESMTP id 45K8cHgB020798; Thu, 20 Jun 2024 08:38:17 GMT Received: from ppma23.wdc07v.mail.ibm.com (5d.69.3da9.ip4.static.sl-reverse.com [169.61.105.93]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3yverj0bjq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 20 Jun 2024 08:38:17 +0000 (GMT) Received: from pps.filterd (ppma23.wdc07v.mail.ibm.com [127.0.0.1]) by ppma23.wdc07v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 45K70WaB011010; Thu, 20 Jun 2024 08:38:16 GMT Received: from smtprelay02.fra02v.mail.ibm.com ([9.218.2.226]) by ppma23.wdc07v.mail.ibm.com (PPS) with ESMTPS id 3yspsnm2mu-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 20 Jun 2024 08:38:16 +0000 Received: from smtpav06.fra02v.mail.ibm.com (smtpav06.fra02v.mail.ibm.com [10.20.54.105]) by smtprelay02.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 45K8cA3154067618 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 20 Jun 2024 08:38:12 GMT Received: from smtpav06.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id AB2B32004D; Thu, 20 Jun 2024 08:38:10 +0000 (GMT) Received: from smtpav06.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id CFAA62004B; Thu, 20 Jun 2024 08:38:08 +0000 (GMT) Received: from [9.200.103.244] (unknown [9.200.103.244]) by smtpav06.fra02v.mail.ibm.com (Postfix) with ESMTP; Thu, 20 Jun 2024 08:38:08 +0000 (GMT) Message-ID: Date: Thu, 20 Jun 2024 16:38:06 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH-1v5] fwprop: Replace rtx_cost with insn_cost in try_fwprop_subst_pattern [PR113325] To: gcc-patches , Segher Boessenkool , David , "Kewen.Lin" , Peter Bergner , Jeff Law , richard.sandiford@arm.com References: <3f693aef-81df-46c5-bde2-83e4d998e65c@linux.ibm.com> Content-Language: en-US From: HAO CHEN GUI In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: 37H-EwPXAqnuHraE7pYMaEEZlQNzJIsm X-Proofpoint-GUID: 21e3CHATJaKAAcIRuBgmj8y2XyVly8RP X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.28.16 definitions=2024-06-20_04,2024-06-19_01,2024-05-17_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 impostorscore=0 bulkscore=0 lowpriorityscore=0 malwarescore=0 adultscore=0 clxscore=1015 phishscore=0 mlxlogscore=785 suspectscore=0 priorityscore=1501 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2405170001 definitions=main-2406200058 X-Spam-Status: No, score=-6.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,KAM_MANYTO,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Richard, 在 2024/6/20 16:05, Richard Sandiford 写道: > I'm not sure "profitability" means much in the case of debug insns. > There again, I suppose having no limit on the complexity of debug > insns would risk quadraticness and (even without that) would tend > to increase the size of the on-disk debug info. > > So I agree that the change is correct and that we should continue > to disallow debug insns here. Your guess is correct. Actually I found very complex debug insns in dump of fwprop pass if gcc doesn't check profitability for debug insns. The compiling of "md5.c" or "sha1.c" can't complete within one night. So I think we should check profitability for debug insns also. I will fix the formatting and submit the patch. Thanks again for your review comments. Thanks Gui Haochen