From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-x42f.google.com (mail-pf1-x42f.google.com [IPv6:2607:f8b0:4864:20::42f]) by sourceware.org (Postfix) with ESMTPS id BF9593858C83 for ; Mon, 26 Sep 2022 23:23:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org BF9593858C83 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pf1-x42f.google.com with SMTP id d82so8136611pfd.10 for ; Mon, 26 Sep 2022 16:23:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=xMklv7nFfgxV2ofB2edbdbtOiKeXks4Zuvz6fafxWnY=; b=c+i1ATNG6fAKgmxpZfJ0O+bJd3M8EtDhrNROsq8XkI/v+x6mhWTrSnLEdsf/9phtag ypyp8GXa324TPLZlQYq2y3gI36LxV2t23zEJGRadewzyNv3Y7Uy8XN8JIthC6wWtyrf6 6b+VNqrTfzwv6ejWc+I8Pla51mKaJ9zbf2l41h2N9Ejv5Xt8eKnkbV7hybdGWkLnARGf r+RBvr4E7YdEfCNG8UqmIZwubTp4CBAbXUlBcDX8UZcCk5inyi5xHVZHNiSNE2vnlg+S 3lGunrE98LDkqgw/b0xqmo3Fc+JkDgC0Jq5jkiYVFyJuAY8SsRaeqsZpxuApsRfWoMdE Eqzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=xMklv7nFfgxV2ofB2edbdbtOiKeXks4Zuvz6fafxWnY=; b=DqVo/c8+rIaBu0nhdWEKgrsOSBBJ8NnEG66G623bL1fhKtrgRK3DOgp578gZfFgCaN phvgsgYGg0aduUUb15MGcpMKfFGhv292PSHq6WowL+maUxMPCqygQBc8VFhwLX/VrNwg qece9SSniL+jLIwIXdTItGCS2e5iuaxxs4l5CbmrYpgRpLq9YyVD0pd8Emr7O+oD3aDF b7wgFPQXeBY+oeU5/5AjYqDYYglXczIc8lxwWEPFs86YkoQ8oTNwyKhyUVSbrHtDOLuq 9V9HA4VSvPtPdjCnOwFeyrc6nrc7EoI0qjIiGH6Ptzo9+quGpsEIvfeYS1g4+7LpWqOX g52Q== X-Gm-Message-State: ACrzQf28PkNs9KkvQRkHhMe9uzcVeDnGCbUzPrFxKcrr1TVNKlO0wc1e emllaaIAt/r7H1MVKJ8c5r8= X-Google-Smtp-Source: AMsMyM7NPdZKRZ3KJmAesY/rS8lGxUVCKwp0ULuZJ2q8xdZLl/1IGxoakPkXMMNykwc+dHCpKH5JHA== X-Received: by 2002:a65:580a:0:b0:439:befc:d2b0 with SMTP id g10-20020a65580a000000b00439befcd2b0mr21680542pgr.302.1664234627594; Mon, 26 Sep 2022 16:23:47 -0700 (PDT) Received: from ?IPV6:2601:681:8600:13d0::f0a? ([2601:681:8600:13d0::f0a]) by smtp.gmail.com with ESMTPSA id d5-20020a170902cec500b00176a715653dsm11882237plg.145.2022.09.26.16.23.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 26 Sep 2022 16:23:47 -0700 (PDT) Message-ID: Date: Mon, 26 Sep 2022 17:23:45 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH] Ignore debug insns with CONCAT and CONCATN for insn scheduling Content-Language: en-US To: "H.J. Lu" Cc: gcc-patches@gcc.gnu.org References: <20220902143639.2464892-1-hjl.tools@gmail.com> <93fb0c92-c6a4-450b-2d0a-eddd30543fae@gmail.com> From: Jeff Law In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 9/26/22 13:52, H.J. Lu wrote: > On Sat, Sep 24, 2022 at 1:37 PM Jeff Law wrote: >> >> On 9/21/22 16:11, H.J. Lu wrote: >>> On Wed, Sep 7, 2022 at 10:03 AM Jeff Law via Gcc-patches >>> wrote: >>>> >>>> On 9/2/2022 8:36 AM, H.J. Lu via Gcc-patches wrote: >>>>> CONCAT and CONCATN never appear in the insn chain. They are only used >>>>> in debug insn. Ignore debug insns with CONCAT and CONCATN for insn >>>>> scheduling to avoid different insn orders with and without debug insn. >>>>> >>>>> gcc/ >>>>> >>>>> PR rtl-optimization/106746 >>>>> * sched-deps.cc (sched_analyze_2): Ignore debug insns with CONCAT >>>>> and CONCATN. >>>> Shouldn't we be ignoring everything in a debug insn? I don't see why >>>> CONCAT/CONCATN are special here. >>> Debug insns are processed by insn scheduling. I think it is to improve debug >>> experiences. It is just that there are no matching usages of CONCAT/CONCATN >>> in non-debug insns. >> But from a dependency standpoint ISTM all debug insn can be ignored. I >> still don't see why concat/concatn should be special here. >> > I tried to ignore everything in a debug insn. It caused many regressions in > the GCC testsuite. Not terribly useful -- what failed and why? jeff